neoarz/SideStore
1
0
Fork 0
mirror of https://github.com/SideStore/SideStore.git synced 2026-02-09 14:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Always displays PatreonViewController loading indicator when fetching patrons

Browse Source 
Previously, we only showed the loading indicator if user had not yet cached any Friend Zone patrons.
This commit is contained in:
Riley Testut
2022-09-21 17:31:23 -05:00
parent 81b079650c
commit c8f3c6515d
1 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
AltStore/Settings/PatreonViewController.swift
View File

@@ -246,7 +246,8 @@ private extension PatreonViewController
@objc func didUpdatePatrons(_ notification: Notification)
{
DispatchQueue.main.async {
DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
// Wait short delay before reloading or else footer won't properly update if it's already visible 🤷‍♂️
self.collectionView.reloadData()
}
}
@@ -278,17 +279,27 @@ extension PatreonViewController
footerView.button.isHidden = false
footerView.button.addTarget(self, action: #selector(PatreonViewController.fetchPatrons), for: .primaryActionTriggered)
if self.patronsDataSource.itemCount > 0
switch AppManager.shared.updatePatronsResult
{
footerView.button.isHidden = true
}
else
{
switch AppManager.shared.updatePatronsResult
case .none: footerView.button.isIndicatingActivity = true
case .success?: footerView.button.isHidden = true
case .failure?:
#if DEBUG
let debug = true
#else
let debug = false
#endif
if self.patronsDataSource.itemCount == 0 || debug
{
case .none: footerView.button.isIndicatingActivity = true
case .success?: footerView.button.isHidden = true
case .failure?: footerView.button.setTitle(NSLocalizedString("Error Loading Patrons", comment: ""), for: .normal)
// Only show error message if there aren't any cached Patrons (or if this is a debug build).
footerView.button.isHidden = false
footerView.button.setTitle(NSLocalizedString("Error Loading Patrons", comment: ""), for: .normal)
}
else
{
footerView.button.isHidden = true
}
}
@@ -326,7 +337,7 @@ extension PatreonViewController: UICollectionViewDelegateFlowLayout
switch section
{
case .about: return .zero
case .patrons: return CGSize(width: 320, height: 20)
case .patrons: return CGSize(width: 320, height: 44)
}
}
}