Commit Graph

83 Commits

Author SHA1 Message Date
Riley Testut
1a3039767e Fixes button titles flashing when scrolling into view 2023-12-08 18:30:30 -06:00
Riley Testut
39e170d56a Shows source/category icon next to BrowseViewController’s title
Also tints all navigation bar buttons to match source/category tint color.

# Conflicts:
#	AltStore/Browse/BrowseViewController.swift
2023-12-08 15:25:00 -06:00
Riley Testut
160ac21858 Shows “Pledge Expired” for installed Patreon apps without active pledge 2023-12-08 15:25:00 -06:00
Riley Testut
7db14b930c Fixes showing “Update” for Patreon apps with inactive pledges 2023-12-08 15:24:40 -06:00
Riley Testut
640d2021ef Fixes incorrect initial size for website button on Source detail page 2023-12-08 15:24:40 -06:00
Riley Testut
34aa94fe65 Limits paging app screenshots on FeaturedViewController to bottom of cell
Prioritizes paging featured apps over app screenshots.
2023-12-08 15:15:10 -06:00
Riley Testut
3be4863ec2 Completely redesigns Browse tab with FeaturedViewController 2023-12-08 15:15:10 -06:00
Riley Testut
e0944b2670 Moves caption below app + developer name in AppCardCollectionViewCell 2023-12-08 14:04:36 -06:00
Riley Testut
e915c1ac8c Shows app’s source icon on AppBannerView
Excluding contexts where it is redundant (e.g. source detail page).
2023-12-08 14:04:36 -06:00
Riley Testut
0d9de4814d Adopts automatic status bar tinting on iOS 17 for App + Source detail screens 2023-12-07 16:50:31 -06:00
Riley Testut
fe3d8a4edb Hides “UPDATE” option for Patreon apps with expired pledges 2023-12-01 16:50:48 -06:00
Riley Testut
2c1ffedfe3 Designates Patreon apps with label + displays price (if provided) 2023-12-01 16:50:48 -06:00
Riley Testut
f9cff51d1c Supports updating apps from (almost) all AppBannerViews
Previously, you could only update apps from MyAppsViewController and AppViewController.
2023-12-01 16:50:48 -06:00
Riley Testut
3120c036c8 Fixes incorrectly centering screenshot thumbnail when there’s only one visible initially 2023-10-20 17:13:28 -05:00
Riley Testut
f11cef5352 Shrinks AppCardCollectionViewCell height if there are no screenshots 2023-10-19 17:18:48 -05:00
Riley Testut
fd11278f03 Fixes AppBannerView sticking to safe area when scrolling 2023-10-19 16:48:58 -05:00
Riley Testut
a6bc4b5d5f Merge branch 'revised_source_json'
# Conflicts:
#	AltStore.xcodeproj/project.pbxproj
#	AltStore/App Detail/AppContentViewController.swift
#	AltStore/App Detail/AppViewController.swift
#	AltStore/Base.lproj/Main.storyboard
#	AltStoreCore/Model/DatabaseManager.swift
2023-10-19 16:43:50 -05:00
Riley Testut
2822c52f11 Replaces BrowseCollectionViewCell with AppCardCollectionViewCell
* Handles dynamic screenshot sizes
* Allows swiping through screenshots
* Supports iPhone + iPad screenshots
2023-10-19 16:24:56 -05:00
Riley Testut
253aff29e9 Fixes misplaced back button 2023-10-18 19:11:11 -05:00
Riley Testut
0659d83afb Adds AddSourceViewController to add sources by URL or from list of recommended sources 2023-10-18 18:56:40 -05:00
Riley Testut
5a79eefc70 Fixes “Unable to satisfy constraints” warnings for SourcesViewController 2023-10-17 15:55:51 -05:00
Riley Testut
1b56ac708f Refactors SourceViewController into dedicated tab
* Updates UI to use source icons + tint colors
* Adds Edit button + swipe actions
2023-10-17 14:49:13 -05:00
Riley Testut
1a5ffcdd31 Adjusts illegible Source tint colors for SourceDetailViewController 2023-10-16 19:10:34 -05:00
Riley Testut
d890af0160 Adds AppBannerView.style to switch between app and source styles
`app` banners have rounded rect icons and use a lighter version of tint color as background, while `source` banners have circular icons and use the original tint color as background.
2023-10-16 19:03:04 -05:00
Riley Testut
4e104ac674 Adds PillButton.style to switch between pill and custom styles
`pill` style enforces minimum size + content insets, while `custom` doesn’t.
2023-10-16 18:52:39 -05:00
Riley Testut
b43bdede74 Adds AppIconImageView.style to switch between icon and circular styles
`icon` approximates the rounded corners of an app icon, while `circular` makes the icon a circle.
2023-10-16 18:40:36 -05:00
Riley Testut
c50e351e88 Fixes CollapsingTextView “More” button incorrectly appearing if lineCount == maximumNumberOfLines 2023-05-29 16:47:30 -05:00
Riley Testut
11ade8e54b Fixes AppViewController scrolling performance for apps with several privacy permissions 2023-05-29 16:47:30 -05:00
Riley Testut
5a2b98a398 Fixes PillButton not respecting progressTintColor under certain conditions 2023-04-04 17:50:49 -05:00
Riley Testut
aea0977110 Removes unused NavigationBar.backgroundColorView 2023-04-04 17:50:49 -05:00
Riley Testut
0b3765f3c4 Fixes tapping buttons underneath navigation bar on SourceDetailViewController/AppViewController 2023-04-04 17:12:18 -05:00
Riley Testut
d7410b7f60 Dynamically disables interactive back gesture when viewing source header image
Only disables gesture if touches are within headerContainerView to ensure back gesture works as expected majority of the time.
2023-04-04 17:06:58 -05:00
Riley Testut
60641fccce Supports viewing all NewsItems and StoreApps for a source 2023-04-04 16:17:38 -05:00
Riley Testut
5c419aa333 Shows detailed source “About” page when adding 3rd-party sources
Allows users to preview sources before adding them to their AltStore.
2023-04-04 15:44:46 -05:00
Riley Testut
93b18974c1 Enforces 77x31 minimum size for PillButton 2023-04-04 15:44:46 -05:00
Riley Testut
3e70cfc996 Refactors SourcesViewController from Main.storyboard to new Sources.storyboard
Also refactors BannerCollectionViewCell to AppBannerCollectionViewCell to support initializing from code.
2023-04-04 14:37:11 -05:00
Riley Testut
d4b6d32b79 Fixes CollapsingTextView “TextKit 1 compatibility mode” runtime warning 2023-04-04 14:19:49 -05:00
Riley Testut
468e912e47 Removes unnecessary #available checks 2023-03-02 16:53:36 -06:00
Riley Testut
1255147844 Fixes UIActivityIndicatorView.style deprecation warnings 2023-03-02 14:48:20 -06:00
Riley Testut
42d433a11d Opens Error Log upon tapping ToastView showing logged error 2023-01-24 14:23:42 -06:00
Riley Testut
3b38d725d7 [Shared] Refactors error handling based on ALTLocalizedError protocol (#1115)
* [Shared] Revises ALTLocalizedError protocol

* Refactors errors to conform to revised ALTLocalizedError protocol

* [Missing Commit] Remaining changes for ALTLocalizedError

* [AltServer] Refactors errors to conform to revised ALTLocalizedError protocol

* [Missing Commit] Declares ALTLocalizedTitleErrorKey + ALTLocalizedDescriptionKey

* Updates Objective-C errors to match revised ALTLocalizedError

* [Missing Commit] Unnecessary ALTLocalizedDescription logic

* [Shared] Refactors NSError.withLocalizedFailure to properly support ALTLocalizedError

* [Shared] Supports adding localized titles to errors via NSError.withLocalizedTitle()

* Revises ErrorResponse logic to support arbitrary errors and user info values

* [Missed Commit] Renames CodableServerError to CodableError

* Merges ConnectionError into OperationError

* [Missed Commit] Doesn’t check ALTWrappedError’s userInfo for localizedDescription

* [Missed] Fixes incorrect errorDomain for ALTErrorEnums

* [Missed] Removes nonexistent ALTWrappedError.h

* Includes source file and line number in OperationError.unknown failureReason

* Adds localizedTitle to AppManager operation errors

* Fixes adding localizedTitle + localizedFailure to ALTWrappedError

* Updates ToastView to use error’s localizedTitle as title

* [Shared] Adds NSError.formattedDetailedDescription(with:)

Returns formatted NSAttributedString containing all user info values intended for displaying to the user.

* [Shared] Updates Error.localizedErrorCode to say “code” instead of “error”

* Conforms ALTLocalizedError to CustomStringConvertible

* Adds “View More Details” option to Error Log context menu to view detailed error description

* [Shared] Fixes NSError.formattedDetailedDescription appearing black in dark mode

* [AltServer] Updates error alert to match revised error logic

Uses error’s localizedTitle as alert title.

* [AltServer] Adds “View More Details” button to error alert to view detailed error info

* [AltServer] Renames InstallError to OperationError and conforms to ALTErrorEnum

* [Shared] Removes CodableError support for Date user info values

Not currently used, and we don’t want to accidentally parse a non-Date as a Date in the meantime.

* [Shared] Includes dynamic UserInfoValueProvider values in NSError.formattedDetailedDescription()

* [Shared] Includes source file + line in NSError.formattedDetailedDescription()

Automatically captures source file + line when throwing ALTErrorEnums.

* [Shared] Captures source file + line for unknown errors

* Removes sourceFunction from OperationError

* Adds localizedTitle to AuthenticationViewController errors

* [Shared] Moves nested ALTWrappedError logic to ALTWrappedError initializer

* [AltServer] Removes now-redundant localized failure from JIT errors

All JIT errors now have a localizedTitle which effectively says the same thing.

* Makes OperationError.Code start at 1000

“Connection errors” subsection starts at 1200.

* [Shared] Updates Error domains to revised [Source].[ErrorType] format

* Updates ALTWrappedError.localizedDescription to prioritize using wrapped NSLocalizedDescription as failure reason

* Makes ALTAppleAPIError codes start at 3000

* [AltServer] Adds relevant localizedFailures to ALTDeviceManager.installApplication() errors

* Revises OperationError failureReasons and recovery suggestions

All failure reasons now read correctly when preceded by a failure reason and “because”.

* Revises ALTServerError error messages
All failure reasons now read correctly when preceded by a failure reason and “because”.

* Most failure reasons now read correctly when preceded by a failure reason and “because”.
* ALTServerErrorUnderlyingError forwards all user info provider calls to underlying error.

* Revises error messages for ALTAppleAPIErrorIncorrectCredentials

* [Missed] Removes NSError+AltStore.swift from AltStore target

* [Shared] Updates AltServerErrorDomain to revised [Source].[ErrorType] format

* [Shared] Removes “code” from Error.localizedErrorCode

* [Shared] Makes ALTServerError codes (appear to) start at 2000

We can’t change the actual error codes without breaking backwards compatibility, so instead we just add 2000 whenever we display ALTServerError codes to the user.

* Moves VerificationError.errorFailure to VerifyAppOperation

* Supports custom failure reason for OperationError.unknown

* [Shared] Changes AltServerErrorDomain to “AltServer.ServerError”

* [Shared] Converts ALTWrappedError to Objective-C class

NSError subclasses must be written in ObjC for Swift.Error <-> NSError bridging to work correctly.

# Conflicts:
#	AltStore.xcodeproj/project.pbxproj

* Fixes decoding CodableError nested user info values
2023-01-24 13:56:41 -06:00
Riley Testut
6d081c2bbb Fixes CollapsingTextView incorrectly showing More button 2022-09-09 16:03:24 -05:00
Riley Testut
1f7c089c70 Supports adding trusted sources from SourcesViewController
Previously, only the beta version of AltStore could add sources. Now, the public version supports adding explicitly “trusted” sources, while the beta version can continue to add any source.
2022-04-14 16:33:49 -07:00
Riley Testut
6e4feecff0 Adds ALTLocalizedError.underlyingError
Allows for easily wrapping underlying errors while preserving localized descriptions.
2021-02-26 15:25:12 -06:00
Riley Testut
f1a39e1a1f [AltStoreCore] Refactors core AltStore logic into AltStoreCore framework
AltStoreCore will contain all shared AltStore code between AltStore and any app extensions. Initially, it includes all AltStore model logic.
2020-09-03 16:39:08 -07:00
Riley Testut
3817f700b9 Merge branch 'accessibility_improvements' into develop
# Conflicts:
#	AltStore/Sources/SourcesViewController.swift
2020-08-28 12:39:05 -07:00
Riley Testut
4c3d33efdc Shows source errors in SourcesViewController 2020-08-27 16:39:03 -07:00
Riley Testut
b7564207b3 Improves error handling when fetching multiple sources
Fetching sources is no longer all or nothing. Now if a source cannot be fetched, it won’t prevent other sources from being updated.
2020-08-27 16:28:13 -07:00
Riley Testut
f02fcad3a0 Announces errors when VoiceOver is enabled 2020-08-27 15:24:26 -07:00
Riley Testut
a3a4af182d Improves AppBannerView accessibility 2020-08-27 15:23:21 -07:00