* [Shared] Revises ALTLocalizedError protocol
* Refactors errors to conform to revised ALTLocalizedError protocol
* [Missing Commit] Remaining changes for ALTLocalizedError
* [AltServer] Refactors errors to conform to revised ALTLocalizedError protocol
* [Missing Commit] Declares ALTLocalizedTitleErrorKey + ALTLocalizedDescriptionKey
* Updates Objective-C errors to match revised ALTLocalizedError
* [Missing Commit] Unnecessary ALTLocalizedDescription logic
* [Shared] Refactors NSError.withLocalizedFailure to properly support ALTLocalizedError
* [Shared] Supports adding localized titles to errors via NSError.withLocalizedTitle()
* Revises ErrorResponse logic to support arbitrary errors and user info values
* [Missed Commit] Renames CodableServerError to CodableError
* Merges ConnectionError into OperationError
* [Missed Commit] Doesn’t check ALTWrappedError’s userInfo for localizedDescription
* [Missed] Fixes incorrect errorDomain for ALTErrorEnums
* [Missed] Removes nonexistent ALTWrappedError.h
* Includes source file and line number in OperationError.unknown failureReason
* Adds localizedTitle to AppManager operation errors
* Fixes adding localizedTitle + localizedFailure to ALTWrappedError
* Updates ToastView to use error’s localizedTitle as title
* [Shared] Adds NSError.formattedDetailedDescription(with:)
Returns formatted NSAttributedString containing all user info values intended for displaying to the user.
* [Shared] Updates Error.localizedErrorCode to say “code” instead of “error”
* Conforms ALTLocalizedError to CustomStringConvertible
* Adds “View More Details” option to Error Log context menu to view detailed error description
* [Shared] Fixes NSError.formattedDetailedDescription appearing black in dark mode
* [AltServer] Updates error alert to match revised error logic
Uses error’s localizedTitle as alert title.
* [AltServer] Adds “View More Details” button to error alert to view detailed error info
* [AltServer] Renames InstallError to OperationError and conforms to ALTErrorEnum
* [Shared] Removes CodableError support for Date user info values
Not currently used, and we don’t want to accidentally parse a non-Date as a Date in the meantime.
* [Shared] Includes dynamic UserInfoValueProvider values in NSError.formattedDetailedDescription()
* [Shared] Includes source file + line in NSError.formattedDetailedDescription()
Automatically captures source file + line when throwing ALTErrorEnums.
* [Shared] Captures source file + line for unknown errors
* Removes sourceFunction from OperationError
* Adds localizedTitle to AuthenticationViewController errors
* [Shared] Moves nested ALTWrappedError logic to ALTWrappedError initializer
* [AltServer] Removes now-redundant localized failure from JIT errors
All JIT errors now have a localizedTitle which effectively says the same thing.
* Makes OperationError.Code start at 1000
“Connection errors” subsection starts at 1200.
* [Shared] Updates Error domains to revised [Source].[ErrorType] format
* Updates ALTWrappedError.localizedDescription to prioritize using wrapped NSLocalizedDescription as failure reason
* Makes ALTAppleAPIError codes start at 3000
* [AltServer] Adds relevant localizedFailures to ALTDeviceManager.installApplication() errors
* Revises OperationError failureReasons and recovery suggestions
All failure reasons now read correctly when preceded by a failure reason and “because”.
* Revises ALTServerError error messages
All failure reasons now read correctly when preceded by a failure reason and “because”.
* Most failure reasons now read correctly when preceded by a failure reason and “because”.
* ALTServerErrorUnderlyingError forwards all user info provider calls to underlying error.
* Revises error messages for ALTAppleAPIErrorIncorrectCredentials
* [Missed] Removes NSError+AltStore.swift from AltStore target
* [Shared] Updates AltServerErrorDomain to revised [Source].[ErrorType] format
* [Shared] Removes “code” from Error.localizedErrorCode
* [Shared] Makes ALTServerError codes (appear to) start at 2000
We can’t change the actual error codes without breaking backwards compatibility, so instead we just add 2000 whenever we display ALTServerError codes to the user.
* Moves VerificationError.errorFailure to VerifyAppOperation
* Supports custom failure reason for OperationError.unknown
* [Shared] Changes AltServerErrorDomain to “AltServer.ServerError”
* [Shared] Converts ALTWrappedError to Objective-C class
NSError subclasses must be written in ObjC for Swift.Error <-> NSError bridging to work correctly.
# Conflicts:
# AltStore.xcodeproj/project.pbxproj
* Fixes decoding CodableError nested user info values
The Patreon API doesn’t have a way to fetch just the patrons belonging to our Friend Zone tier. Instead, we need to fetch ALL patrons (including inactive ones) and filter out those not in the tier. This is very inefficient, and takes over a minute to complete as of April 14, 2022, due to the number of patrons we have.
We can’t do much to change this, but AltStore will now at least cache the fetched patrons with Core Data. Additionally, AltStore will only perform this long fetch whenever the Friend Zone list actually changes, rather than every time the Patreon screen appears.
