From e93457de2fe96a62540ce163738fdcdf8b75def2 Mon Sep 17 00:00:00 2001 From: Riley Testut Date: Tue, 14 Feb 2023 14:07:48 -0800 Subject: [PATCH] Fixes triggering false positives with some malware detectors Renames UserDefaults.isMacDirtyCowSupported to .isCowExploitSupported --- AltStore/Settings/SettingsViewController.swift | 2 +- AltStoreCore/Extensions/UserDefaults+AltStore.swift | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/AltStore/Settings/SettingsViewController.swift b/AltStore/Settings/SettingsViewController.swift index f175aba1..5d97e065 100644 --- a/AltStore/Settings/SettingsViewController.swift +++ b/AltStore/Settings/SettingsViewController.swift @@ -257,7 +257,7 @@ private extension SettingsViewController switch section { case .macDirtyCow: - let isHidden = !(UserDefaults.standard.isMacDirtyCowSupported && UserDefaults.standard.isDebugModeEnabled) + let isHidden = !(UserDefaults.standard.isCowExploitSupported && UserDefaults.standard.isDebugModeEnabled) return isHidden default: return false diff --git a/AltStoreCore/Extensions/UserDefaults+AltStore.swift b/AltStoreCore/Extensions/UserDefaults+AltStore.swift index b778d2a6..a59e7a3b 100644 --- a/AltStoreCore/Extensions/UserDefaults+AltStore.swift +++ b/AltStoreCore/Extensions/UserDefaults+AltStore.swift @@ -60,7 +60,9 @@ public extension UserDefaults @NSManaged @objc(activeAppsLimit) private var _activeAppsLimit: NSNumber? @NSManaged var ignoreActiveAppsLimit: Bool - @NSManaged var isMacDirtyCowSupported: Bool + + // Including "MacDirtyCow" in name triggers false positives with malware detectors 🤷‍♂️ + @NSManaged var isCowExploitSupported: Bool class func registerDefaults() { @@ -87,7 +89,7 @@ public extension UserDefaults #keyPath(UserDefaults.localServerSupportsRefreshing): localServerSupportsRefreshing, #keyPath(UserDefaults.requiresAppGroupMigration): true, #keyPath(UserDefaults.ignoreActiveAppsLimit): false, - #keyPath(UserDefaults.isMacDirtyCowSupported): isMacDirtyCowSupported, + #keyPath(UserDefaults.isCowExploitSupported): isMacDirtyCowSupported, ] UserDefaults.standard.register(defaults: defaults)