neoarz/SideStore
1
0
Fork 0
mirror of https://github.com/SideStore/SideStore.git synced 2026-02-15 17:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

[AltServer] Fixes potential race condition crash when managing connections

Browse Source
This commit is contained in:
Riley Testut
2022-09-14 13:11:26 -07:00
committed by Joseph Mattello
parent eda4dd6aec
commit e3c331c911
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Shared/Connections/ConnectionManager.swift
View File

@@ -41,6 +41,7 @@ public class ConnectionManager<RequestHandlerType: RequestHandler>
public var isStarted = false public var isStarted = false
private var connections = [Connection]() private var connections = [Connection]()
private let connectionsLock = NSLock()
public init(requestHandler: RequestHandlerType, connectionHandlers: [ConnectionHandler]) public init(requestHandler: RequestHandlerType, connectionHandlers: [ConnectionHandler])
{ {
@@ -88,6 +89,9 @@ private extension ConnectionManager
{ {
func prepare(_ connection: Connection) func prepare(_ connection: Connection)
{ {
self.connectionsLock.lock()
defer { self.connectionsLock.unlock() }
guard !self.connections.contains(where: { $0 === connection }) else { return } guard !self.connections.contains(where: { $0 === connection }) else { return }
self.connections.append(connection) self.connections.append(connection)
@@ -96,6 +100,9 @@ private extension ConnectionManager
func disconnect(_ connection: Connection) func disconnect(_ connection: Connection)
{ {
self.connectionsLock.lock()
defer { self.connectionsLock.unlock() }
guard let index = self.connections.firstIndex(where: { $0 === connection }) else { return } guard let index = self.connections.firstIndex(where: { $0 === connection }) else { return }
self.connections.remove(at: index) self.connections.remove(at: index)
} }