fix: rename allowDevModeOnlyFeatures to inDevMode and simplify dummy filtering

This commit is contained in:
naturecodevoid
2023-05-20 14:35:29 -07:00
parent 5709229fdf
commit e2c5267d3f
3 changed files with 5 additions and 5 deletions

View File

@@ -138,7 +138,7 @@ struct DevModeMenu: View {
NavigationLink(L10n.UnstableFeaturesView.title) { NavigationLink(L10n.UnstableFeaturesView.title) {
#if UNSTABLE #if UNSTABLE
UnstableFeaturesView(allowDevModeOnlyFeatures: true) UnstableFeaturesView(inDevMode: true)
#endif #endif
} }
#if !UNSTABLE #if !UNSTABLE

View File

@@ -173,7 +173,7 @@ struct SettingsView: View {
#if UNSTABLE #if UNSTABLE
NavigationLink(L10n.UnstableFeaturesView.title) { NavigationLink(L10n.UnstableFeaturesView.title) {
UnstableFeaturesView(allowDevModeOnlyFeatures: false) UnstableFeaturesView(inDevMode: false)
} }
#endif #endif

View File

@@ -12,11 +12,11 @@ import SwiftUI
struct UnstableFeaturesView: View { struct UnstableFeaturesView: View {
@ObservedObject private var shared = UnstableFeatures.shared @ObservedObject private var shared = UnstableFeatures.shared
var allowDevModeOnlyFeatures: Bool var inDevMode: Bool
var body: some View { var body: some View {
List { List {
ForEach(shared.features.filter { feature, _ in feature != AvailableUnstableFeature.dummy && allowDevModeOnlyFeatures ? true : feature.availableOutsideDevMode() }.sorted(by: { _, _ in true }), id: \.key) { feature, _ in ForEach(shared.features.filter { feature, _ in feature != .dummy && (inDevMode || feature.availableOutsideDevMode()) }.sorted(by: { _, _ in true }), id: \.key) { feature, _ in
Toggle(isOn: Binding(get: { UnstableFeatures.enabled(feature) }, set: { newValue in UnstableFeatures.set(feature, enabled: newValue) })) { Toggle(isOn: Binding(get: { UnstableFeatures.enabled(feature) }, set: { newValue in UnstableFeatures.set(feature, enabled: newValue) })) {
Text(String(describing: feature)) Text(String(describing: feature))
let link = "https://github.com/SideStore/SideStore/issues/\(feature.rawValue)" let link = "https://github.com/SideStore/SideStore/issues/\(feature.rawValue)"
@@ -29,7 +29,7 @@ struct UnstableFeaturesView: View {
struct UnstableFeaturesView_Previews: PreviewProvider { struct UnstableFeaturesView_Previews: PreviewProvider {
static var previews: some View { static var previews: some View {
UnstableFeaturesView(allowDevModeOnlyFeatures: true) UnstableFeaturesView(inDevMode: true)
} }
} }
#endif #endif