From d8f1dcb032a74c3f528fc077e9d03bd79ae04f3c Mon Sep 17 00:00:00 2001 From: Riley Testut Date: Sat, 16 May 2020 15:28:22 -0700 Subject: [PATCH] Adds RemoveAppBackupOperation to remove backed up app data --- AltStore.xcodeproj/project.pbxproj | 8 ++ AltStore/AltStore.entitlements | 4 + .../FileManager+SharedDirectories.swift | 32 ++++++++ AltStore/Info.plist | 4 + .../Operations/RemoveAppBackupOperation.swift | 79 +++++++++++++++++++ 5 files changed, 127 insertions(+) create mode 100644 AltStore/Extensions/FileManager+SharedDirectories.swift create mode 100644 AltStore/Operations/RemoveAppBackupOperation.swift diff --git a/AltStore.xcodeproj/project.pbxproj b/AltStore.xcodeproj/project.pbxproj index 7223e682..d33aeef1 100644 --- a/AltStore.xcodeproj/project.pbxproj +++ b/AltStore.xcodeproj/project.pbxproj @@ -135,6 +135,7 @@ BF58049B246A432D008AE704 /* NSError+LocalizedFailure.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF6C336124197D700034FD24 /* NSError+LocalizedFailure.swift */; }; BF5C5FCF237DF69100EDD0C6 /* ALTPluginService.m in Sources */ = {isa = PBXBuildFile; fileRef = BF5C5FCE237DF69100EDD0C6 /* ALTPluginService.m */; }; BF663C4F2433ED8200DAA738 /* FileManager+DirectorySize.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF663C4E2433ED8200DAA738 /* FileManager+DirectorySize.swift */; }; + BF6A5320246DC1B0004F59C8 /* FileManager+SharedDirectories.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF6A531F246DC1B0004F59C8 /* FileManager+SharedDirectories.swift */; }; BF6C336224197D700034FD24 /* NSError+LocalizedFailure.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF6C336124197D700034FD24 /* NSError+LocalizedFailure.swift */; }; BF6C33652419AE310034FD24 /* AltStore4ToAltStore5.xcmappingmodel in Sources */ = {isa = PBXBuildFile; fileRef = BF6C33642419AE310034FD24 /* AltStore4ToAltStore5.xcmappingmodel */; }; BF6C8FAC242935ED00125131 /* NSAttributedString+Markdown.m in Sources */ = {isa = PBXBuildFile; fileRef = BF6C8FAA242935ED00125131 /* NSAttributedString+Markdown.m */; }; @@ -239,6 +240,7 @@ BFDB6A0B22AAEDB7007EA6D6 /* Operation.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFDB6A0A22AAEDB7007EA6D6 /* Operation.swift */; }; BFDB6A0D22AAFC1A007EA6D6 /* OperationError.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFDB6A0C22AAFC19007EA6D6 /* OperationError.swift */; }; BFDB6A0F22AB2776007EA6D6 /* SendAppOperation.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFDB6A0E22AB2776007EA6D6 /* SendAppOperation.swift */; }; + BFDBBD80246CB84F004ED2F3 /* RemoveAppBackupOperation.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFDBBD7F246CB84F004ED2F3 /* RemoveAppBackupOperation.swift */; }; BFE338DD22F0E7F3002E24B9 /* Source.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFE338DC22F0E7F3002E24B9 /* Source.swift */; }; BFE338DF22F0EADB002E24B9 /* FetchSourceOperation.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFE338DE22F0EADB002E24B9 /* FetchSourceOperation.swift */; }; BFE338E822F10E56002E24B9 /* LaunchViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = BFE338E722F10E56002E24B9 /* LaunchViewController.swift */; }; @@ -470,6 +472,7 @@ BF5C5FCD237DF69100EDD0C6 /* ALTPluginService.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ALTPluginService.h; sourceTree = ""; }; BF5C5FCE237DF69100EDD0C6 /* ALTPluginService.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ALTPluginService.m; sourceTree = ""; }; BF663C4E2433ED8200DAA738 /* FileManager+DirectorySize.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "FileManager+DirectorySize.swift"; sourceTree = ""; }; + BF6A531F246DC1B0004F59C8 /* FileManager+SharedDirectories.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "FileManager+SharedDirectories.swift"; sourceTree = ""; }; BF6C336124197D700034FD24 /* NSError+LocalizedFailure.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSError+LocalizedFailure.swift"; sourceTree = ""; }; BF6C33632419ADEB0034FD24 /* AltStore 5.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = "AltStore 5.xcdatamodel"; sourceTree = ""; }; BF6C33642419AE310034FD24 /* AltStore4ToAltStore5.xcmappingmodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcmappingmodel; path = AltStore4ToAltStore5.xcmappingmodel; sourceTree = ""; }; @@ -591,6 +594,7 @@ BFDB6A0A22AAEDB7007EA6D6 /* Operation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Operation.swift; sourceTree = ""; }; BFDB6A0C22AAFC19007EA6D6 /* OperationError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OperationError.swift; sourceTree = ""; }; BFDB6A0E22AB2776007EA6D6 /* SendAppOperation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SendAppOperation.swift; sourceTree = ""; }; + BFDBBD7F246CB84F004ED2F3 /* RemoveAppBackupOperation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RemoveAppBackupOperation.swift; sourceTree = ""; }; BFE338DC22F0E7F3002E24B9 /* Source.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Source.swift; sourceTree = ""; }; BFE338DE22F0EADB002E24B9 /* FetchSourceOperation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FetchSourceOperation.swift; sourceTree = ""; }; BFE338E722F10E56002E24B9 /* LaunchViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LaunchViewController.swift; sourceTree = ""; }; @@ -1217,6 +1221,7 @@ BFF0B6992322D7D0007A79E1 /* UIScreen+CompactHeight.swift */, BF6C336124197D700034FD24 /* NSError+LocalizedFailure.swift */, BF663C4E2433ED8200DAA738 /* FileManager+DirectorySize.swift */, + BF6A531F246DC1B0004F59C8 /* FileManager+SharedDirectories.swift */, ); path = Extensions; sourceTree = ""; @@ -1296,6 +1301,7 @@ BFCCB519245E3401001853EA /* VerifyAppOperation.swift */, BF44EEFB246B4550002A52F2 /* RemoveAppOperation.swift */, BF3432FA246B894F0052F4A1 /* BackupAppOperation.swift */, + BFDBBD7F246CB84F004ED2F3 /* RemoveAppBackupOperation.swift */, ); path = Operations; sourceTree = ""; @@ -1918,6 +1924,7 @@ BF2901312318F7A800D88A45 /* AppBannerView.swift in Sources */, BF3D648D22E79AC800E9056B /* ALTAppPermission.m in Sources */, BFD5D6F2230DD974007955AB /* Benefit.swift in Sources */, + BFDBBD80246CB84F004ED2F3 /* RemoveAppBackupOperation.swift in Sources */, BFF0B6942321CB85007A79E1 /* AuthenticationViewController.swift in Sources */, BF3432FB246B894F0052F4A1 /* BackupAppOperation.swift in Sources */, BF9ABA4922DD0742008935CF /* ScreenshotCollectionViewCell.swift in Sources */, @@ -1935,6 +1942,7 @@ BF770E5622BC3C03002A40FE /* Server.swift in Sources */, BFA8172923C56042001B5953 /* ServerConnection.swift in Sources */, BF56D2AF23DF9E310006506D /* AppIDsViewController.swift in Sources */, + BF6A5320246DC1B0004F59C8 /* FileManager+SharedDirectories.swift in Sources */, BF43003022A71C960051E2BC /* UserDefaults+AltStore.swift in Sources */, ); runOnlyForDeploymentPostprocessing = 0; diff --git a/AltStore/AltStore.entitlements b/AltStore/AltStore.entitlements index 903def2a..11842e8b 100644 --- a/AltStore/AltStore.entitlements +++ b/AltStore/AltStore.entitlements @@ -4,5 +4,9 @@ aps-environment development + com.apple.security.application-groups + + group.com.rileytestut.AltStore + diff --git a/AltStore/Extensions/FileManager+SharedDirectories.swift b/AltStore/Extensions/FileManager+SharedDirectories.swift new file mode 100644 index 00000000..d4de2eea --- /dev/null +++ b/AltStore/Extensions/FileManager+SharedDirectories.swift @@ -0,0 +1,32 @@ +// +// FileManager+SharedDirectories.swift +// AltStore +// +// Created by Riley Testut on 5/14/20. +// Copyright © 2020 Riley Testut. All rights reserved. +// + +import Foundation + +import AltKit + +extension FileManager +{ + var altstoreSharedDirectory: URL? { + guard let appGroup = Bundle.main.appGroups.first else { return nil } + + let sharedDirectoryURL = self.containerURL(forSecurityApplicationGroupIdentifier: appGroup) + return sharedDirectoryURL + } + + var appBackupsDirectory: URL? { + let appBackupsDirectory = self.altstoreSharedDirectory?.appendingPathComponent("Backups", isDirectory: true) + return appBackupsDirectory + } + + func backupDirectoryURL(for app: InstalledApp) -> URL? + { + let backupDirectoryURL = self.appBackupsDirectory?.appendingPathComponent(app.bundleIdentifier, isDirectory: true) + return backupDirectoryURL + } +} diff --git a/AltStore/Info.plist b/AltStore/Info.plist index 4df53e85..1f9ca88e 100644 --- a/AltStore/Info.plist +++ b/AltStore/Info.plist @@ -2,6 +2,10 @@ + ALTAppGroups + + group.com.rileytestut.AltStore + ALTDeviceID 00008030-001948590202802E ALTServerID diff --git a/AltStore/Operations/RemoveAppBackupOperation.swift b/AltStore/Operations/RemoveAppBackupOperation.swift new file mode 100644 index 00000000..142ebd84 --- /dev/null +++ b/AltStore/Operations/RemoveAppBackupOperation.swift @@ -0,0 +1,79 @@ +// +// RemoveAppBackupOperation.swift +// AltStore +// +// Created by Riley Testut on 5/13/20. +// Copyright © 2020 Riley Testut. All rights reserved. +// + +import Foundation + +import AltKit + +@objc(RemoveAppBackupOperation) +class RemoveAppBackupOperation: ResultOperation +{ + let context: InstallAppOperationContext + + private let coordinator = NSFileCoordinator() + private let coordinatorQueue = OperationQueue() + + init(context: InstallAppOperationContext) + { + self.context = context + + super.init() + + self.coordinatorQueue.name = "AltStore - RemoveAppBackupOperation Queue" + } + + override func main() + { + super.main() + + if let error = self.context.error + { + self.finish(.failure(error)) + return + } + + guard let installedApp = self.context.installedApp else { return self.finish(.failure(OperationError.invalidParameters)) } + installedApp.managedObjectContext?.perform { + guard let backupDirectoryURL = FileManager.default.backupDirectoryURL(for: installedApp) else { return self.finish(.failure(OperationError.missingAppGroup)) } + + let intent = NSFileAccessIntent.writingIntent(with: backupDirectoryURL, options: [.forDeleting]) + self.coordinator.coordinate(with: [intent], queue: self.coordinatorQueue) { (error) in + do + { + if let error = error + { + throw error + } + + try FileManager.default.removeItem(at: intent.url) + + self.finish(.success(())) + } + catch let error as CocoaError where error.code == CocoaError.Code.fileNoSuchFile + { + #if DEBUG + + // When debugging, it's expected that app groups don't match, so ignore. + self.finish(.success(())) + + #else + + print("Failed to remove app backup directory:", error) + self.finish(.failure(error)) + + #endif + } + catch + { + print("Failed to remove app backup directory:", error) + self.finish(.failure(error)) + } + } + } + } +}