Merge branch 'develop' into NoIdle

Signed-off-by: June Park <rjp2030@outlook.com>

AltStore/Operations/AuthenticationOperation.swift

@@ -12,6 +12,7 @@ import Network
 
 import AltStoreCore
 import AltSign
+import minimuxer
 
 enum AuthenticationError: LocalizedError
 {
@@ -593,7 +594,7 @@ private extension AuthenticationOperation
     
     func registerCurrentDevice(for team: ALTTeam, session: ALTAppleAPISession, completionHandler: @escaping (Result<ALTDevice, Error>) -> Void)
     {
-        guard let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String else {
+        guard let udid = fetch_udid()?.toString() else {
             return completionHandler(.failure(OperationError.unknownUDID))
         }
         

AltStore/Operations/ClearAppCacheOperation.swift

@@ -0,0 +1,208 @@
+//
+//  ClearAppCacheOperation.swift
+//  AltStore
+//
+//  Created by Riley Testut on 9/27/22.
+//  Copyright © 2022 Riley Testut. All rights reserved.
+//
+
+import Foundation
+import AltStoreCore
+/*
+struct BatchError: ALTLocalizedError
+{
+
+    enum Code: Int, ALTErrorCode
+    {
+        typealias Error = BatchError
+        
+        case batchError
+    }
+
+    var code: Code = .batchError
+    var underlyingErrors: [Error]
+    
+    var errorTitle: String?
+    var errorFailure: String?
+    
+    init(errors: [Error])
+    {
+        self.underlyingErrors = errors
+    }
+    
+    var errorFailureReason: String {
+        guard !self.underlyingErrors.isEmpty else { return NSLocalizedString("An unknown error occured.", comment: "") }
+        
+        let errorMessages = self.underlyingErrors.map { $0.localizedDescription }
+        
+        let message = errorMessages.joined(separator: "\n\n")
+        return message
+    }
+}
+*/
+@objc(ClearAppCacheOperation)
+class ClearAppCacheOperation: ResultOperation<Void>
+{
+    private let coordinator = NSFileCoordinator()
+    private let coordinatorQueue = OperationQueue()
+    
+    override init()
+    {
+        self.coordinatorQueue.name = "AltStore - ClearAppCacheOperation Queue"
+    }
+    
+    override func main()
+    {
+        super.main()
+        
+        var allErrors = [Error]()
+        
+        self.clearTemporaryDirectory { result in
+            switch result
+            {
+            //case .failure(let batchError as BatchError): allErrors.append(contentsOf: batchError.underlyingErrors)
+            case .failure(let error): allErrors.append(error)
+            case .success: break
+            }
+            
+            self.removeUninstalledAppBackupDirectories { result in
+                switch result
+                {
+                //case .failure(let batchError as BatchError): allErrors.append(contentsOf: batchError.underlyingErrors)
+                case .failure(let error): allErrors.append(error)
+                case .success: break
+                }
+                
+                if allErrors.isEmpty
+                {
+                    self.finish(.success(()))
+                }
+                else
+                {
+                    self.finish(.failure(OperationError.cacheClearError(errors: allErrors.map({ error in
+                        return error.localizedDescription
+                    }))))
+                }
+            }
+        }
+    }
+}
+
+private extension ClearAppCacheOperation
+{
+    func clearTemporaryDirectory(completion: @escaping (Result<Void, Error>) -> Void)
+    {
+        let intent = NSFileAccessIntent.writingIntent(with: FileManager.default.temporaryDirectory, options: [.forDeleting])
+        self.coordinator.coordinate(with: [intent], queue: self.coordinatorQueue) { (error) in
+            do
+            {
+                if let error
+                {
+                    throw error
+                }
+                
+                let fileURLs = try FileManager.default.contentsOfDirectory(at: intent.url,
+                                                                           includingPropertiesForKeys: [],
+                                                                           options: [.skipsSubdirectoryDescendants, .skipsHiddenFiles])
+                var errors = [Error]()
+                
+                for fileURL in fileURLs
+                {
+                    do
+                    {
+                        print("[ALTLog] Removing item from temporary directory:", fileURL.lastPathComponent)
+                        try FileManager.default.removeItem(at: fileURL)
+                    }
+                    catch
+                    {
+                        print("[ALTLog] Failed to remove \(fileURL.lastPathComponent) from temporary directory.", error)
+                        errors.append(error)
+                    }
+                }
+                
+                if !errors.isEmpty
+                {
+                    completion(.failure(OperationError.cacheClearError(errors: errors.map({ error in
+                        return error.localizedDescription
+                    }))))
+                }
+                else
+                {
+                    completion(.success(()))
+                }
+            }
+            catch
+            {
+                completion(.failure(error))
+            }
+        }
+    }
+    
+    func removeUninstalledAppBackupDirectories(completion: @escaping (Result<Void, Error>) -> Void)
+    {
+        guard let backupsDirectory = FileManager.default.appBackupsDirectory else { return completion(.failure(OperationError.missingAppGroup)) }
+        
+        DatabaseManager.shared.persistentContainer.performBackgroundTask { context in
+            let installedAppBundleIDs = Set(InstalledApp.all(in: context).map { $0.bundleIdentifier })
+            
+            let intent = NSFileAccessIntent.writingIntent(with: backupsDirectory, options: [.forDeleting])
+            self.coordinator.coordinate(with: [intent], queue: self.coordinatorQueue) { (error) in
+                do
+                {
+                    if let error
+                    {
+                        throw error
+                    }
+                    
+                    var isDirectory: ObjCBool = false
+                    guard FileManager.default.fileExists(atPath: intent.url.path, isDirectory: &isDirectory), isDirectory.boolValue else {
+                        completion(.success(()))
+                        return
+                    }
+                    
+                    let fileURLs = try FileManager.default.contentsOfDirectory(at: intent.url,
+                                                                               includingPropertiesForKeys: [.isDirectoryKey, .nameKey],
+                                                                               options: [.skipsSubdirectoryDescendants, .skipsHiddenFiles])
+                    var errors = [Error]()
+                    
+                    
+                    for backupDirectory in fileURLs
+                    {
+                        do
+                        {
+                            let resourceValues = try backupDirectory.resourceValues(forKeys: [.isDirectoryKey, .nameKey])
+                            guard let isDirectory = resourceValues.isDirectory, let bundleID = resourceValues.name else { continue }
+
+                            if isDirectory && !installedAppBundleIDs.contains(bundleID) && !AppManager.shared.isActivelyManagingApp(withBundleID: bundleID)
+                            {
+                                print("[ALTLog] Removing backup directory for uninstalled app:", bundleID)
+                                try FileManager.default.removeItem(at: backupDirectory)
+                            }
+                        }
+                        catch
+                        {
+                            print("[ALTLog] Failed to remove app backup directory:", error)
+                            errors.append(error)
+                        }
+                    }
+                    
+                    if !errors.isEmpty
+                    {
+                        completion(.failure(OperationError.cacheClearError(errors: errors.map({ error in
+                            return error.localizedDescription
+                        }))))
+                    }
+                    else
+                    {
+                        completion(.success(()))
+                    }
+                }
+                catch
+                {
+                    print("[ALTLog] Failed to remove app backup directory:", error)
+                    completion(.failure(error))
+                }
+            }
+        }
+    }
+}

AltStore/Operations/OperationError.swift

@@ -40,6 +40,8 @@ enum OperationError: LocalizedError
     case provisioningError(result: String, message: String?)
     case anisetteV3Error(message: String)
     
+    case cacheClearError(errors: [String])
+    
     var failureReason: String? {
         switch self {
         case .unknown: return NSLocalizedString("An unknown error occured.", comment: "")
@@ -60,6 +62,7 @@ enum OperationError: LocalizedError
         case .anisetteV1Error(let message): return String(format: NSLocalizedString("An error occurred when getting anisette data from a V1 server: %@. Try using another anisette server.", comment: ""), message)
         case .provisioningError(let result, let message): return String(format: NSLocalizedString("An error occurred when provisioning: %@%@. Please try again. If the issue persists, report it on GitHub Issues!", comment: ""), result, message != nil ? (" (" + message! + ")") : "")
         case .anisetteV3Error(let message): return String(format: NSLocalizedString("An error occurred when getting anisette data from a V3 server: %@. Please try again. If the issue persists, report it on GitHub Issues!", comment: ""), message)
+        case .cacheClearError(let errors): return String(format: NSLocalizedString("An error occurred while clearing cache: %@", comment: ""), errors.joined(separator: "\n"))
         }
     }
     

AltStore/Operations/ResignAppOperation.swift

@@ -11,6 +11,7 @@ import Roxas
 
 import AltStoreCore
 import AltSign
+import minimuxer
 
 @objc(ResignAppOperation)
 final class ResignAppOperation: ResultOperation<ALTApplication>
@@ -181,7 +182,7 @@ private extension ResignAppOperation
 
                 if app.isAltStoreApp
                 {
-                    guard let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String else { throw OperationError.unknownUDID }
+                    guard let udid = fetch_udid()?.toString() as? String else { throw OperationError.unknownUDID }
                     guard let pairingFileString = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.devicePairingString) as? String else { throw OperationError.unknownUDID }                    
                     additionalValues[Bundle.Info.devicePairingString] = pairingFileString
                     additionalValues[Bundle.Info.deviceID] = udid
@@ -202,7 +203,7 @@ private extension ResignAppOperation
                         // The embedded certificate + certificate identifier are already in app bundle, no need to update them.
                     }
                 }
-                else if infoDictionary.keys.contains(Bundle.Info.deviceID), let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String
+                else if infoDictionary.keys.contains(Bundle.Info.deviceID), let udid = fetch_udid()?.toString() as? String
                 {
                     // There is an ALTDeviceID entry, so assume the app is using AltKit and replace it with the device's UDID.
                     additionalValues[Bundle.Info.deviceID] = udid