neoarz/SideStore
1
0
Fork 0
mirror of https://github.com/SideStore/SideStore.git synced 2026-02-16 10:13:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

[cleanup]: Added TODOs in the comments

Browse Source
This commit is contained in:
Magesh K
2024-12-13 15:26:11 +05:30
parent 3ea24fdfea
commit d045c0ed4d
5 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
AltStore/Operations/FetchSourceOperation.swift
View File

@@ -159,8 +159,8 @@ final class FetchSourceOperation: ResultOperation<Source>
userInfo[NSDebugDescriptionErrorKey] = pathDescription userInfo[NSDebugDescriptionErrorKey] = pathDescription
} }
// @mahee96: Need to account for invalid/missing json fields error // TODO: @mahee96: Need to account for invalid/missing json fields error
// and show meaningful message to user instead of just showing decoder error // and show meaningful message to user instead of just showing decoder error
throw NSError(domain: nsError.domain, code: nsError.code, userInfo: userInfo) throw NSError(domain: nsError.domain, code: nsError.code, userInfo: userInfo)
} }

2
AltStore/Operations/UpdateKnownSourcesOperation.swift
View File

@@ -12,7 +12,7 @@ import AltStoreCore
private extension URL private extension URL
{ {
// @mahee96: update this to a non-branch specific (prod-ready) location like github.io repo similar to anisette servers URL list // TODO: @mahee96: update this to a non-branch specific (prod-ready) location like github.io repo similar to anisette servers URL list
#if STAGING #if STAGING
// static let sources = URL(string: "https://raw.githubusercontent.com/SideStore/SideStore/develop/trustedapps.json")! // static let sources = URL(string: "https://raw.githubusercontent.com/SideStore/SideStore/develop/trustedapps.json")!
static let sources = URL(string: "https://raw.githubusercontent.com/SideStore/SideStore/rebase-2.0-wip/trustedapps.json")! static let sources = URL(string: "https://raw.githubusercontent.com/SideStore/SideStore/rebase-2.0-wip/trustedapps.json")!

2
AltStore/Operations/VerifyAppOperation.swift
View File

@@ -126,7 +126,7 @@ private extension VerifyAppOperation
if let buildVersion if let buildVersion
{ {
// @mahee96: requires altsign-marketplace branch release or equivalent // TODO: @mahee96: requires altsign-marketplace branch release or equivalent
// guard buildVersion == app.buildVersion else { throw VerificationError.mismatchedBuildVersion(app.buildVersion, expectedVersion: buildVersion, app: app) } // guard buildVersion == app.buildVersion else { throw VerificationError.mismatchedBuildVersion(app.buildVersion, expectedVersion: buildVersion, app: app) }
} }
} }

1
AltStore/Sources/SourcesViewController.swift
View File

@@ -179,6 +179,7 @@ private extension SourcesViewController
func makeDataSource() -> RSTFetchedResultsCollectionViewPrefetchingDataSource<Source, UIImage> func makeDataSource() -> RSTFetchedResultsCollectionViewPrefetchingDataSource<Source, UIImage>
{ {
// TODO: @mahee96: Need implementation to keep SideStore-Official source always on top
let fetchRequest = Source.fetchRequest() as NSFetchRequest<Source> let fetchRequest = Source.fetchRequest() as NSFetchRequest<Source>
fetchRequest.returnsObjectsAsFaults = false fetchRequest.returnsObjectsAsFaults = false
fetchRequest.sortDescriptors = [NSSortDescriptor(keyPath: \Source.name, ascending: true), fetchRequest.sortDescriptors = [NSSortDescriptor(keyPath: \Source.name, ascending: true),

2
AltStoreCore/Model/InstalledApp.swift
View File

@@ -140,7 +140,7 @@ public extension InstalledApp
self.resignedBundleIdentifier = resignedApp.bundleIdentifier self.resignedBundleIdentifier = resignedApp.bundleIdentifier
self.version = resignedApp.version self.version = resignedApp.version
// @mahee96: requires altsign-marketplace branch release or equivalent // TODO: @mahee96: requires altsign-marketplace branch release or equivalent
// self.buildVersion = resignedApp.buildVersion // self.buildVersion = resignedApp.buildVersion
self.storeBuildVersion = storeBuildVersion self.storeBuildVersion = storeBuildVersion