Merge branch 'develop' into Sidekit-jit-implementation

AltStore/Operations/AuthenticationOperation.swift

@@ -12,8 +12,10 @@ import Network
 
 import AltStoreCore
 import AltSign
+import minimuxer
 
-enum AuthenticationError: LocalizedError
+typealias AuthenticationError = AuthenticationErrorCode.Error
+enum AuthenticationErrorCode: Int, ALTErrorEnum, CaseIterable
 {
     case noTeam
     case noCertificate
@@ -22,11 +24,11 @@ enum AuthenticationError: LocalizedError
     case missingPrivateKey
     case missingCertificate
     
-    var errorDescription: String? {
+    var errorFailureReason: String {
         switch self {
-        case .noTeam: return NSLocalizedString("Developer team could not be found.", comment: "")
+        case .noTeam: return NSLocalizedString("Your Apple ID has no developer teams?", comment: "")
+        case .noCertificate: return NSLocalizedString("The developer certificate could not be found.", comment: "")
         case .teamSelectorError: return NSLocalizedString("Error presenting team selector view.", comment: "")
-        case .noCertificate: return NSLocalizedString("Developer certificate could not be found.", comment: "")
         case .missingPrivateKey: return NSLocalizedString("The certificate's private key could not be found.", comment: "")
         case .missingCertificate: return NSLocalizedString("The certificate could not be found.", comment: "")
         }
@@ -212,8 +214,8 @@ final class AuthenticationOperation: ResultOperation<(ALTTeam, ALTCertificate, A
                 guard
                     let account = Account.first(satisfying: NSPredicate(format: "%K == %@", #keyPath(Account.identifier), altTeam.account.identifier), in: context),
                     let team = Team.first(satisfying: NSPredicate(format: "%K == %@", #keyPath(Team.identifier), altTeam.identifier), in: context)
-                else { throw AuthenticationError.noTeam }
-                
+                else { throw AuthenticationError(.noTeam) }
+
                 // Account
                 account.isActiveAccount = true
                 
@@ -239,12 +241,11 @@ final class AuthenticationOperation: ResultOperation<(ALTTeam, ALTCertificate, A
                 }
                 
                 let activeAppsMinimumVersion = OperatingSystemVersion(majorVersion: 13, minorVersion: 3, patchVersion: 1)
-                if team.type == .free, ProcessInfo.processInfo.isOperatingSystemAtLeast(activeAppsMinimumVersion)
-                {
+                if team.type == .free, !UserDefaults.standard.isAppLimitDisabled, ProcessInfo().sparseRestorePatched {
                     UserDefaults.standard.activeAppsLimit = ALTActiveAppsLimit
-                }
-                else
-                {
+                } else if UserDefaults.standard.isAppLimitDisabled, !ProcessInfo().sparseRestorePatched {
+                    UserDefaults.standard.activeAppsLimit = 10
+                } else {
                     UserDefaults.standard.activeAppsLimit = nil
                 }
                 
@@ -431,7 +432,7 @@ private extension AuthenticationOperation
                     }
                     else
                     {
-                        completionHandler(.failure(error ?? OperationError.unknown))
+                        completionHandler(.failure(error ?? OperationError.unknown()))
                     }
                 }
             }
@@ -448,7 +449,7 @@ private extension AuthenticationOperation
                  if let team = teams.first {
                      return completionHandler(.success(team))
                  } else {
-                     return completionHandler(.failure(AuthenticationError.noTeam))
+                     return completionHandler(.failure(AuthenticationError(.noTeam)))
                  }
              } else {
                  DispatchQueue.main.async {
@@ -459,7 +460,7 @@ private extension AuthenticationOperation
 
                      if !self.present(selectTeamViewController)
                      {
-                         return completionHandler(.failure(AuthenticationError.noTeam))
+                         return completionHandler(.failure(AuthenticationError(.noTeam)))
                      }
                  }
              }
@@ -488,20 +489,20 @@ private extension AuthenticationOperation
     {
         func requestCertificate()
         {
-            let machineName = "AltStore - " + UIDevice.current.name
+            let machineName: String = "SideStore - \(team.account.firstName)'s \(UIDevice.current.name)"
             ALTAppleAPI.shared.addCertificate(machineName: machineName, to: team, session: session) { (certificate, error) in
                 do
                 {
                     let certificate = try Result(certificate, error).get()
-                    guard let privateKey = certificate.privateKey else { throw AuthenticationError.missingPrivateKey }
-                    
+                    guard let privateKey = certificate.privateKey else { throw AuthenticationError(.missingPrivateKey) }
+
                     ALTAppleAPI.shared.fetchCertificates(for: team, session: session) { (certificates, error) in
                         do
                         {
                             let certificates = try Result(certificates, error).get()
                             
                             guard let certificate = certificates.first(where: { $0.serialNumber == certificate.serialNumber }) else {
-                                throw AuthenticationError.missingCertificate
+                                throw AuthenticationError(.missingCertificate)
                             }
                             
                             certificate.privateKey = privateKey
@@ -522,16 +523,50 @@ private extension AuthenticationOperation
         
         func replaceCertificate(from certificates: [ALTCertificate])
         {
-            guard let certificate = certificates.first(where: { $0.machineName?.starts(with: "AltStore") == true }) ?? certificates.first else { return completionHandler(.failure(AuthenticationError.noCertificate)) }
+            let ourCertificates = certificates.filter { a in
+                a.machineName?.starts(with: "SideStore") == true || a.machineName?.starts(with: "AltStore") == true
+            }
             
-            ALTAppleAPI.shared.revoke(certificate, for: team, session: session) { (success, error) in
-                if let error = error, !success
+            if ourCertificates.isEmpty {
+                return requestCertificate()
+            }
+            
+            // We don't have private keys for any of the certificates,
+            // so we need to revoke one and create a new one.
+            var certsText = ""
+            for certificate in ourCertificates {
+                if let name = certificate.machineName {
+                    certsText.append("\(name)\n")
+                }
+            }
+            
+            let alertController = UIAlertController(title: NSLocalizedString("Would you like to revoke your previous certificates?\n\(certsText)", comment: ""), message: nil, preferredStyle: .alert)
+            
+            let noAction = UIAlertAction(title: NSLocalizedString("No", comment: ""), style: .default) { (action) in
+                requestCertificate()
+            }
+            let yesAction = UIAlertAction(title: NSLocalizedString("Yes", comment: ""), style: .default) { (action) in
+                for certificate in ourCertificates {
+                    ALTAppleAPI.shared.revoke(certificate, for: team, session: session) { (success, error) in
+                        if let error = error, !success
+                        {
+                            completionHandler(.failure(error))
+                        }
+                    }
+                }
+                requestCertificate()
+            }
+            alertController.addAction(noAction)
+            alertController.addAction(yesAction)
+            
+            DispatchQueue.main.async {
+                if self.navigationController.presentingViewController != nil
                 {
-                    completionHandler(.failure(error))
+                    self.navigationController.present(alertController, animated: true, completion: nil)
                 }
                 else
                 {
-                    requestCertificate()
+                    self.presentingViewController?.present(alertController, animated: true, completion: nil)
                 }
             }
         }
@@ -579,8 +614,6 @@ private extension AuthenticationOperation
                 }
                 else
                 {
-                    // We don't have private keys for any of the certificates,
-                    // so we need to revoke one and create a new one.
                     replaceCertificate(from: certificates)
                 }
             }
@@ -593,7 +626,7 @@ private extension AuthenticationOperation
     
     func registerCurrentDevice(for team: ALTTeam, session: ALTAppleAPISession, completionHandler: @escaping (Result<ALTDevice, Error>) -> Void)
     {
-        guard let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String else {
+        guard let udid = fetch_udid()?.toString() else {
             return completionHandler(.failure(OperationError.unknownUDID))
         }
         

AltStore/Operations/BackgroundRefreshAppsOperation.swift

@@ -13,11 +13,12 @@ import AltStoreCore
 import EmotionalDamage
 import minimuxer
 
-enum RefreshError: LocalizedError
+typealias RefreshError = RefreshErrorCode.Error
+enum RefreshErrorCode: Int, ALTErrorEnum, CaseIterable
 {
     case noInstalledApps
     
-    var errorDescription: String? {
+    var errorFailureReason: String {
         switch self
         {
         case .noInstalledApps: return NSLocalizedString("No active apps require refreshing.", comment: "")
@@ -94,7 +95,7 @@ final class BackgroundRefreshAppsOperation: ResultOperation<[String: Result<Inst
         super.main()
         
         guard !self.installedApps.isEmpty else {
-            self.finish(.failure(RefreshError.noInstalledApps))
+            self.finish(.failure(RefreshError(.noInstalledApps)))
             return
         }
         start_em_proxy(bind_addr: Consts.Proxy.serverURL)
@@ -105,8 +106,12 @@ final class BackgroundRefreshAppsOperation: ResultOperation<[String: Result<Inst
         } catch {
             self.finish(.failure(error))
         }
-        start_auto_mounter(documentsDirectory)
-        
+        if #available(iOS 17, *) {
+            // TODO: iOS 17 and above have a new JIT implementation that is completely broken in SideStore :(
+        } else {
+            start_auto_mounter(documentsDirectory)
+        }
+
         self.managedObjectContext.perform {
             print("Apps to refresh:", self.installedApps.map(\.bundleIdentifier))
             
@@ -198,7 +203,7 @@ private extension BackgroundRefreshAppsOperation
             
             let content = UNMutableNotificationContent()
             
-            var shouldPresentAlert = false
+            var shouldPresentAlert = true
             
             do
             {
@@ -214,20 +219,18 @@ private extension BackgroundRefreshAppsOperation
                 content.title = NSLocalizedString("Refreshed Apps", comment: "")
                 content.body = NSLocalizedString("All apps have been refreshed.", comment: "")
             }
-            catch RefreshError.noInstalledApps
+            catch ~OperationError.Code.noWiFi, ~RefreshErrorCode.noInstalledApps
             {
                 shouldPresentAlert = false
             }
             catch
             {
                 print("Failed to refresh apps in background.", error)
-                
+
                 content.title = NSLocalizedString("Failed to Refresh Apps", comment: "")
                 content.body = error.localizedDescription
-                
-                shouldPresentAlert = false
             }
-            
+
             if shouldPresentAlert
             {
                 let trigger = UNTimeIntervalNotificationTrigger(timeInterval: delay + 1, repeats: false)

AltStore/Operations/BackupAppOperation.swift

@@ -29,6 +29,9 @@ class BackupAppOperation: ResultOperation<Void>
     private var appName: String?
     private var timeoutTimer: Timer?
     
+    private weak var applicationWillReturnObserver: NSObjectProtocol?
+    private weak var backupResponseObserver: NSObjectProtocol?
+    
     init(action: Action, context: InstallAppOperationContext)
     {
         self.action = action
@@ -43,25 +46,26 @@ class BackupAppOperation: ResultOperation<Void>
         
         do
         {
-            if let error = self.context.error
-            {
-                throw error
-            }
+            if let error = self.context.error { throw error }
             
-            guard let installedApp = self.context.installedApp, let context = installedApp.managedObjectContext else { throw OperationError.invalidParameters }
+            guard let installedApp = self.context.installedApp, let context = installedApp.managedObjectContext else {
+                throw OperationError.invalidParameters("BackupAppOperation.main: self.context.installedApp or installedApp.managedObjectContext is nil")
+            }
             context.perform {
                 do
                 {
                     let appName = installedApp.name
                     self.appName = appName
                     
-                    guard let altstoreApp = InstalledApp.fetchAltStore(in: context) else { throw OperationError.appNotFound }
+                    guard let altstoreApp = InstalledApp.fetchAltStore(in: context) else {
+                        throw OperationError.appNotFound(name: appName)
+                    }
                     let altstoreOpenURL = altstoreApp.openAppURL
-                    
+
                     var returnURLComponents = URLComponents(url: altstoreOpenURL, resolvingAgainstBaseURL: false)
                     returnURLComponents?.host = "appBackupResponse"
                     guard let returnURL = returnURLComponents?.url else { throw OperationError.openAppFailed(name: appName) }
-                    
+
                     var openURLComponents = URLComponents()
                     openURLComponents.scheme = installedApp.openAppURL.scheme
                     openURLComponents.host = self.action.rawValue
@@ -153,8 +157,11 @@ private extension BackupAppOperation
 {
     func registerObservers()
     {
-        var applicationWillReturnObserver: NSObjectProtocol!
-        applicationWillReturnObserver = NotificationCenter.default.addObserver(forName: UIApplication.willEnterForegroundNotification, object: nil, queue: .main) { [weak self] (notification) in
+        self.applicationWillReturnObserver = NotificationCenter.default.addObserver(forName: UIApplication.willEnterForegroundNotification, object: nil, queue: .main) { [weak self] (notification) in
+            defer {
+                self?.applicationWillReturnObserver.map { NotificationCenter.default.removeObserver($0) }
+            }
+
             guard let self = self, !self.isFinished else { return }
             
             self.timeoutTimer = Timer.scheduledTimer(withTimeInterval: 5, repeats: false) { [weak self] (timer) in
@@ -166,18 +173,17 @@ private extension BackupAppOperation
                     self.finish(.failure(OperationError.timedOut))
                 }
             }
-            
-            NotificationCenter.default.removeObserver(applicationWillReturnObserver!)
         }
         
-        var backupResponseObserver: NSObjectProtocol!
-        backupResponseObserver = NotificationCenter.default.addObserver(forName: AppDelegate.appBackupDidFinish, object: nil, queue: nil) { [weak self] (notification) in
+        self.backupResponseObserver = NotificationCenter.default.addObserver(forName: AppDelegate.appBackupDidFinish, object: nil, queue: nil) { [weak self] (notification) in
+            defer {
+                self?.backupResponseObserver.map { NotificationCenter.default.removeObserver($0) }
+            }
+            
             self?.timeoutTimer?.invalidate()
             
             let result = notification.userInfo?[AppDelegate.appBackupResultKey] as? Result<Void, Error> ?? .failure(OperationError.unknownResult)
             self?.finish(result)
-            
-            NotificationCenter.default.removeObserver(backupResponseObserver!)
         }
     }
 }

AltStore/Operations/ClearAppCacheOperation.swift

@@ -0,0 +1,208 @@
+//
+//  ClearAppCacheOperation.swift
+//  AltStore
+//
+//  Created by Riley Testut on 9/27/22.
+//  Copyright © 2022 Riley Testut. All rights reserved.
+//
+
+import Foundation
+import AltStoreCore
+/*
+struct BatchError: ALTLocalizedError
+{
+
+    enum Code: Int, ALTErrorCode
+    {
+        typealias Error = BatchError
+        
+        case batchError
+    }
+
+    var code: Code = .batchError
+    var underlyingErrors: [Error]
+    
+    var errorTitle: String?
+    var errorFailure: String?
+    
+    init(errors: [Error])
+    {
+        self.underlyingErrors = errors
+    }
+    
+    var errorFailureReason: String {
+        guard !self.underlyingErrors.isEmpty else { return NSLocalizedString("An unknown error occured.", comment: "") }
+        
+        let errorMessages = self.underlyingErrors.map { $0.localizedDescription }
+        
+        let message = errorMessages.joined(separator: "\n\n")
+        return message
+    }
+}
+*/
+@objc(ClearAppCacheOperation)
+class ClearAppCacheOperation: ResultOperation<Void>
+{
+    private let coordinator = NSFileCoordinator()
+    private let coordinatorQueue = OperationQueue()
+    
+    override init()
+    {
+        self.coordinatorQueue.name = "AltStore - ClearAppCacheOperation Queue"
+    }
+    
+    override func main()
+    {
+        super.main()
+        
+        var allErrors = [Error]()
+        
+        self.clearTemporaryDirectory { result in
+            switch result
+            {
+            //case .failure(let batchError as BatchError): allErrors.append(contentsOf: batchError.underlyingErrors)
+            case .failure(let error): allErrors.append(error)
+            case .success: break
+            }
+            
+            self.removeUninstalledAppBackupDirectories { result in
+                switch result
+                {
+                //case .failure(let batchError as BatchError): allErrors.append(contentsOf: batchError.underlyingErrors)
+                case .failure(let error): allErrors.append(error)
+                case .success: break
+                }
+                
+                if allErrors.isEmpty
+                {
+                    self.finish(.success(()))
+                }
+                else
+                {
+                    self.finish(.failure(OperationError.cacheClearError(errors: allErrors.map({ error in
+                        return error.localizedDescription
+                    }))))
+                }
+            }
+        }
+    }
+}
+
+private extension ClearAppCacheOperation
+{
+    func clearTemporaryDirectory(completion: @escaping (Result<Void, Error>) -> Void)
+    {
+        let intent = NSFileAccessIntent.writingIntent(with: FileManager.default.temporaryDirectory, options: [.forDeleting])
+        self.coordinator.coordinate(with: [intent], queue: self.coordinatorQueue) { (error) in
+            do
+            {
+                if let error
+                {
+                    throw error
+                }
+                
+                let fileURLs = try FileManager.default.contentsOfDirectory(at: intent.url,
+                                                                           includingPropertiesForKeys: [],
+                                                                           options: [.skipsSubdirectoryDescendants, .skipsHiddenFiles])
+                var errors = [Error]()
+                
+                for fileURL in fileURLs
+                {
+                    do
+                    {
+                        print("[ALTLog] Removing item from temporary directory:", fileURL.lastPathComponent)
+                        try FileManager.default.removeItem(at: fileURL)
+                    }
+                    catch
+                    {
+                        print("[ALTLog] Failed to remove \(fileURL.lastPathComponent) from temporary directory.", error)
+                        errors.append(error)
+                    }
+                }
+                
+                if !errors.isEmpty
+                {
+                    completion(.failure(OperationError.cacheClearError(errors: errors.map({ error in
+                        return error.localizedDescription
+                    }))))
+                }
+                else
+                {
+                    completion(.success(()))
+                }
+            }
+            catch
+            {
+                completion(.failure(error))
+            }
+        }
+    }
+    
+    func removeUninstalledAppBackupDirectories(completion: @escaping (Result<Void, Error>) -> Void)
+    {
+        guard let backupsDirectory = FileManager.default.appBackupsDirectory else { return completion(.failure(OperationError.missingAppGroup)) }
+        
+        DatabaseManager.shared.persistentContainer.performBackgroundTask { context in
+            let installedAppBundleIDs = Set(InstalledApp.all(in: context).map { $0.bundleIdentifier })
+            
+            let intent = NSFileAccessIntent.writingIntent(with: backupsDirectory, options: [.forDeleting])
+            self.coordinator.coordinate(with: [intent], queue: self.coordinatorQueue) { (error) in
+                do
+                {
+                    if let error
+                    {
+                        throw error
+                    }
+                    
+                    var isDirectory: ObjCBool = false
+                    guard FileManager.default.fileExists(atPath: intent.url.path, isDirectory: &isDirectory), isDirectory.boolValue else {
+                        completion(.success(()))
+                        return
+                    }
+                    
+                    let fileURLs = try FileManager.default.contentsOfDirectory(at: intent.url,
+                                                                               includingPropertiesForKeys: [.isDirectoryKey, .nameKey],
+                                                                               options: [.skipsSubdirectoryDescendants, .skipsHiddenFiles])
+                    var errors = [Error]()
+                    
+                    
+                    for backupDirectory in fileURLs
+                    {
+                        do
+                        {
+                            let resourceValues = try backupDirectory.resourceValues(forKeys: [.isDirectoryKey, .nameKey])
+                            guard let isDirectory = resourceValues.isDirectory, let bundleID = resourceValues.name else { continue }
+
+                            if isDirectory && !installedAppBundleIDs.contains(bundleID) && !AppManager.shared.isActivelyManagingApp(withBundleID: bundleID)
+                            {
+                                print("[ALTLog] Removing backup directory for uninstalled app:", bundleID)
+                                try FileManager.default.removeItem(at: backupDirectory)
+                            }
+                        }
+                        catch
+                        {
+                            print("[ALTLog] Failed to remove app backup directory:", error)
+                            errors.append(error)
+                        }
+                    }
+                    
+                    if !errors.isEmpty
+                    {
+                        completion(.failure(OperationError.cacheClearError(errors: errors.map({ error in
+                            return error.localizedDescription
+                        }))))
+                    }
+                    else
+                    {
+                        completion(.success(()))
+                    }
+                }
+                catch
+                {
+                    print("[ALTLog] Failed to remove app backup directory:", error)
+                    completion(.failure(error))
+                }
+            }
+        }
+    }
+}

AltStore/Operations/DeactivateAppOperation.swift

@@ -31,11 +31,7 @@ final class DeactivateAppOperation: ResultOperation<InstalledApp>
     {
         super.main()
         
-        if let error = self.context.error
-        {
-            self.finish(.failure(error))
-            return
-        }
+        if let error = self.context.error { return self.finish(.failure(error)) }
         
         DatabaseManager.shared.persistentContainer.performBackgroundTask { (context) in
             let installedApp = context.object(with: self.app.objectID) as! InstalledApp
@@ -45,14 +41,14 @@ final class DeactivateAppOperation: ResultOperation<InstalledApp>
             for profile in allIdentifiers {
                 do {
                     try remove_provisioning_profile(profile)
+                    self.progress.completedUnitCount += 1
+                    installedApp.isActive = false
+                    self.finish(.success(installedApp))
+                    break
                 } catch {
-                    return self.finish(.failure(error))
+                    self.finish(.failure(error))
                 }
             }
-            
-            self.progress.completedUnitCount += 1
-            installedApp.isActive = false
-            self.finish(.success(installedApp))
         }
     }
 }

AltStore/Operations/DownloadAppOperation.swift

@@ -12,66 +12,110 @@ import Roxas
 import AltStoreCore
 import AltSign
 
-private extension DownloadAppOperation
-{
-    struct DependencyError: ALTLocalizedError
-    {
-        let dependency: Dependency
-        let error: Error
-        
-        var failure: String? {
-            return String(format: NSLocalizedString("Could not download “%@”.", comment: ""), self.dependency.preferredFilename)
-        }
-        
-        var underlyingError: Error? {
-            return self.error
-        }
-    }
-}
-
 @objc(DownloadAppOperation)
 final class DownloadAppOperation: ResultOperation<ALTApplication>
 {
     let app: AppProtocol
     let context: AppOperationContext
-    
+
+    private let appName: String
     private let bundleIdentifier: String
     private var sourceURL: URL?
     private let destinationURL: URL
-    
+
     private let session = URLSession(configuration: .default)
     private let temporaryDirectory = FileManager.default.uniqueTemporaryURL()
-    
+
     init(app: AppProtocol, destinationURL: URL, context: AppOperationContext)
     {
         self.app = app
         self.context = context
-        
+
+        self.appName = app.name
         self.bundleIdentifier = app.bundleIdentifier
         self.sourceURL = app.url
         self.destinationURL = destinationURL
-        
+
         super.init()
-        
+
         // App = 3, Dependencies = 1
         self.progress.totalUnitCount = 4
     }
-    
+
     override func main()
     {
         super.main()
-        
+
         if let error = self.context.error
         {
             self.finish(.failure(error))
             return
         }
-        
+
         print("Downloading App:", self.bundleIdentifier)
-        
-        guard let sourceURL = self.sourceURL else { return self.finish(.failure(OperationError.appNotFound)) }
-        
-        self.downloadApp(from: sourceURL) { result in
+
+        self.localizedFailure = String(format: NSLocalizedString("%@ could not be downloaded.", comment: ""), self.appName)
+
+        guard let storeApp = self.app as? StoreApp else { return self.download(self.app) }
+        storeApp.managedObjectContext?.perform {
+            do {
+                let latestVersion = try self.verify(storeApp)
+                self.download(latestVersion)
+            } catch let error as VerificationError where error.code == .iOSVersionNotSupported {
+                guard let presentingViewController = self.context.presentingViewController,
+                      let latestSupportedVersion = storeApp.latestSupportedVersion,
+                      case let version = latestSupportedVersion.version,
+                      version != storeApp.installedApp?.version else {
+                    return self.finish(.failure(error))
+                }
+                let title = NSLocalizedString("Unsupported iOS Version", comment: "")
+                let message = error.localizedDescription + "\n\n" + NSLocalizedString("Would you like to download the last version compatible with this device instead?", comment: "")
+
+                DispatchQueue.main.async {
+                    let alertController = UIAlertController(title: title, message: message, preferredStyle: .alert)
+                    alertController.addAction(UIAlertAction(title: UIAlertAction.cancel.title, style: UIAlertAction.cancel.style) { _ in
+                        self.finish(.failure(OperationError.cancelled))
+                    })
+                    alertController.addAction(UIAlertAction(title: String(format: NSLocalizedString("Download %@ %@", comment: ""), self.appName, version), style: .default) { _ in
+                        self.download(latestSupportedVersion)
+                    })
+                    presentingViewController.present(alertController, animated: true)
+                }
+            } catch {
+                self.finish(.failure(error))
+            }
+        }
+    }
+
+    override func finish(_ result: Result<ALTApplication, any Error>) {
+        do {
+            try FileManager.default.removeItem(at: self.temporaryDirectory)
+        } catch {
+            print("Failed to remove DownloadAppOperation temporary directory: \(self.temporaryDirectory).", error)
+        }
+        super.finish(result)
+    }
+}
+
+private extension DownloadAppOperation {
+    func verify(_ storeApp: StoreApp) throws -> AppVersion {
+        guard let version = storeApp.latestAvailableVersion else {
+            let failureReason = String(format: NSLocalizedString("The latest version of %@ could not be determined.", comment: ""), self.appName)
+            throw OperationError.unknown(failureReason: failureReason)
+        }
+        if let minOSVersion = version.minOSVersion, !ProcessInfo.processInfo.isOperatingSystemAtLeast(minOSVersion) {
+            throw VerificationError.iOSVersionNotSupported(app: storeApp, requiredOSVersion: minOSVersion)
+        } else if let maxOSVersion = version.maxOSVersion, ProcessInfo.processInfo.operatingSystemVersion > maxOSVersion {
+            throw VerificationError.iOSVersionNotSupported(app: storeApp, requiredOSVersion: maxOSVersion)
+        }
+
+        return version
+    }
+
+    func download(@Managed _ app: AppProtocol) {
+        guard let sourceURL = self.sourceURL else { return self.finish(.failure(OperationError.appNotFound(name: self.appName))) }
+
+        self.downloadIPA(from: sourceURL) { result in
             do
             {
                 let application = try result.get()
@@ -112,24 +156,7 @@ final class DownloadAppOperation: ResultOperation<ALTApplication>
         }
     }
     
-    override func finish(_ result: Result<ALTApplication, Error>)
-    {
-        do
-        {
-            try FileManager.default.removeItem(at: self.temporaryDirectory)
-        }
-        catch
-        {
-            print("Failed to remove DownloadAppOperation temporary directory: \(self.temporaryDirectory).", error)
-        }
-        
-        super.finish(result)
-    }
-}
-
-private extension DownloadAppOperation
-{
-    func downloadApp(from sourceURL: URL, completionHandler: @escaping (Result<ALTApplication, Error>) -> Void)
+    func downloadIPA(from sourceURL: URL, completionHandler: @escaping (Result<ALTApplication, Error>) -> Void)
     {
         func finishOperation(_ result: Result<URL, Error>)
         {
@@ -138,8 +165,8 @@ private extension DownloadAppOperation
                 let fileURL = try result.get()
                 
                 var isDirectory: ObjCBool = false
-                guard FileManager.default.fileExists(atPath: fileURL.path, isDirectory: &isDirectory) else { throw OperationError.appNotFound }
-                
+                guard FileManager.default.fileExists(atPath: fileURL.path, isDirectory: &isDirectory) else { throw OperationError.appNotFound(name: self.appName) }
+
                 try FileManager.default.createDirectory(at: self.temporaryDirectory, withIntermediateDirectories: true, attributes: nil)
                 
                 let appBundleURL: URL
@@ -178,6 +205,9 @@ private extension DownloadAppOperation
             let downloadTask = self.session.downloadTask(with: sourceURL) { (fileURL, response, error) in
                 do
                 {
+                    if let response = response as? HTTPURLResponse {
+                        guard response.statusCode != 404 else { throw CocoaError(.fileNoSuchFile, userInfo: [NSURLErrorKey: sourceURL]) }
+                    }
                     let (fileURL, _) = try Result((fileURL, response), error).get()
                     finishOperation(.success(fileURL))
                     
@@ -252,7 +282,7 @@ private extension DownloadAppOperation
             let altstorePlist = try PropertyListDecoder().decode(AltStorePlist.self, from: data)
                         
             var dependencyURLs = Set<URL>()
-            var dependencyError: DependencyError?
+            var dependencyError: Error?
             
             let dispatchGroup = DispatchGroup()
             let progress = Progress(totalUnitCount: Int64(altstorePlist.dependencies.count), parent: self.progress, pendingUnitCount: 1)
@@ -285,7 +315,7 @@ private extension DownloadAppOperation
         }
         catch let error as DecodingError
         {
-            let nsError = (error as NSError).withLocalizedFailure(String(format: NSLocalizedString("Could not download dependencies for %@.", comment: ""), application.name))
+            let nsError = (error as NSError).withLocalizedFailure(String(format: NSLocalizedString("Could not determine dependencies for %@.", comment: ""), application.name))
             completionHandler(.failure(nsError))
         }
         catch
@@ -294,7 +324,7 @@ private extension DownloadAppOperation
         }
     }
     
-    func download(_ dependency: Dependency, for application: ALTApplication, progress: Progress, completionHandler: @escaping (Result<URL, DependencyError>) -> Void)
+    func download(_ dependency: Dependency, for application: ALTApplication, progress: Progress, completionHandler: @escaping (Result<URL, Error>) -> Void)
     {
         let downloadTask = self.session.downloadTask(with: dependency.downloadURL) { (fileURL, response, error) in
             do
@@ -315,9 +345,10 @@ private extension DownloadAppOperation
                 
                 completionHandler(.success(destinationURL))
             }
-            catch
+            catch let error as NSError
             {
-                completionHandler(.failure(DependencyError(dependency: dependency, error: error)))
+                let localizedFailure = String(format: NSLocalizedString("The dependency '%@' could not be downloaded.", comment: ""), dependency.preferredFilename)
+                completionHandler(.failure(error.withLocalizedFailure(localizedFailure)))
             }
         }
         progress.addChild(downloadTask.progress, withPendingUnitCount: 1)

AltStore/Operations/EnableJITOperation.swift

@@ -9,9 +9,17 @@
 import UIKit
 import Combine
 import minimuxer
+import UniformTypeIdentifiers
 
 import AltStoreCore
 
+enum SideJITServerErrorType: Error {
+     case invalidURL
+     case errorConnecting
+     case deviceNotFound
+     case other(String)
+ }
+
 @available(iOS 14, *)
 protocol EnableJITContext
 {
@@ -42,16 +50,108 @@ final class EnableJITOperation<Context: EnableJITContext>: ResultOperation<Void>
             return
         }
         
-        guard let installedApp = self.context.installedApp else { return self.finish(.failure(OperationError.invalidParameters)) }
-        
-        installedApp.managedObjectContext?.perform {
-            do {
-                try debug_app(installedApp.resignedBundleIdentifier)
-            } catch {
-                return self.finish(.failure(error))
-            }
+        guard let installedApp = self.context.installedApp else {
+            return self.finish(.failure(OperationError.invalidParameters("EnableJITOperation.main: self.context.installedApp is nil")))
+        }
+        if #available(iOS 17, *) {
+            let sideJITenabled = UserDefaults.standard.sidejitenable
+            let SideJITIP = UserDefaults.standard.textInputSideJITServerurl ?? ""
             
-            self.finish(.success(()))
+            if sideJITenabled {
+                installedApp.managedObjectContext?.perform {
+                    EnableJITSideJITServer(serverurl: SideJITIP, installedapp: installedApp) { result in
+                        switch result {
+                        case .failure(let error):
+                            switch error {
+                            case .invalidURL, .errorConnecting:
+                                self.finish(.failure(OperationError.unableToConnectSideJIT))
+                            case .deviceNotFound:
+                                self.finish(.failure(OperationError.unableToRespondSideJITDevice))
+                            case .other(let message):
+                                if let startRange = message.range(of: "<p>"),
+                                   let endRange = message.range(of: "</p>", range: startRange.upperBound..<message.endIndex) {
+                                    let pContent = message[startRange.upperBound..<endRange.lowerBound]
+                                    self.finish(.failure(OperationError.SideJITIssue(error: String(pContent))))
+                                    print(message + " + " + String(pContent))
+                                } else {
+                                    print(message)
+                                    self.finish(.failure(OperationError.SideJITIssue(error: message)))
+                                }
+                            }
+                        case .success():
+                            self.finish(.success(()))
+                            print("Thank you for using this, it was made by Stossy11 and tested by trolley or sniper1239408")
+                        }
+                    }
+                    return
+                }
+            }
+      } else {
+            installedApp.managedObjectContext?.perform {
+                var retries = 3
+                while (retries > 0){
+                    do {
+                        try debug_app(installedApp.resignedBundleIdentifier)
+                        self.finish(.success(()))
+                        retries = 0
+                    } catch {
+                        retries -= 1
+                        if (retries <= 0){
+                            self.finish(.failure(error))
+                        }
+                    }
+                }
+            }
         }
     }
 }
+
+@available(iOS 17, *)
+func EnableJITSideJITServer(serverurl: String, installedapp: InstalledApp, completion: @escaping (Result<Void, SideJITServerErrorType>) -> Void) {
+    guard let udid = fetch_udid()?.toString() else {
+        completion(.failure(.other("Unable to get UDID")))
+        return
+    }
+    
+    var SJSURL = serverurl
+    
+     if (UserDefaults.standard.textInputSideJITServerurl ?? "").isEmpty {
+      SJSURL = "http://sidejitserver._http._tcp.local:8080"
+     }
+    
+    if !SJSURL.hasPrefix("http") {
+        completion(.failure(.invalidURL))
+        return
+    }
+    
+    let fullurl = SJSURL + "/\(udid)/" + installedapp.resignedBundleIdentifier
+    
+    let url = URL(string: fullurl)!
+    
+    let task = URLSession.shared.dataTask(with: url) {(data, response, error) in
+        if let error = error {
+            completion(.failure(.errorConnecting))
+            return
+        }
+        
+        guard let data = data, let datastring = String(data: data, encoding: .utf8) else { return }
+        
+        if datastring == "Enabled JIT for '\(installedapp.name)'!" {
+            let content = UNMutableNotificationContent()
+            content.title = "JIT Successfully Enabled"
+            content.subtitle = "JIT Enabled For \(installedapp.name)"
+            content.sound = UNNotificationSound.default
+
+            let trigger = UNTimeIntervalNotificationTrigger(timeInterval: 0.1, repeats: false)
+            let request = UNNotificationRequest(identifier: "EnabledJIT", content: content, trigger: nil)
+
+            UNUserNotificationCenter.current().add(request)
+            completion(.success(()))
+        } else {
+            let errorType: SideJITServerErrorType = datastring == "Could not find device!" ? .deviceNotFound : .other(datastring)
+            completion(.failure(errorType))
+        }
+    }
+    
+    task.resume()
+}

AltStore/Operations/FetchAnisetteDataOperation.swift

@@ -7,15 +7,28 @@
 //
 
 import Foundation
+import CommonCrypto
+import Starscream
 
 import AltStoreCore
 import AltSign
 import Roxas
 
 @objc(FetchAnisetteDataOperation)
-final class FetchAnisetteDataOperation: ResultOperation<ALTAnisetteData>
+final class FetchAnisetteDataOperation: ResultOperation<ALTAnisetteData>, WebSocketDelegate
 {
     let context: OperationContext
+    var socket: WebSocket!
+    
+    var url: URL?
+    var startProvisioningURL: URL?
+    var endProvisioningURL: URL?
+    
+    var clientInfo: String?
+    var userAgent: String?
+    
+    var mdLu: String?
+    var deviceId: String?
     
     init(context: OperationContext)
     {
@@ -32,32 +45,518 @@ final class FetchAnisetteDataOperation: ResultOperation<ALTAnisetteData>
             return
         }
         
-        let url = AnisetteManager.currentURL
-        DLOG("Anisette URL: %@", url.absoluteString)
+        // TODO: Pass in proper view context to show the Toast messages
+        let viewContext = context.presentingViewController
         
-        let task = URLSession.shared.dataTask(with: url) { data, response, error in
-            guard let data = data, error == nil else { return }
-            
-            do {
-                // make sure this JSON is in the format we expect
-                // convert data to json
-                if let json = try JSONSerialization.jsonObject(with: data, options: []) as? [String: String] {
-                    // try to read out a dictionary
-                    //for some reason serial number isn't needed but it doesn't work unless it has a value
-                    let formattedJSON: [String: String] = ["machineID": json["X-Apple-I-MD-M"]!, "oneTimePassword": json["X-Apple-I-MD"]!, "localUserID": json["X-Apple-I-MD-LU"]!, "routingInfo": json["X-Apple-I-MD-RINFO"]!, "deviceUniqueIdentifier": json["X-Mme-Device-Id"]!, "deviceDescription": json["X-MMe-Client-Info"]!, "date": json["X-Apple-I-Client-Time"]!, "locale": json["X-Apple-Locale"]!, "timeZone": json["X-Apple-I-TimeZone"]!, "deviceSerialNumber": "1"]
-                    
-                    if let anisette = ALTAnisetteData(json: formattedJSON) {
-                        DLOG("Anisette used: %@", formattedJSON)
-                        self.finish(.success(anisette))
-                    }
+        getAnisetteServerUrl(viewContext){ url, error in
+            guard let urlString = url else {
+                self.finish(.failure(error!))
+                return
+            }
+
+            // set as preferred
+            UserDefaults.standard.menuAnisetteURL = urlString
+            let url = URL(string: urlString)
+            self.url = url
+            print("Anisette URL: \(self.url!.absoluteString)")
+
+            if let identifier = Keychain.shared.identifier,
+               let adiPb = Keychain.shared.adiPb {
+                self.fetchAnisetteV3(identifier, adiPb)
+            } else {
+                self.provision()
+            }
+        }
+    }
+    
+
+    func getAnisetteServerUrl(_ viewContext: UIViewController?, completion: @escaping (String?, Error?) -> Void) {
+        var serverUrls = UserDefaults.standard.menuAnisetteServersList
+        let currentServer = UserDefaults.standard.menuAnisetteURL
+
+        // Prioritize the current server by moving it to the top of the list
+        if let currentServerIndex = serverUrls.firstIndex(of: currentServer) {
+            serverUrls.remove(at: currentServerIndex)
+            serverUrls.insert(currentServer, at: 0)
+        }
+        
+        tryNextServer(from: serverUrls, viewContext, currentIndex: 0, completion: completion)
+    }
+    
+    private func showToast(viewContext: UIViewController?, message: String){
+        if let viewContext = viewContext{
+            let error = OperationError.anisetteV1Error(message: message)
+            let toastView = ToastView(error: error)
+//            toastView.textLabel.textColor = .altPrimary
+//            toastView.detailTextLabel.textColor = .altPrimary
+            DispatchQueue.main.async {
+                toastView.show(in: viewContext)
+            }
+        }
+    }
+
+    private func tryNextServer(from serverUrls: [String], _ viewContext: UIViewController?,currentIndex: Int, completion: @escaping (String?, Error?) -> Void) {
+        // Check if all URLs have been exhausted
+        guard currentIndex < serverUrls.count else {
+            let error = NSError(domain: "AnisetteError", code: 0, userInfo: [NSLocalizedDescriptionKey: "No valid server found."])
+            completion(nil, error)
+            return
+        }
+
+        let currentServerUrlString = serverUrls[currentIndex]
+        guard let url = URL(string: currentServerUrlString) else {
+            // Invalid URL, skip to next
+            let errmsg = "Skipping invalid URL: \(currentServerUrlString)"
+            print(errmsg)
+            showToast(viewContext: viewContext, message: errmsg)
+            tryNextServer(from: serverUrls, viewContext, currentIndex: currentIndex + 1, completion: completion)
+            return
+        }
+
+        // Attempt to ping the current URL
+        pingServer(url) { success, error in
+            if success {
+                // If the server is reachable, return the URL
+                let okmsg = "Found working server: \(url.absoluteString)"
+                print(okmsg)
+                if(currentIndex > 0){
+                    // notify user if available server is different the user-specified one
+                    self.showToast(viewContext: viewContext, message: okmsg)
                 }
-            } catch let error as NSError {
-                print("Failed to load: \(error.localizedDescription)")
-                self.finish(.failure(error))
+                completion(url.absoluteString, nil)
+            } else {
+                // If not, try the next URL
+                let errmsg = "Failed to reach server: \(url.absoluteString), trying next server."
+                print(errmsg)
+                self.showToast(viewContext: viewContext, message: errmsg)
+                self.tryNextServer(from: serverUrls, viewContext, currentIndex: currentIndex + 1, completion: completion)
+            }
+        }
+    }
+
+    func pingServer(_ url: URL, completion: @escaping (Bool, Error?) -> Void) {
+        var request = URLRequest(url: url)
+        request.timeoutInterval = 10 // Timeout after 10 seconds
+        
+        let task = URLSession.shared.dataTask(with: request) { (data, response, error) in
+            if let error = error {
+                completion(false, error)
+                return
             }
             
+            let httpResponse = response as? HTTPURLResponse
+            let statusCode = httpResponse?.statusCode
+            
+            guard let statusCode = statusCode,
+                  (200...299).contains(statusCode) else {
+                let serverError = OperationError.anisetteV3Error(message: "Server unreachable or invalid response: \(String(describing: statusCode ?? nil))")
+                completion(false, serverError)
+                return
+            }
+            
+            completion(true, nil)
         }
         
         task.resume()
     }
+    
+    
+    // MARK: - COMMON
+    
+    func extractAnisetteData(_ data: Data, _ response: HTTPURLResponse?, v3: Bool) throws {
+        // make sure this JSON is in the format we expect
+        // convert data to json
+        if let json = try JSONSerialization.jsonObject(with: data, options: []) as? [String: String] {
+            if v3 {
+                if json["result"] == "GetHeadersError" {
+                    let message = json["message"]
+                    print("Error getting V3 headers: \(message ?? "no message")")
+                    if let message = message,
+                       message.contains("-45061") {
+                        print("Error message contains -45061 (not provisioned), resetting adi.pb and retrying")
+                        Keychain.shared.adiPb = nil
+                        return provision()
+                    } else { throw OperationError.anisetteV3Error(message: message ?? "Unknown error") }
+                }
+            }
+            
+            // try to read out a dictionary
+            // for some reason serial number isn't needed but it doesn't work unless it has a value
+            var formattedJSON: [String: String] = ["deviceSerialNumber": "0"]
+            if let machineID = json["X-Apple-I-MD-M"] { formattedJSON["machineID"] = machineID }
+            if let oneTimePassword = json["X-Apple-I-MD"] { formattedJSON["oneTimePassword"] = oneTimePassword }
+            if let routingInfo = json["X-Apple-I-MD-RINFO"] { formattedJSON["routingInfo"] = routingInfo }
+            
+            if v3 {
+                formattedJSON["deviceDescription"] = self.clientInfo!
+                formattedJSON["localUserID"] = self.mdLu!
+                formattedJSON["deviceUniqueIdentifier"] = self.deviceId!
+                
+                // Generate date stuff on client
+                let formatter = DateFormatter()
+                formatter.locale = Locale(identifier: "en_US_POSIX")
+                formatter.calendar = Calendar(identifier: .gregorian)
+                formatter.timeZone = TimeZone.current
+                formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss'Z'"
+                let dateString = formatter.string(from: Date())
+                formattedJSON["date"] = dateString
+                formattedJSON["locale"] = Locale.current.identifier
+                formattedJSON["timeZone"] = TimeZone.current.abbreviation()
+            } else {
+                if let deviceDescription = json["X-MMe-Client-Info"] { formattedJSON["deviceDescription"] = deviceDescription }
+                if let localUserID = json["X-Apple-I-MD-LU"] { formattedJSON["localUserID"] = localUserID }
+                if let deviceUniqueIdentifier = json["X-Mme-Device-Id"] { formattedJSON["deviceUniqueIdentifier"] = deviceUniqueIdentifier }
+                
+                if let date = json["X-Apple-I-Client-Time"] { formattedJSON["date"] = date }
+                if let locale = json["X-Apple-Locale"] { formattedJSON["locale"] = locale }
+                if let timeZone = json["X-Apple-I-TimeZone"] { formattedJSON["timeZone"] = timeZone }
+            }
+            
+            if let response = response,
+               let version = response.value(forHTTPHeaderField: "Implementation-Version") {
+                print("Implementation-Version: \(version)")
+            } else { print("No Implementation-Version header") }
+            
+            print("Anisette used: \(formattedJSON)")
+            print("Original JSON: \(json)")
+            if let anisette = ALTAnisetteData(json: formattedJSON) {
+                print("Anisette is valid!")
+                self.finish(.success(anisette))
+            } else {
+                print("Anisette is invalid!!!!")
+                if v3 {
+                    throw OperationError.anisetteV3Error(message: "Invalid anisette (the returned data may not have all the required fields)")
+                } else {
+                    throw OperationError.anisetteV1Error(message: "Invalid anisette (the returned data may not have all the required fields)")
+                }
+            }
+        } else {
+            if v3 {
+                throw OperationError.anisetteV3Error(message: "Invalid anisette (the returned data may not be in JSON)")
+            } else {
+                throw OperationError.anisetteV1Error(message: "Invalid anisette (the returned data may not be in JSON)")
+            }
+        }
+    }
+    
+    // MARK: - V1
+    
+    func handleV1() {
+        print("Server is V1")
+        
+        if UserDefaults.shared.trustedServerURL == AnisetteManager.currentURLString {
+            print("Server has already been trusted, fetching anisette")
+            return self.fetchAnisetteV1()
+        }
+        
+        print("Alerting user about outdated server")
+        let alert = UIAlertController(title: "WARNING: Outdated anisette server", message: "We've detected you are using an older anisette server. Using this server has a higher likelihood of locking your account and causing other issues. Are you sure you want to continue?", preferredStyle: UIAlertController.Style.alert)
+        alert.addAction(UIAlertAction(title: "Continue", style: UIAlertAction.Style.destructive, handler: { action in
+            print("Fetching anisette via V1")
+            UserDefaults.shared.trustedServerURL = AnisetteManager.currentURLString
+            self.fetchAnisetteV1()
+        }))
+        alert.addAction(UIAlertAction(title: "Cancel", style: UIAlertAction.Style.cancel, handler: { action in
+            print("Cancelled anisette operation")
+            self.finish(.failure(OperationError.cancelled))
+        }))
+
+        let keyWindow = UIApplication.shared.windows.filter { $0.isKeyWindow }.first
+
+        DispatchQueue.main.async {
+            if let presentingController = keyWindow?.rootViewController?.presentedViewController {
+                presentingController.present(alert, animated: true)
+            } else {
+                keyWindow?.rootViewController?.present(alert, animated: true)
+            }
+        }
+    }
+    
+    func fetchAnisetteV1() {
+        print("Fetching anisette V1")
+        URLSession.shared.dataTask(with: self.url!) { data, response, error in
+            do {
+                guard let data = data, error == nil else { throw OperationError.anisetteV1Error(message: "Unable to fetch data\(error != nil ? " (\(error!.localizedDescription))" : "")") }
+                
+                try self.extractAnisetteData(data, response as? HTTPURLResponse, v3: false)
+            } catch let error as NSError {
+                print("Failed to load: \(error.localizedDescription)")
+                self.finish(.failure(error))
+            }
+        }.resume()
+    }
+    
+    // MARK: - V3: PROVISIONING
+    
+    func provision() {
+        fetchClientInfo {
+            print("Getting provisioning URLs")
+            var request = self.buildAppleRequest(url: URL(string: "https://gsa.apple.com/grandslam/GsService2/lookup")!)
+            request.httpMethod = "GET"
+            URLSession.shared.dataTask(with: request) { data, response, error in
+                if let data = data,
+                   let plist = try? PropertyListSerialization.propertyList(from: data, format: nil) as? Dictionary<String, Dictionary<String, Any>>,
+                   let startProvisioningString = plist["urls"]?["midStartProvisioning"] as? String,
+                   let startProvisioningURL = URL(string: startProvisioningString),
+                   let endProvisioningString = plist["urls"]?["midFinishProvisioning"] as? String,
+                   let endProvisioningURL = URL(string: endProvisioningString) {
+                    self.startProvisioningURL = startProvisioningURL
+                    self.endProvisioningURL = endProvisioningURL
+                    print("startProvisioningURL: \(self.startProvisioningURL!.absoluteString)")
+                    print("endProvisioningURL: \(self.endProvisioningURL!.absoluteString)")
+                    print("Starting a provisioning session")
+                    self.startProvisioningSession()
+                } else {
+                    print("Apple didn't give valid URLs! Got response: \(String(data: data ?? Data("nothing".utf8), encoding: .utf8) ?? "not utf8")")
+                    self.finish(.failure(OperationError.provisioningError(result: "Apple didn't give valid URLs. Please try again later", message: nil)))
+                }
+            }.resume()
+        }
+    }
+    
+    func startProvisioningSession() {
+        let provisioningSessionURL = self.url!.appendingPathComponent("v3").appendingPathComponent("provisioning_session")
+        var wsRequest = URLRequest(url: provisioningSessionURL)
+        wsRequest.timeoutInterval = 5
+        self.socket = WebSocket(request: wsRequest)
+        self.socket.delegate = self
+        self.socket.connect()
+    }
+    
+    func didReceive(event: WebSocketEvent, client: WebSocketClient) {
+        switch event {
+        case .text(let string):
+            do {
+                if let json = try JSONSerialization.jsonObject(with: string.data(using: .utf8)!, options: []) as? [String: Any] {
+                    guard let result = json["result"] as? String else {
+                        print("The server didn't give us a result")
+                        client.disconnect(closeCode: 0)
+                        self.finish(.failure(OperationError.provisioningError(result: "The server didn't give us a result", message: nil)))
+                        return
+                    }
+                    print("Received result: \(result)")
+                    switch result {
+                    case "GiveIdentifier":
+                        print("Giving identifier")
+                        client.json(["identifier": Keychain.shared.identifier!])
+                        
+                    case "GiveStartProvisioningData":
+                        print("Getting start provisioning data")
+                        let body = [
+                            "Header": [String: Any](),
+                            "Request": [String: Any](),
+                        ]
+                        var request = self.buildAppleRequest(url: self.startProvisioningURL!)
+                        request.httpMethod = "POST"
+                        request.httpBody = try! PropertyListSerialization.data(fromPropertyList: body, format: .xml, options: 0)
+                        URLSession.shared.dataTask(with: request) { data, response, error in
+                            if let data = data,
+                               let plist = try? PropertyListSerialization.propertyList(from: data, format: nil) as? Dictionary<String, Dictionary<String, Any>>,
+                               let spim = plist["Response"]?["spim"] as? String {
+                                print("Giving start provisioning data")
+                                client.json(["spim": spim])
+                            } else {
+                                print("Apple didn't give valid start provisioning data! Got response: \(String(data: data ?? Data("nothing".utf8), encoding: .utf8) ?? "not utf8")")
+                                client.disconnect(closeCode: 0)
+                                self.finish(.failure(OperationError.provisioningError(result: "Apple didn't give valid start provisioning data. Please try again later", message: nil)))
+                            }
+                        }.resume()
+                        
+                    case "GiveEndProvisioningData":
+                        print("Getting end provisioning data")
+                        guard let cpim = json["cpim"] as? String else {
+                            print("The server didn't give us a cpim")
+                            client.disconnect(closeCode: 0)
+                            self.finish(.failure(OperationError.provisioningError(result: "The server didn't give us a cpim", message: nil)))
+                            return
+                        }
+                        let body = [
+                            "Header": [String: Any](),
+                            "Request": [
+                                "cpim": cpim,
+                            ],
+                        ]
+                        var request = self.buildAppleRequest(url: self.endProvisioningURL!)
+                        request.httpMethod = "POST"
+                        request.httpBody = try! PropertyListSerialization.data(fromPropertyList: body, format: .xml, options: 0)
+                        URLSession.shared.dataTask(with: request) { data, response, error in
+                            if let data = data,
+                               let plist = try? PropertyListSerialization.propertyList(from: data, format: nil) as? Dictionary<String, Dictionary<String, Any>>,
+                               let ptm = plist["Response"]?["ptm"] as? String,
+                               let tk = plist["Response"]?["tk"] as? String {
+                                print("Giving end provisioning data")
+                                client.json(["ptm": ptm, "tk": tk])
+                            } else {
+                                print("Apple didn't give valid end provisioning data! Got response: \(String(data: data ?? Data("nothing".utf8), encoding: .utf8) ?? "not utf8")")
+                                client.disconnect(closeCode: 0)
+                                self.finish(.failure(OperationError.provisioningError(result: "Apple didn't give valid end provisioning data. Please try again later", message: nil)))
+                            }
+                        }.resume()
+                        
+                    case "ProvisioningSuccess":
+                        print("Provisioning succeeded!")
+                        client.disconnect(closeCode: 0)
+                        guard let adiPb = json["adi_pb"] as? String else {
+                            print("The server didn't give us an adi.pb file")
+                            self.finish(.failure(OperationError.provisioningError(result: "The server didn't give us an adi.pb file", message: nil)))
+                            return
+                        }
+                        Keychain.shared.adiPb = adiPb
+                        self.fetchAnisetteV3(Keychain.shared.identifier!, Keychain.shared.adiPb!)
+                        
+                    default:
+                        if result.contains("Error") || result.contains("Invalid") || result == "ClosingPerRequest" || result == "Timeout" || result == "TextOnly" {
+                            print("Failing because of \(result)")
+                            self.finish(.failure(OperationError.provisioningError(result: result, message: json["message"] as? String)))
+                        }
+                    }
+                }
+            } catch let error as NSError {
+                print("Failed to handle text: \(error.localizedDescription)")
+                self.finish(.failure(OperationError.provisioningError(result: error.localizedDescription, message: nil)))
+            }
+            
+        case .connected:
+            print("Connected")
+            
+        case .disconnected(let string, let code):
+            print("Disconnected: \(code); \(string)")
+            
+        case .error(let error):
+            print("Got error: \(String(describing: error))")
+            
+        default:
+            print("Unknown event: \(event)")
+        }
+    }
+    
+    func buildAppleRequest(url: URL) -> URLRequest {
+        var request = URLRequest(url: url)
+        request.setValue(self.clientInfo!, forHTTPHeaderField: "X-Mme-Client-Info")
+        request.setValue(self.userAgent!, forHTTPHeaderField: "User-Agent")
+        request.setValue("text/x-xml-plist", forHTTPHeaderField: "Content-Type")
+        request.setValue("*/*", forHTTPHeaderField: "Accept")
+
+        request.setValue(self.mdLu!, forHTTPHeaderField: "X-Apple-I-MD-LU")
+        request.setValue(self.deviceId!, forHTTPHeaderField: "X-Mme-Device-Id")
+
+        let formatter = DateFormatter()
+        formatter.locale = Locale(identifier: "en_US_POSIX")
+        formatter.calendar = Calendar(identifier: .gregorian)
+        formatter.timeZone = TimeZone(identifier: "UTC")
+        formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss'Z'"
+        let dateString = formatter.string(from: Date())
+        request.setValue(dateString, forHTTPHeaderField: "X-Apple-I-Client-Time")
+        request.setValue(Locale.current.identifier, forHTTPHeaderField: "X-Apple-Locale")
+        request.setValue(TimeZone.current.abbreviation(), forHTTPHeaderField: "X-Apple-I-TimeZone")
+        return request
+    }
+    
+    // MARK: - V3: FETCHING
+    
+    func fetchClientInfo(_ callback: @escaping () -> Void) {
+        if  self.clientInfo != nil &&
+                self.userAgent != nil &&
+                self.mdLu != nil &&
+                self.deviceId != nil &&
+                Keychain.shared.identifier != nil {
+            print("Skipping client_info fetch since all the properties we need aren't nil")
+            return callback()
+        }
+        print("Trying to get client_info")
+        let clientInfoURL = self.url!.appendingPathComponent("v3").appendingPathComponent("client_info")
+        URLSession.shared.dataTask(with: clientInfoURL) { data, response, error in
+            do {
+                guard let data = data, error == nil else {
+                    return self.finish(.failure(OperationError.anisetteV3Error(message: "Couldn't fetch client info. The server may be down\(error != nil ? " (\(error!.localizedDescription))" : "")")))
+                }
+                
+                if let json = try JSONSerialization.jsonObject(with: data, options: []) as? [String: String] {
+                    if let clientInfo = json["client_info"] {
+                        print("Server is V3")
+                        
+                        self.clientInfo = clientInfo
+                        self.userAgent = json["user_agent"]!
+                        print("Client-Info: \(self.clientInfo!)")
+                        print("User-Agent: \(self.userAgent!)")
+                        
+                        if Keychain.shared.identifier == nil {
+                            print("Generating identifier")
+                            var bytes = [Int8](repeating: 0, count: 16)
+                            let status = SecRandomCopyBytes(kSecRandomDefault, bytes.count, &bytes)
+                            
+                            if status != errSecSuccess {
+                                print("ERROR GENERATING IDENTIFIER!!! \(status)")
+                                return self.finish(.failure(OperationError.provisioningError(result: "Couldn't generate identifier", message: nil)))
+                            }
+                            
+                            Keychain.shared.identifier = Data(bytes: &bytes, count: bytes.count).base64EncodedString()
+                        }
+                        
+                        let decoded = Data(base64Encoded: Keychain.shared.identifier!)!
+                        self.mdLu = decoded.sha256().hexEncodedString()
+                        print("X-Apple-I-MD-LU: \(self.mdLu!)")
+                        let uuid: UUID = decoded.object()
+                        self.deviceId = uuid.uuidString.uppercased()
+                        print("X-Mme-Device-Id: \(self.deviceId!)")
+                        
+                        callback()
+                    } else { self.handleV1() }
+                } else { self.finish(.failure(OperationError.anisetteV3Error(message: "Couldn't fetch client info. The returned data may not be in JSON"))) }
+            } catch let error as NSError {
+                print("Failed to load: \(error.localizedDescription)")
+                self.handleV1()
+            }
+        }.resume()
+    }
+    
+    func fetchAnisetteV3(_ identifier: String, _ adiPb: String) {
+        fetchClientInfo {
+            print("Fetching anisette V3")
+            let url = UserDefaults.standard.menuAnisetteURL
+            var request = URLRequest(url: self.url!.appendingPathComponent("v3").appendingPathComponent("get_headers"))
+            request.httpMethod = "POST"
+            request.httpBody = try! JSONSerialization.data(withJSONObject: [
+                "identifier": identifier,
+                "adi_pb": adiPb
+            ], options: [])
+            request.setValue("application/json", forHTTPHeaderField: "Content-Type")
+            URLSession.shared.dataTask(with: request) { data, response, error in
+                do {
+                    guard let data = data, error == nil else { throw OperationError.anisetteV3Error(message: "Couldn't fetch anisette") }
+                    
+                    try self.extractAnisetteData(data, response as? HTTPURLResponse, v3: true)
+                } catch let error as NSError {
+                    print("Failed to load: \(error.localizedDescription)")
+                    self.finish(.failure(error))
+                }
+            }.resume()
+        }
+    }
+}
+
+extension WebSocketClient {
+    func json(_ dictionary: [String: String]) {
+        let data = try! JSONSerialization.data(withJSONObject: dictionary, options: [])
+        self.write(string: String(data: data, encoding: .utf8)!)
+    }
+}
+
+extension Data {
+    // https://stackoverflow.com/a/25391020
+    func sha256() -> Data {
+        var hash = [UInt8](repeating: 0,  count: Int(CC_SHA256_DIGEST_LENGTH))
+        self.withUnsafeBytes {
+            _ = CC_SHA256($0.baseAddress, CC_LONG(self.count), &hash)
+        }
+        return Data(hash)
+    }
+    
+    // https://stackoverflow.com/a/40089462
+    func hexEncodedString() -> String {
+        return self.map { String(format: "%02hhX", $0) }.joined()
+    }
+    
+    // https://stackoverflow.com/a/59127761
+    func object<T>() -> T { self.withUnsafeBytes { $0.load(as: T.self) } }
 }

AltStore/Operations/FetchAppIDsOperation.swift

@@ -39,7 +39,9 @@ final class FetchAppIDsOperation: ResultOperation<([AppID], NSManagedObjectConte
         guard
             let team = self.context.team,
             let session = self.context.session
-        else { return self.finish(.failure(OperationError.invalidParameters)) }
+        else {
+            return self.finish(.failure(OperationError.invalidParameters("FetchAppIDsOperation.main: self.context.team or self.context.session is nil")))
+        }
                 
         ALTAppleAPI.shared.fetchAppIDs(for: team, session: session) { (appIDs, error) in
             self.managedObjectContext.perform {

AltStore/Operations/FetchProvisioningProfilesOperation.swift

@@ -43,10 +43,11 @@ final class FetchProvisioningProfilesOperation: ResultOperation<[String: ALTProv
         guard
             let team = self.context.team,
             let session = self.context.session
-        else { return self.finish(.failure(OperationError.invalidParameters)) }
-        
-        guard let app = self.context.app else { return self.finish(.failure(OperationError.appNotFound)) }
+        else {
+            return self.finish(.failure(OperationError.invalidParameters("FetchProvisioningProfilesOperation.main: self.context.team or self.context.session is nil"))) }
         
+        guard let app = self.context.app else { return self.finish(.failure(OperationError.appNotFound(name: nil))) }
+
         self.progress.totalUnitCount = Int64(1 + app.appExtensions.count)
         
         self.prepareProvisioningProfile(for: app, parentApp: nil, team: team, session: session) { (result) in
@@ -260,7 +261,7 @@ extension FetchProvisioningProfilesOperation
                         {
                             if let expirationDate = sortedExpirationDates.first
                             {
-                                throw OperationError.maximumAppIDLimitReached(application: application, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, nextExpirationDate: expirationDate)
+                                throw OperationError.maximumAppIDLimitReached(appName: application.name, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, expirationDate: expirationDate)
                             }
                             else
                             {
@@ -290,7 +291,7 @@ extension FetchProvisioningProfilesOperation
                             {
                                 if let expirationDate = sortedExpirationDates.first
                                 {
-                                    throw OperationError.maximumAppIDLimitReached(application: application, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, nextExpirationDate: expirationDate)
+                                    throw OperationError.maximumAppIDLimitReached(appName: application.name, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, expirationDate: expirationDate)
                                 }
                                 else
                                 {

AltStore/Operations/InstallAppOperation.swift

@@ -41,12 +41,16 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
         
         guard
             let certificate = self.context.certificate,
-            let resignedApp = self.context.resignedApp
-        else { return self.finish(.failure(OperationError.invalidParameters)) }
+            let resignedApp = self.context.resignedApp,
+            let provisioningProfiles = self.context.provisioningProfiles
+        else {
+            return self.finish(.failure(OperationError.invalidParameters("InstallAppOperation.main: self.context.certificate or self.context.resignedApp or self.context.provisioningProfiles is nil")))
+        }
         
         let backgroundContext = DatabaseManager.shared.persistentContainer.newBackgroundContext()
         backgroundContext.perform {
             
+            
             /* App */
             let installedApp: InstalledApp
             
@@ -110,14 +114,29 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
             }
             
             installedApp.appExtensions = installedExtensions
+
+            // Remove stale "PlugIns" (Extensions) from currently installed App
+            if let installedAppExns = ALTApplication(fileURL: installedApp.fileURL)?.appExtensions {
+                let currentAppExns = Set(installedApp.appExtensions).map{ $0.bundleIdentifier }
+                let staleAppExns = installedAppExns.filter{ !currentAppExns.contains($0.bundleIdentifier) }
+                
+                for staleAppExn in staleAppExns {
+                    do {
+                        try FileManager.default.removeItem(at: staleAppExn.fileURL)
+                        print("InstallAppOperation.appExtensions: removed stale app-extension: \(staleAppExn.fileURL)")
+                    } catch {
+                        print("InstallAppOperation.appExtensions processing error Error: \(error)")
+                    }
+                }
+            }
+            
             
             self.context.beginInstallationHandler?(installedApp)
             
             // Temporary directory and resigned .ipa no longer needed, so delete them now to ensure AltStore doesn't quit before we get the chance to.
             self.cleanUp()
             
-            var activeProfiles: Set<String>?
-            if let sideloadedAppsLimit = UserDefaults.standard.activeAppsLimit
+            if let sideloadedAppsLimit = UserDefaults.standard.activeAppsLimit, provisioningProfiles.contains(where: { $1.isFreeProvisioningProfile == true })
             {
                 // When installing these new profiles, AltServer will remove all non-active profiles to ensure we remain under limit.
                 
@@ -142,15 +161,14 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
                         installedApp.isActive = false
                     }
                 }
-
-                activeProfiles = Set(activeApps.flatMap { (installedApp) -> [String] in
-                    let appExtensionProfiles = installedApp.appExtensions.map { $0.resignedBundleIdentifier }
-                    return [installedApp.resignedBundleIdentifier] + appExtensionProfiles
-                })
+            }
+            else
+            {
+                installedApp.isActive = true
             }
             
             var installing = true
-            if installedApp.storeApp?.bundleIdentifier == Bundle.Info.appbundleIdentifier {
+            if installedApp.storeApp?.bundleIdentifier.range(of: Bundle.Info.appbundleIdentifier) != nil {
                 // Reinstalling ourself will hang until we leave the app, so we need to exit it without force closing
                 DispatchQueue.main.asyncAfter(deadline: .now() + 3) {
                     if UIApplication.shared.applicationState != .active {
@@ -162,30 +180,26 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
                         return
                     }
                     print("We are still installing after 3 seconds")
-                    
                     UNUserNotificationCenter.current().getNotificationSettings { settings in
                         switch (settings.authorizationStatus) {
                         case .authorized, .ephemeral, .provisional:
                             print("Notifications are enabled")
-                            
+
                             let content = UNMutableNotificationContent()
                             content.title = "Refreshing..."
-                            content.body = "To finish refreshing, SideStore must be moved to the background, which it does by opening Safari. Please reopen SideStore after it is done refreshing!"
+                            content.body = "SideStore will automatically move to the homescreen to finish refreshing!"
                             let notification = UNNotificationRequest(identifier: Bundle.Info.appbundleIdentifier + ".FinishRefreshNotification", content: content, trigger: UNTimeIntervalNotificationTrigger(timeInterval: 2, repeats: false))
                             UNUserNotificationCenter.current().add(notification)
-                            
-                            DispatchQueue.main.async { UIApplication.shared.open(URL(string: "x-web-search://")!) }
-                            
                             break
                         default:
                             print("Notifications are not enabled")
-                            
-                            let alert = UIAlertController(title: "Finish Refresh", message: "To finish refreshing, SideStore must be moved to the background. To do this, you can either go to the Home Screen or open Safari by pressing Continue. Please reopen SideStore after doing this.", preferredStyle: .alert)
+
+                            let alert = UIAlertController(title: "Finish Refresh", message: "Please reopen SideStore after the process is finished.To finish refreshing, SideStore must be moved to the background. To do this, you can either go to the Home Screen manually or by hitting Continue. Please reopen SideStore after doing this.", preferredStyle: .alert)
                             alert.addAction(UIAlertAction(title: NSLocalizedString("Continue", comment: ""), style: .default, handler: { _ in
-                                print("Opening Safari")
-                                DispatchQueue.main.async { UIApplication.shared.open(URL(string: "x-web-search://")!) }
+                                print("Going home")
+                                UIApplication.shared.perform(#selector(NSXPCConnection.suspend))
                             }))
-                            
+
                             DispatchQueue.main.async {
                                 let keyWindow = UIApplication.shared.windows.filter { $0.isKeyWindow }.first
                                 if var topController = keyWindow?.rootViewController {
@@ -194,27 +208,24 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
                                     }
                                     topController.present(alert, animated: true)
                                 } else {
-                                    print("No key window? Let's just open Safari")
-                                    UIApplication.shared.open(URL(string: "x-web-search://")!)
+                                    print("No key window? Let's just go home")
                                 }
                             }
-                            
-                            break
                         }
                     }
+                    UIApplication.shared.perform(#selector(NSXPCConnection.suspend))
                 }
             }
             
             do {
                 try install_ipa(installedApp.bundleIdentifier)
                 installing = false
-            } catch {
+                installedApp.refreshedDate = Date()
+                self.finish(.success(installedApp))
+            } catch let error {
                 installing = false
-                return self.finish(.failure(error))
+                self.finish(.failure(error))
             }
-            
-            installedApp.refreshedDate = Date()
-            self.finish(.success(installedApp))
         }
     }
     
@@ -229,8 +240,10 @@ final class InstallAppOperation: ResultOperation<InstalledApp>
             
             do
             {
-                try FileManager.default.removeItem(at: fileURL)
-                print("Removed refreshed IPA")
+                if(FileManager.default.fileExists(atPath: fileURL.path)){
+                    try FileManager.default.removeItem(at: fileURL)
+                    print("Removed refreshed IPA")
+                }
             }
             catch
             {

AltStore/Operations/Operation.swift

@@ -12,7 +12,10 @@ import Roxas
 class ResultOperation<ResultType>: Operation
 {
     var resultHandler: ((Result<ResultType, Error>) -> Void)?
-    
+
+    // Should only be set by subclasses
+    var localizedFailure: String?
+
     @available(*, unavailable)
     override func finish()
     {
@@ -22,16 +25,20 @@ class ResultOperation<ResultType>: Operation
     func finish(_ result: Result<ResultType, Error>)
     {
         guard !self.isFinished else { return }
-        
+
+        var result = result
+
         if self.isCancelled
         {
-            self.resultHandler?(.failure(OperationError.cancelled))
+            result = .failure(OperationError.cancelled)
         }
-        else
-        {
-            self.resultHandler?(result)
+        else if case .failure(let nsError as NSError) = result, let localizedFailure, nsError.localizedFailure == nil {
+            // Error doesn't have its own localizedFailure, so we give it the Operation's (if it exists)
+            let error = nsError.withLocalizedFailure(localizedFailure)
+            result = .failure(error)
         }
-        
+        self.resultHandler?(result)
+
         super.finish()
     }
 }

AltStore/Operations/OperationError.swift

@@ -8,57 +8,202 @@
 
 import Foundation
 import AltSign
+import AltStoreCore
 import minimuxer
 
-enum OperationError: LocalizedError
+extension OperationError
 {
-    static let domain = OperationError.unknown._domain
+    enum Code: Int, ALTErrorCode, CaseIterable {
+        typealias Error = OperationError
+
+        // General
+        case unknown = 1000
+        case unknownResult
+        case cancelled
+        case timedOut
+        case unableToConnectSideJIT
+        case unableToRespondSideJITDevice
+        case wrongSideJITIP
+        case SideJITIssue // (error: String)
+        case refreshsidejit
+        case notAuthenticated
+        case appNotFound
+        case unknownUDID
+        case invalidApp
+        case invalidParameters
+        case maximumAppIDLimitReached//((application: ALTApplication, requiredAppIDs: Int, availableAppIDs: Int, nextExpirationDate: Date)
+        case noSources
+        case openAppFailed//(name: String)
+        case missingAppGroup
+        case refreshAppFailed
+
+        // Connection
+        case noWiFi = 1200
+        case tooNewError
+        case anisetteV1Error//(message: String)
+        case provisioningError//(result: String, message: String?)
+        case anisetteV3Error//(message: String)
+
+        case cacheClearError//(errors: [String])
+    }
+
+    static let unknownResult: OperationError = .init(code: .unknownResult)
+    static let cancelled: OperationError = .init(code: .cancelled)
+    static let timedOut: OperationError = .init(code: .timedOut)
+    static let unableToConnectSideJIT: OperationError = .init(code: .unableToConnectSideJIT)
+    static let unableToRespondSideJITDevice: OperationError = .init(code: .unableToRespondSideJITDevice)
+    static let wrongSideJITIP: OperationError = .init(code: .wrongSideJITIP)
+    static let notAuthenticated: OperationError = .init(code: .notAuthenticated)
+    static let unknownUDID: OperationError = .init(code: .unknownUDID)
+    static let invalidApp: OperationError = .init(code: .invalidApp)
+    static let noSources: OperationError = .init(code: .noSources)
+    static let missingAppGroup: OperationError = .init(code: .missingAppGroup)
+
+    static let noWiFi: OperationError = .init(code: .noWiFi)
+    static let tooNewError: OperationError = .init(code: .tooNewError)
+    static let provisioningError: OperationError = .init(code: .provisioningError)
+    static let anisetteV1Error: OperationError = .init(code: .anisetteV1Error)
+    static let anisetteV3Error: OperationError = .init(code: .anisetteV3Error)
+
+    static let cacheClearError: OperationError = .init(code: .cacheClearError)
+
+    static func unknown(failureReason: String? = nil, file: String = #fileID, line: UInt = #line) -> OperationError {
+        OperationError(code: .unknown, failureReason: failureReason, sourceFile: file, sourceLine: line)
+    }
+
+    static func appNotFound(name: String?) -> OperationError {
+        OperationError(code: .appNotFound, appName: name)
+    }
+
+    static func openAppFailed(name: String?) -> OperationError {
+        OperationError(code: .openAppFailed, appName: name)
+    }
+    static let domain = OperationError(code: .unknown)._domain
     
-    case unknown
-    case unknownResult
-    case cancelled
-    case timedOut
+    static func SideJITIssue(error: String?) -> OperationError {
+        var o = OperationError(code: .SideJITIssue)
+        o.errorFailure = error
+        return o
+    }
     
-    case notAuthenticated
-    case appNotFound
-    
-    case unknownUDID
-    
-    case invalidApp
-    case invalidParameters
-    
-    case maximumAppIDLimitReached(application: ALTApplication, requiredAppIDs: Int, availableAppIDs: Int, nextExpirationDate: Date)
-    
-    case noSources
-    
-    case openAppFailed(name: String)
-    case missingAppGroup
-    
-    var failureReason: String? {
-        switch self {
-        case .unknown: return NSLocalizedString("An unknown error occured.", comment: "")
+    static func maximumAppIDLimitReached(appName: String, requiredAppIDs: Int, availableAppIDs: Int, expirationDate: Date) -> OperationError {
+        OperationError(code: .maximumAppIDLimitReached, appName: appName, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, expirationDate: expirationDate)
+    }
+
+    static func provisioningError(result: String, message: String?) -> OperationError {
+        var o = OperationError(code: .provisioningError, failureReason: result)
+        o.errorTitle = message
+        return o
+    }
+
+    static func cacheClearError(errors: [String]) -> OperationError {
+        OperationError(code: .cacheClearError, failureReason: errors.joined(separator: "\n"))
+    }
+
+    static func anisetteV1Error(message: String) -> OperationError {
+        OperationError(code: .anisetteV1Error, failureReason: message)
+    }
+
+    static func anisetteV3Error(message: String) -> OperationError {
+        OperationError(code: .anisetteV3Error, failureReason: message)
+    }
+
+    static func refreshAppFailed(message: String) -> OperationError {
+        OperationError(code: .refreshAppFailed, failureReason: message)
+    }
+
+    static func invalidParameters(_ message: String? = nil) -> OperationError {
+        OperationError(code: .invalidParameters, failureReason: message)
+    }
+}
+
+
+struct OperationError: ALTLocalizedError {
+
+    let code: Code
+
+    var errorTitle: String?
+    var errorFailure: String?
+
+    var appName: String?
+
+    var requiredAppIDs: Int?
+    var availableAppIDs: Int?
+    var expirationDate: Date?
+
+    var sourceFile: String?
+    var sourceLine: UInt?
+
+    private var _failureReason: String?
+
+    private init(code: Code, failureReason: String? = nil,
+                 appName: String? = nil, requiredAppIDs: Int? = nil, availableAppIDs: Int? = nil,
+                 expirationDate: Date? = nil, sourceFile: String? = nil, sourceLine: UInt? = nil){
+        self.code = code
+        self._failureReason = failureReason
+
+        self.appName = appName
+        self.requiredAppIDs = requiredAppIDs
+        self.availableAppIDs = availableAppIDs
+        self.expirationDate = expirationDate
+        self.sourceFile = sourceFile
+        self.sourceLine = sourceLine
+    }
+
+    var errorFailureReason: String {
+        switch self.code {
+        case .unknown:
+            var failureReason = self._failureReason ?? NSLocalizedString("An unknown error occurred.", comment: "")
+            guard let sourceFile, let sourceLine else { return failureReason }
+            failureReason += " (\(sourceFile) line \(sourceLine)"
+            return failureReason
         case .unknownResult: return NSLocalizedString("The operation returned an unknown result.", comment: "")
         case .cancelled: return NSLocalizedString("The operation was cancelled.", comment: "")
         case .timedOut: return NSLocalizedString("The operation timed out.", comment: "")
         case .notAuthenticated: return NSLocalizedString("You are not signed in.", comment: "")
-        case .appNotFound: return NSLocalizedString("App not found.", comment: "")
-        case .unknownUDID: return NSLocalizedString("Unknown device UDID.", comment: "")
-        case .invalidApp: return NSLocalizedString("The app is invalid.", comment: "")
-        case .invalidParameters: return NSLocalizedString("Invalid parameters.", comment: "")
+        case .unknownUDID: return NSLocalizedString("SideStore could not determine this device's UDID.", comment: "")
+        case .invalidApp: return NSLocalizedString("The app is in an invalid format.", comment: "")
+        case .maximumAppIDLimitReached: return NSLocalizedString("Cannot register more than 10 App IDs within a 7 day period.", comment: "")
         case .noSources: return NSLocalizedString("There are no SideStore sources.", comment: "")
-        case .openAppFailed(let name): return String(format: NSLocalizedString("SideStore was denied permission to launch %@.", comment: ""), name)
-        case .missingAppGroup: return NSLocalizedString("SideStore's shared app group could not be found.", comment: "")
-        case .maximumAppIDLimitReached: return NSLocalizedString("Cannot register more than 10 App IDs.", comment: "")
+        case .missingAppGroup: return NSLocalizedString("SideStore's shared app group could not be accessed.", comment: "")
+        case .appNotFound:
+            let appName = self.appName ?? NSLocalizedString("The app", comment: "")
+            return String(format: NSLocalizedString("%@ could not be found.", comment: ""), appName)
+        case .openAppFailed:
+            let appName = self.appName ?? NSLocalizedString("The app", comment: "")
+            return String(format: NSLocalizedString("SideStore was denied permission to launch %@.", comment: ""), appName)
+        case .noWiFi: return NSLocalizedString("You do not appear to be connected to WiFi and/or the WireGuard VPN!\nSideStore will never be able to install or refresh applications without WiFi and the WireGuard VPN.", comment: "")
+        case .tooNewError: return NSLocalizedString("iOS 17 has changed how JIT is enabled therefore SideStore cannot enable it without SideJITServer at this time, sorry for any inconvenience.\nWe will let everyone know once we have a solution!", comment: "")
+        case .unableToConnectSideJIT: return NSLocalizedString("Unable to connect to SideJITServer Please check that you are on the Same Wi-Fi and your Firewall has been set correctly", comment: "")
+        case .unableToRespondSideJITDevice: return NSLocalizedString("SideJITServer is unable to connect to your iDevice Please make sure you have paired your Device by doing 'SideJITServer -y' or try Refreshing SideJITServer from Settings", comment: "")
+        case .wrongSideJITIP: return NSLocalizedString("Incorrect SideJITServer IP Please make sure that you are on the Samw Wifi as SideJITServer", comment: "")
+        case .refreshsidejit: return NSLocalizedString("Unable to find App Please try Refreshing SideJITServer from Settings", comment: "")
+        case .anisetteV1Error: return NSLocalizedString("An error occurred when getting anisette data from a V1 server: %@. Try using another anisette server.", comment: "")
+        case .provisioningError: return NSLocalizedString("An error occurred when provisioning: %@ %@. Please try again. If the issue persists, report it on GitHub Issues!", comment: "")
+        case .anisetteV3Error: return NSLocalizedString("An error occurred when getting anisette data from a V3 server: %@. Please try again. If the issue persists, report it on GitHub Issues!", comment: "")
+        case .cacheClearError: return NSLocalizedString("An error occurred while clearing cache: %@", comment: "")
+        case .SideJITIssue: return NSLocalizedString("An error occurred while using SideJIT: %@", comment: "")
+            
+        case .refreshAppFailed:
+            let message = self._failureReason ?? ""
+            return String(format: NSLocalizedString("Unable to refresh App\n%@", comment: ""), message)
+
+        case .invalidParameters:
+            let message = self._failureReason.map { ": \n\($0)" } ?? "."
+            return String(format: NSLocalizedString("Invalid parameters%@", comment: ""), message)
         }
+        
     }
     
     var recoverySuggestion: String? {
-        switch self
+        switch self.code
         {
-        case .maximumAppIDLimitReached(let application, let requiredAppIDs, let availableAppIDs, let date):
+        case .noWiFi: return NSLocalizedString("Make sure the VPN is toggled on and you are connected to any WiFi network!", comment: "")
+        case .maximumAppIDLimitReached:
             let baseMessage = NSLocalizedString("Delete sideloaded apps to free up App ID slots.", comment: "")
-            let message: String
-            
+            guard let appName, let requiredAppIDs, let availableAppIDs, let expirationDate else { return baseMessage }
+            var message: String
+
             if requiredAppIDs > 1
             {
                 let availableText: String
@@ -70,23 +215,23 @@ enum OperationError: LocalizedError
                 default: availableText = String(format: NSLocalizedString("only %@ are available", comment: ""), NSNumber(value: availableAppIDs))
                 }
                 
-                let prefixMessage = String(format: NSLocalizedString("%@ requires %@ App IDs, but %@.", comment: ""), application.name, NSNumber(value: requiredAppIDs), availableText)
-                message = prefixMessage + " " + baseMessage
+                let prefixMessage = String(format: NSLocalizedString("%@ requires %@ App IDs, but %@.", comment: ""), appName, NSNumber(value: requiredAppIDs), availableText)
+                message = prefixMessage + " " + baseMessage + "\n\n"
             }
             else
             {
-                let dateComponents = Calendar.current.dateComponents([.day, .hour, .minute], from: Date(), to: date)
-                
-                let dateComponentsFormatter = DateComponentsFormatter()
-                dateComponentsFormatter.maximumUnitCount = 1
-                dateComponentsFormatter.unitsStyle = .full
-                
-                let remainingTime = dateComponentsFormatter.string(from: dateComponents)!
-                
-                let remainingTimeMessage = String(format: NSLocalizedString("You can register another App ID in %@.", comment: ""), remainingTime)
-                message = baseMessage + " " + remainingTimeMessage
+                message = baseMessage + " "
             }
-            
+
+            let dateComponents = Calendar.current.dateComponents([.day, .hour, .minute], from: Date(), to: expirationDate)
+            let dateFormatter = DateComponentsFormatter()
+            dateFormatter.maximumUnitCount = 1
+            dateFormatter.unitsStyle = .full
+
+            let remainingTime = dateFormatter.string(from: dateComponents)!
+
+            message += String(format: NSLocalizedString("You can register another App ID in %@.", comment: ""), remainingTime)
+
             return message
             
         default: return nil
@@ -108,7 +253,7 @@ extension MinimuxerError: LocalizedError {
         case .NoDevice:
             return NSLocalizedString("Cannot fetch the device from the muxer", comment: "")
         case .NoConnection:
-            return NSLocalizedString("Unable to connect to the device, make sure Wireguard is enabled and you're connected to WiFi", comment: "")
+            return NSLocalizedString("Unable to connect to the device, make sure Wireguard is enabled and you're connected to WiFi. This could mean an invalid pairing.", comment: "")
         case .PairingFile:
             return NSLocalizedString("Invalid pairing file. Your pairing file either didn't have a UDID, or it wasn't a valid plist. Please use jitterbugpair to generate it", comment: "")
             
@@ -138,9 +283,9 @@ extension MinimuxerError: LocalizedError {
         case .CreateAfc:
             return self.createService(name: "AFC")
         case .RwAfc:
-            return NSLocalizedString("AFC was unable to manage files on the device", comment: "")
-        case .InstallApp:
-            return NSLocalizedString("Unable to install the app from the staging directory", comment: "")
+            return NSLocalizedString("AFC was unable to manage files on the device. This usually means an invalid pairing.", comment: "")
+        case .InstallApp(let message):
+            return NSLocalizedString("Unable to install the app: \(message.toString())", comment: "")
         case .UninstallApp:
             return NSLocalizedString("Unable to uninstall the app", comment: "")
 

AltStore/Operations/Patch App/PatchAppOperation.swift

@@ -25,22 +25,38 @@ protocol PatchAppContext
     var error: Error? { get }
 }
 
-enum PatchAppError: LocalizedError
+extension PatchAppError
 {
-    case unsupportedOperatingSystemVersion(OperatingSystemVersion)
-    
-    var errorDescription: String? {
-        switch self
-        {
-        case .unsupportedOperatingSystemVersion(let osVersion):
-            var osVersionString = "\(osVersion.majorVersion).\(osVersion.minorVersion)"
-            if osVersion.patchVersion != 0
-            {
-                osVersionString += ".\(osVersion.patchVersion)"
+    enum Code: Int, ALTErrorCode, CaseIterable {
+        typealias Error = PatchAppError
+
+        case unsupportedOperatingSystemVersion
+    }
+
+    static func unsupportedOperatingSystemVersion(_ osVersion: OperatingSystemVersion) -> PatchAppError {
+        PatchAppError(code: .unsupportedOperatingSystemVersion, osVersion: osVersion)
+    }
+}
+
+struct PatchAppError: ALTLocalizedError {
+    let code: Code
+
+    var errorTitle: String?
+    var errorFailure: String?
+
+    var osVersion: OperatingSystemVersion?
+
+    var errorFailureReason: String {
+        switch self.code {
+        case .unsupportedOperatingSystemVersion:
+            let osVersionString: String
+
+            if let osVersion = self.osVersion?.stringValue {
+                osVersionString = NSLocalizedString("iOS", comment: "") + " " + osVersion
+            } else {
+                osVersionString = NSLocalizedString("your device's iOS version", comment: "")
             }
-            
-            let errorDescription = String(format: NSLocalizedString("The OTA download URL for iOS %@ could not be determined.", comment: ""), osVersionString)
-            return errorDescription
+            return String(format: NSLocalizedString("The OTA download URL for %@ could not be determined.", comment: ""), osVersionString)
         }
     }
 }
@@ -82,7 +98,9 @@ final class PatchAppOperation: ResultOperation<Void>
             return
         }
         
-        guard let resignedApp = self.context.resignedApp else { return self.finish(.failure(OperationError.invalidParameters)) }
+        guard let resignedApp = self.context.resignedApp else {
+            return self.finish(.failure(OperationError.invalidParameters("PatchAppOperation.main: self.context.resignedApp is nil")))
+        }
         
         self.progressHandler?(self.progress, NSLocalizedString("Downloading iOS firmware...", comment: ""))
                 

AltStore/Operations/Patch App/PatchViewController.swift

@@ -439,7 +439,7 @@ private extension PatchViewController
                             
                             do
                             {
-                                guard let (bundleIdentifier, result) = results.first else { throw refreshGroup?.context.error ?? OperationError.unknown }
+                                guard let (bundleIdentifier, result) = results.first else { throw refreshGroup?.context.error ?? OperationError.unknown() }
                                 _ = try result.get()
                                 
                                 if var patchedApps = UserDefaults.standard.patchedApps, let index = patchedApps.firstIndex(of: bundleIdentifier)

AltStore/Operations/RefreshAppOperation.swift

@@ -35,31 +35,33 @@ final class RefreshAppOperation: ResultOperation<InstalledApp>
         
         do
         {
-            if let error = self.context.error
-            {
-                throw error
+            if let error = self.context.error {
+                print("RefreshAppOperation.main: ERROR: self.context.app = \(self.context.app!); self.context.error is \(error)")
+                return self.finish(.failure(error))
             }
             
-            guard let profiles = self.context.provisioningProfiles else { throw OperationError.invalidParameters }
+            guard let profiles = self.context.provisioningProfiles else {
+                return self.finish(.failure(OperationError.invalidParameters("RefreshAppOperation.main: self.context.provisioningProfiles is nil")))
+            }
             
-            guard let app = self.context.app else { throw OperationError.appNotFound }
-            
-            DatabaseManager.shared.persistentContainer.performBackgroundTask { (context) in
-                print("Sending refresh app request...")
+            guard let app = self.context.app else { return self.finish(.failure(OperationError(.appNotFound(name: nil)))) }
 
-                for p in profiles {
-                    do {
-                        let bytes = p.value.data.toRustByteSlice()
-                        try install_provisioning_profile(bytes.forRust())
-                    } catch {
-                        return self.finish(.failure(error))
-                    }
+            for p in profiles {
+                do {
+                    let bytes = p.value.data.toRustByteSlice()
+                    try install_provisioning_profile(bytes.forRust())
+                } catch {
+                    self.finish(.failure(MinimuxerError.ProfileInstall))
+                }
+
+                DatabaseManager.shared.persistentContainer.performBackgroundTask { (context) in
                     
                     self.progress.completedUnitCount += 1
                     
                     let predicate = NSPredicate(format: "%K == %@", #keyPath(InstalledApp.bundleIdentifier), app.bundleIdentifier)
                     self.managedObjectContext.perform {
                         guard let installedApp = InstalledApp.first(satisfying: predicate, in: self.managedObjectContext) else {
+                            self.finish(.failure(OperationError(.appNotFound(name: app.name))))
                             return
                         }
                         installedApp.update(provisioningProfile: p.value)
@@ -72,9 +74,5 @@ final class RefreshAppOperation: ResultOperation<InstalledApp>
                 }
             }
         }
-        catch
-        {
-            self.finish(.failure(error))
-        }
     }
 }

AltStore/Operations/RemoveAppBackupOperation.swift

@@ -35,7 +35,9 @@ final class RemoveAppBackupOperation: ResultOperation<Void>
             return
         }
         
-        guard let installedApp = self.context.installedApp else { return self.finish(.failure(OperationError.invalidParameters)) }
+        guard let installedApp = self.context.installedApp else {
+            return self.finish(.failure(OperationError.invalidParameters("RemoveAppBackupOperation.main: self.context.installedApp is nil")))
+        }
         installedApp.managedObjectContext?.perform {
             guard let backupDirectoryURL = FileManager.default.backupDirectoryURL(for: installedApp) else { return self.finish(.failure(OperationError.missingAppGroup)) }
             

AltStore/Operations/RemoveAppOperation.swift

@@ -33,7 +33,9 @@ final class RemoveAppOperation: ResultOperation<InstalledApp>
             return
         }
         
-        guard let installedApp = self.context.installedApp else { return self.finish(.failure(OperationError.invalidParameters)) }
+        guard let installedApp = self.context.installedApp else {
+            return self.finish(.failure(OperationError.invalidParameters("RemoveAppOperation.main: self.context.installedApp is nil")))
+        }
         
         installedApp.managedObjectContext?.perform {
             let resignedBundleIdentifier = installedApp.resignedBundleIdentifier

AltStore/Operations/ResignAppOperation.swift

@@ -11,6 +11,7 @@ import Roxas
 
 import AltStoreCore
 import AltSign
+import minimuxer
 
 @objc(ResignAppOperation)
 final class ResignAppOperation: ResultOperation<ALTApplication>
@@ -41,7 +42,12 @@ final class ResignAppOperation: ResultOperation<ALTApplication>
             let profiles = self.context.provisioningProfiles,
             let team = self.context.team,
             let certificate = self.context.certificate
-        else { return self.finish(.failure(OperationError.invalidParameters)) }
+        else {
+            return self.finish(.failure(OperationError.invalidParameters("ResignAppOperation.main: " +
+                                                                         "self.context.team or " +
+                                                                         "self.context.provisioningProfiles or" +
+                                                                         "self.context.certificate is nil")))
+        }
         
         // Prepare app bundle
         let prepareAppProgress = Progress.discreteProgress(totalUnitCount: 2)
@@ -115,7 +121,9 @@ private extension ResignAppOperation
             
             infoDictionary[kCFBundleIdentifierKey as String] = profile.bundleIdentifier
             infoDictionary[Bundle.Info.altBundleID] = identifier
-            infoDictionary[Bundle.Info.devicePairingString] = Bundle.main.object(forInfoDictionaryKey: "ALTPairingFile") as? String
+            infoDictionary[Bundle.Info.devicePairingString] = "<insert pairing file here>"
+            infoDictionary.removeValue(forKey: "DTXcode")
+            infoDictionary.removeValue(forKey: "DTXcodeBuild")
 
             for (key, value) in additionalInfoDictionaryValues
             {
@@ -181,9 +189,9 @@ private extension ResignAppOperation
 
                 if app.isAltStoreApp
                 {
-                    guard let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String else { throw OperationError.unknownUDID }
+                    guard let udid = fetch_udid()?.toString() as? String else { throw OperationError.unknownUDID }
                     guard let pairingFileString = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.devicePairingString) as? String else { throw OperationError.unknownUDID }                    
-                    additionalValues[Bundle.Info.devicePairingString] = pairingFileString
+                    additionalValues[Bundle.Info.devicePairingString] = "<insert pairing file here>"
                     additionalValues[Bundle.Info.deviceID] = udid
                     additionalValues[Bundle.Info.serverID] = UserDefaults.standard.preferredServerID
                     
@@ -202,7 +210,7 @@ private extension ResignAppOperation
                         // The embedded certificate + certificate identifier are already in app bundle, no need to update them.
                     }
                 }
-                else if infoDictionary.keys.contains(Bundle.Info.deviceID), let udid = Bundle.main.object(forInfoDictionaryKey: Bundle.Info.deviceID) as? String
+                else if infoDictionary.keys.contains(Bundle.Info.deviceID), let udid = fetch_udid()?.toString() as? String
                 {
                     // There is an ALTDeviceID entry, so assume the app is using AltKit and replace it with the device's UDID.
                     additionalValues[Bundle.Info.deviceID] = udid
@@ -227,6 +235,7 @@ private extension ResignAppOperation
                 
                 // Prepare app
                 try prepare(appBundle, additionalInfoDictionaryValues: additionalValues)
+                try self.removeMissingAppExtensionReferences(from: appBundle)
                 
                 if let directory = appBundle.builtInPlugInsURL, let enumerator = FileManager.default.enumerator(at: directory, includingPropertiesForKeys: nil, options: [.skipsSubdirectoryDescendants])
                 {
@@ -267,4 +276,28 @@ private extension ResignAppOperation
         
         return progress
     }
+    
+    func removeMissingAppExtensionReferences(from bundle: Bundle) throws
+    {
+        // If app extensions have been removed from an app (either by AltStore or the developer),
+        // we must remove all references to them from SC_Info/Manifest.plist (if it exists).
+        
+        let scInfoURL = bundle.bundleURL.appendingPathComponent("SC_Info")
+        let manifestPlistURL = scInfoURL.appendingPathComponent("Manifest.plist")
+        
+        guard let manifestPlist = NSMutableDictionary(contentsOf: manifestPlistURL), let sinfReplicationPaths = manifestPlist["SinfReplicationPaths"] as? [String] else { return }
+        
+        // Remove references to missing files.
+        let filteredReplicationPaths = sinfReplicationPaths.filter { path in
+            guard let fileURL = URL(string: path, relativeTo: bundle.bundleURL) else { return false }
+            
+            let fileExists = FileManager.default.fileExists(atPath: fileURL.path)
+            return fileExists
+        }
+        
+        manifestPlist["SinfReplicationPaths"] = filteredReplicationPaths
+        
+        // Save updated Manifest.plist to disk.
+        try manifestPlist.write(to: manifestPlistURL)
+    }
 }

AltStore/Operations/SendAppOperation.swift

@@ -33,11 +33,12 @@ final class SendAppOperation: ResultOperation<()>
         
         if let error = self.context.error
         {
-            self.finish(.failure(error))
-            return
+            return self.finish(.failure(error))
         }
         
-        guard let resignedApp = self.context.resignedApp else { return self.finish(.failure(OperationError.invalidParameters)) }
+        guard let resignedApp = self.context.resignedApp else {
+            return self.finish(.failure(OperationError.invalidParameters("SendAppOperation.main: self.resignedApp is nil")))
+        }
         
         // self.context.resignedApp.fileURL points to the app bundle, but we want the .ipa.
         let app = AnyApp(name: resignedApp.name, bundleIdentifier: self.context.bundleIdentifier, url: resignedApp.fileURL)
@@ -49,15 +50,16 @@ final class SendAppOperation: ResultOperation<()>
             do {
                 let bytes = Data(data).toRustByteSlice()
                 try yeet_app_afc(app.bundleIdentifier, bytes.forRust())
+                self.progress.completedUnitCount += 1
+                self.finish(.success(()))
             } catch {
-                return self.finish(.failure(error))
+                self.finish(.failure(MinimuxerError.RwAfc))
+                self.progress.completedUnitCount += 1
+                self.finish(.success(()))
             }
-            
-            self.progress.completedUnitCount += 1
-            self.finish(.success(()))
         } else {
             print("IPA doesn't exist????")
-            self.finish(.failure(ALTServerError(.underlyingError)))
+            self.finish(.failure(OperationError(.appNotFound(name: resignedApp.name))))
         }
     }
 }

AltStore/Operations/VerifyAppOperation.swift

@@ -8,48 +8,87 @@
 
 import Foundation
 
+import AltStoreCore
 import AltSign
 import Roxas
 
-enum VerificationError: ALTLocalizedError
+extension VerificationError
 {
-    case privateEntitlements(ALTApplication, entitlements: [String: Any])
-    case mismatchedBundleIdentifiers(ALTApplication, sourceBundleID: String)
-    case iOSVersionNotSupported(ALTApplication)
+    enum Code: Int, ALTErrorCode, CaseIterable {
+        typealias Error = VerificationError
+
+        case privateEntitlements
+        case mismatchedBundleIdentifiers
+        case iOSVersionNotSupported
+    }
+
+    static func privateEntitlements(_ entitlements: [String: Any], app: ALTApplication) -> VerificationError {
+        VerificationError(code: .privateEntitlements, app: app, entitlements: entitlements)
+    }
+
+    static func mismatchedBundleIdentifiers(sourceBundleID: String, app: ALTApplication) -> VerificationError {
+        VerificationError(code: .mismatchedBundleIdentifiers, app: app, sourceBundleID: sourceBundleID)
+    }
+
+    static func iOSVersionNotSupported(app: AppProtocol, osVersion: OperatingSystemVersion = ProcessInfo.processInfo.operatingSystemVersion, requiredOSVersion: OperatingSystemVersion?) -> VerificationError {
+        VerificationError(code: .iOSVersionNotSupported, app: app)
+    }
+}
+
+struct VerificationError: ALTLocalizedError {
+    let code: Code
+
+    var errorTitle: String?
+    var errorFailure: String?
+
+    @Managed var app: AppProtocol?
+    var entitlements: [String: Any]?
+    var sourceBundleID: String?
+    var deviceOSVersion: OperatingSystemVersion?
+    var requiredOSVersion: OperatingSystemVersion?
     
-    var app: ALTApplication {
-        switch self
-        {
-        case .privateEntitlements(let app, _): return app
-        case .mismatchedBundleIdentifiers(let app, _): return app
-        case .iOSVersionNotSupported(let app): return app
+    var errorDescription: String? {
+        switch self.code {
+        case .iOSVersionNotSupported:
+            guard let deviceOSVersion else { return nil }
+
+            var failureReason = self.errorFailureReason
+            if self.app == nil {
+                let firstLetter = failureReason.prefix(1).lowercased()
+                failureReason = firstLetter + failureReason.dropFirst()
+            }
+
+            return String(formatted: "This device is running iOS %@, but %@", deviceOSVersion.stringValue, failureReason)
+        default: return nil
         }
     }
-    
-    var failure: String? {
-        return String(format: NSLocalizedString("“%@” could not be installed.", comment: ""), app.name)
-    }
-    
-    var failureReason: String? {
-        switch self
+
+    var errorFailureReason: String {
+        switch self.code
         {
-        case .privateEntitlements(let app, _):
-            return String(format: NSLocalizedString("“%@” requires private permissions.", comment: ""), app.name)
-            
-        case .mismatchedBundleIdentifiers(let app, let sourceBundleID):
-            return String(format: NSLocalizedString("The bundle ID “%@” does not match the one specified by the source (“%@”).", comment: ""), app.bundleIdentifier, sourceBundleID)
-            
-        case .iOSVersionNotSupported(let app):
-            let name = app.name
-            
-            var version = "iOS \(app.minimumiOSVersion.majorVersion).\(app.minimumiOSVersion.minorVersion)"
-            if app.minimumiOSVersion.patchVersion > 0
-            {
-                version += ".\(app.minimumiOSVersion.patchVersion)"
+        case .privateEntitlements:
+            let appName = self.$app.name ?? NSLocalizedString("The app", comment: "")
+            return String(formatted: "“%@” requires private permissions.", appName)
+
+        case .mismatchedBundleIdentifiers:
+            if let appBundleID = self.$app.bundleIdentifier, let bundleID = self.sourceBundleID {
+                return String(formatted: "The bundle ID '%@' does not match the one specified by the source ('%@').", appBundleID, bundleID)
+            } else {
+                return NSLocalizedString("The bundle ID does not match the one specified by the source.", comment: "")
+            }
+
+        case .iOSVersionNotSupported:
+            let appName = self.$app.name ?? NSLocalizedString("The app", comment: "")
+            let deviceOSVersion = self.deviceOSVersion ?? ProcessInfo.processInfo.operatingSystemVersion
+
+            guard let requiredOSVersion else {
+                return String(formatted: "%@ does not support iOS %@.", appName, deviceOSVersion.stringValue)
+            }
+            if deviceOSVersion > requiredOSVersion {
+                return String(formatted: "%@ requires iOS %@ or earlier", appName, requiredOSVersion.stringValue)
+            } else {
+                return String(formatted: "%@ requires iOS %@ or later", appName, requiredOSVersion.stringValue)
             }
-            
-            let localizedDescription = String(format: NSLocalizedString("%@ requires %@.", comment: ""), name, version)
-            return localizedDescription
         }
     }
 }
@@ -77,15 +116,21 @@ final class VerifyAppOperation: ResultOperation<Void>
             {
                 throw error
             }
+            let appName = self.context.app?.name ?? NSLocalizedString("The app", comment: "")
+            self.localizedFailure = String(format: NSLocalizedString("%@ could not be installed.", comment: ""), appName)
             
-            guard let app = self.context.app else { throw OperationError.invalidParameters }
+            guard let app = self.context.app else {
+                throw OperationError.invalidParameters("VerifyAppOperation.main: self.context.app is nil")
+            }
             
-            guard app.bundleIdentifier == self.context.bundleIdentifier else {
-                throw VerificationError.mismatchedBundleIdentifiers(app, sourceBundleID: self.context.bundleIdentifier)
+            if !["ny.litritt.ignited", "com.litritt.ignited"].contains(where: { $0 == app.bundleIdentifier }) {
+                guard app.bundleIdentifier == self.context.bundleIdentifier else {
+                    throw VerificationError.mismatchedBundleIdentifiers(sourceBundleID: self.context.bundleIdentifier, app: app)
+                }
             }
             
             guard ProcessInfo.processInfo.isOperatingSystemAtLeast(app.minimumiOSVersion) else {
-                throw VerificationError.iOSVersionNotSupported(app)
+                throw VerificationError.iOSVersionNotSupported(app: app, requiredOSVersion: app.minimumiOSVersion)
             }
             
             if #available(iOS 13.5, *)
@@ -116,7 +161,7 @@ final class VerifyAppOperation: ResultOperation<Void>
                     let entitlements = try PropertyListSerialization.propertyList(from: entitlementsPlist.data(using: .utf8)!, options: [], format: nil) as! [String: Any]
                     
                     app.hasPrivateEntitlements = true
-                    let error = VerificationError.privateEntitlements(app, entitlements: entitlements)
+                    let error = VerificationError.privateEntitlements(entitlements, app: app)
                     self.process(error) { (result) in
                         self.finish(result.mapError { $0 as Error })
                     }
@@ -145,9 +190,10 @@ private extension VerifyAppOperation
         guard let presentingViewController = self.context.presentingViewController else { return completion(.failure(error)) }
         
         DispatchQueue.main.async {
-            switch error
+            switch error.code
             {
-            case .privateEntitlements(_, let entitlements):
+            case .privateEntitlements:
+                guard let entitlements = error.entitlements else { return completion(.failure(error)) }
                 let permissions = entitlements.keys.sorted().joined(separator: "\n")
                 let message = String(format: NSLocalizedString("""
                     You must allow access to these private permissions before continuing:
@@ -166,8 +212,7 @@ private extension VerifyAppOperation
                 }))
                 presentingViewController.present(alertController, animated: true, completion: nil)
                 
-            case .mismatchedBundleIdentifiers: return completion(.failure(error))
-            case .iOSVersionNotSupported: return completion(.failure(error))
+            case .mismatchedBundleIdentifiers, .iOSVersionNotSupported: return completion(.failure(error))
             }
         }
     }