Selective app extension removal (#677)

AltStore/Managing Apps/AppExtensionView.swift

@@ -0,0 +1,81 @@
+//
+//  AppExtensionView.swift
+//  SideStore
+//
+//  Created by June P on 8/17/24.
+//  Copyright © 2024 SideStore. All rights reserved.
+//
+
+import SwiftUI
+import CAltSign
+
+extension ALTApplication: Identifiable {}
+
+struct AppExtensionView: View {
+    var extensions: Set<ALTApplication>
+    @State var selection: [ALTApplication] = []
+        
+    var completion: (_ selection: [ALTApplication]) -> Any?
+    
+    var body: some View {
+        NavigationView {
+            List {
+                ForEach(self.extensions.sorted {
+                    $0.bundleIdentifier < $1.bundleIdentifier
+                }, id: \.self) { item in
+                    MultipleSelectionRow(title: item.bundleIdentifier, isSelected: !selection.contains(item)) {
+                        if self.selection.contains(item) {
+                            self.selection.removeAll(where: { $0 == item })
+                        }
+                        else {
+                            self.selection.append(item)
+                        }
+                    }
+                }
+            }
+            .navigationTitle("App Extensions")
+            .onDisappear {
+                _ = completion(selection)
+            }
+        }
+    }
+}
+
+struct MultipleSelectionRow: View {
+    var title: String
+    var isSelected: Bool
+    var action: () -> Void
+
+    var body: some View {
+        SwiftUI.Button(action: self.action) {
+            HStack {
+                Text(self.title)
+                if self.isSelected {
+                    Spacer()
+                    Image(systemName: "checkmark")
+                }
+            }
+        }
+    }
+}
+
+class AppExtensionViewHostingController: UIHostingController<AppExtensionView> {
+    
+    
+    var completion: Optional<(_ selection: [ALTApplication]) -> Any?> = nil
+    
+    required init(extensions: Set<ALTApplication>, completion: @escaping (_ selection: [ALTApplication]) -> Any?) {
+        self.completion = completion
+        super.init(rootView: AppExtensionView(extensions: extensions, completion: completion))
+    }
+    
+    @MainActor required dynamic init?(coder aDecoder: NSCoder) {
+        super.init(coder: aDecoder)
+    }
+}
+
+extension AppExtensionViewHostingController: UIPopoverPresentationControllerDelegate {
+    func adaptivePresentationStyle(for controller: UIPresentationController) -> UIModalPresentationStyle {
+        return .none
+    }
+}

AltStore/Managing Apps/AppManager.swift

@@ -8,6 +8,7 @@
 
 import Foundation
 import UIKit
+import SwiftUI
 import UserNotifications
 import MobileCoreServices
 import Intents
@@ -43,7 +44,7 @@ final class AppManager
     static let shared = AppManager()
     
     private(set) var updatePatronsResult: Result<Void, Error>?
-    
+        
     private let operationQueue = OperationQueue()
     private let serialOperationQueue = OperationQueue()
 
@@ -1014,7 +1015,7 @@ private extension AppManager
         return group
     }
     
-    func removeAppExtensions(from application: ALTApplication, _ presentingViewController: UIViewController, completion: @escaping (Result<Void, Error>) -> Void)
+    func removeAppExtensions(from application: ALTApplication, extensions: Set<ALTApplication>, _ presentingViewController: UIViewController, completion: @escaping (Result<Void, Error>) -> Void)
     {
         guard !application.appExtensions.isEmpty else { return completion(.success(())) }
         
@@ -1029,7 +1030,7 @@ private extension AppManager
             firstSentence = NSLocalizedString("Non-developer Apple IDs are limited to creating 10 App IDs per week.", comment: "")
         }
         
-        let message = firstSentence + " " + NSLocalizedString("Would you like to remove this app's extensions so they don't count towards your limit?", comment: "")
+        let message = firstSentence + " " + NSLocalizedString("Would you like to remove this app's extensions so they don't count towards your limit? There are \(extensions.count) Extensions", comment: "")
         
         let alertController = UIAlertController(title: NSLocalizedString("App Contains Extensions", comment: ""), message: message, preferredStyle: .alert)
         alertController.addAction(UIAlertAction(title: UIAlertAction.cancel.title, style: UIAlertAction.cancel.style, handler: { (action) in
@@ -1054,6 +1055,43 @@ private extension AppManager
             }
         })
         
+        alertController.addAction(UIAlertAction(title: NSLocalizedString("Choose App Extensions", comment: ""), style: .default) { (action) in
+            let popoverContentController = AppExtensionViewHostingController(extensions: extensions) { (selection) in
+                do
+                {
+                    for appExtension in selection
+                    {
+                        print("Deleting extension \(appExtension.bundleIdentifier)")
+                        
+                        try FileManager.default.removeItem(at: appExtension.fileURL)
+                    }
+                    completion(.success(()))
+                }
+                catch
+                {
+                    completion(.failure(error))
+                }
+                return nil
+            }
+            
+            let suiview = popoverContentController.view!
+            suiview.translatesAutoresizingMaskIntoConstraints = false
+            
+            popoverContentController.modalPresentationStyle = .popover
+            
+            if let popoverPresentationController = popoverContentController.popoverPresentationController {
+                popoverPresentationController.sourceView = presentingViewController.view
+                popoverPresentationController.sourceRect = CGRect(x: 50, y: 50, width: 4, height: 4)
+                popoverPresentationController.delegate = popoverContentController
+                
+                DispatchQueue.main.async {
+                    presentingViewController.present(popoverContentController, animated: true)
+                }
+            }
+            
+
+        })
+        
         DispatchQueue.main.async {
             presentingViewController.present(alertController, animated: true)
         }
@@ -1151,7 +1189,7 @@ private extension AppManager
                 guard let app = context.app, let presentingViewController = context.authenticatedContext.presentingViewController else { throw OperationError.invalidParameters }
                 
                 
-                self?.removeAppExtensions(from: app, presentingViewController) { result in
+                self?.removeAppExtensions(from: app, extensions: extensions, presentingViewController) { result in
                     switch result {
                     case .success(): break
                     case .failure(let error): context.error = error

AltStore/My Apps/MyAppsViewController.swift

@@ -1084,7 +1084,7 @@ private extension MyAppsViewController
             message = NSLocalizedString("This will also erase all backup data for this app.", comment: "")
         }
 
-        let alertController = UIAlertController(title: title, message: message, preferredStyle: .actionSheet)
+        let alertController = UIAlertController(title: title, message: message, preferredStyle: .alert)
         alertController.addAction(.cancel)
         alertController.addAction(UIAlertAction(title: NSLocalizedString("Remove", comment: ""), style: .destructive, handler: { (action) in
             AppManager.shared.remove(installedApp) { (result) in