From a967a7aaad4172857eb9642531a470ff5b492cfe Mon Sep 17 00:00:00 2001 From: Magesh K <47920326+mahee96@users.noreply.github.com> Date: Thu, 2 Jan 2025 20:48:25 +0530 Subject: [PATCH] [diagnostics]: make operations logging into console to be conditional, toggled by a switch in settings --- AltStore/Operations/Operation.swift | 11 +- AltStore/Settings/Settings.storyboard | 115 ++++++++++++------ .../Settings/SettingsViewController.swift | 18 ++- .../Extensions/UserDefaults+AltStore.swift | 2 + 4 files changed, 98 insertions(+), 48 deletions(-) diff --git a/AltStore/Operations/Operation.swift b/AltStore/Operations/Operation.swift index 0bf322dc..4480925f 100644 --- a/AltStore/Operations/Operation.swift +++ b/AltStore/Operations/Operation.swift @@ -38,10 +38,13 @@ class ResultOperation: Operation result = .failure(error) } - // diagnostics logging - let resultStatus = String(describing: result).prefix("success".count).uppercased() - print("\n ====> OPERATION: `\(type(of: self))` completed with: \(resultStatus) <====\n\n" + - " Result: \(result)\n") + // Diagnostics: perform verbose logging of the operations only if enabled (so as to not flood console logs) + if UserDefaults.standard.isVerboseOperationsLoggingEnabled { + // diagnostics logging + let resultStatus = String(describing: result).prefix("success".count).uppercased() + print("\n ====> OPERATION: `\(type(of: self))` completed with: \(resultStatus) <====\n\n" + + " Result: \(result)\n") + } self.resultHandler?(result) diff --git a/AltStore/Settings/Settings.storyboard b/AltStore/Settings/Settings.storyboard index 52194d8a..4e4c302f 100644 --- a/AltStore/Settings/Settings.storyboard +++ b/AltStore/Settings/Settings.storyboard @@ -21,7 +21,7 @@ - +