neoarz/SideStore
1
0
Fork 0
mirror of https://github.com/SideStore/SideStore.git synced 2026-02-12 16:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Verifies Sources don’t contain duplicate bundle IDs

Browse Source 
AltStore assumes all apps have unique bundle IDs per source. Weird bugs can occur when this is not the case (such as merging multiple store listings into one), so we now verify upfront whether source contains duplicate bundle IDs before saving.
This commit is contained in:
Riley Testut
2022-11-22 13:02:19 -06:00
parent 579885acd6
commit 96dec5329d
4 changed files with 76 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
AltStore/Managing Apps/AppManager.swift
View File

@@ -394,10 +394,13 @@ extension AppManager
switch result
{
case .success(let source): fetchedSources.insert(source)
case .failure(let error):
case .failure(let nsError as NSError):
let source = managedObjectContext.object(with: source.objectID) as! Source
source.error = (error as NSError).sanitizedForSerialization()
let title = String(format: NSLocalizedString("Unable to Refresh “%@” Source", comment: ""), source.name)
let error = nsError.withLocalizedTitle(title)
errors[source] = error
source.error = error.sanitizedForSerialization()
}
dispatchGroup.leave()

6
AltStore/Managing Apps/AppManagerErrors.swift
View File

@@ -27,16 +27,16 @@ extension AppManager
self.managedObjectContext?.performAndWait {
if self.sources?.count == 1
{
localizedTitle = NSLocalizedString("Failed to Refresh Store", comment: "")
localizedTitle = NSLocalizedString("Unable to Refresh Store", comment: "")
}
else if self.errors.count == 1
{
guard let source = self.errors.keys.first else { return }
localizedTitle = String(format: NSLocalizedString("Failed to Refresh Source “%@”", comment: ""), source.name)
localizedTitle = String(format: NSLocalizedString("Unable to Refresh “%@” Source", comment: ""), source.name)
}
else
{
localizedTitle = String(format: NSLocalizedString("Failed to Refresh %@ Sources", comment: ""), NSNumber(value: self.errors.count))
localizedTitle = String(format: NSLocalizedString("Unable to Refresh %@ Sources", comment: ""), NSNumber(value: self.errors.count))
}
}