Authenticates before checking for AltServers

This means Auth flow is presented even when AltServer is not nearby.

AltStore/Managing Apps/AppManager.swift

@@ -175,17 +175,6 @@ private extension AppManager
     {
         // Authenticate -> Download (if necessary) -> Resign -> Send -> Install.
         let group = group ?? OperationGroup()
-                
-        guard let server = ServerManager.shared.discoveredServers.first(where: { $0.isPreferred }) ?? ServerManager.shared.discoveredServers.first else {
-            DispatchQueue.main.async {
-                group.completionHandler?(.failure(ConnectionError.serverNotFound))
-            }
-            
-            return group
-        }
-        
-        group.server = server
-        
         var operations = [Operation]()
         
         
@@ -200,6 +189,18 @@ private extension AppManager
         }
         operations.append(authenticationOperation)
         
+        /* Find Server */
+        let findServerOperation = FindServerOperation(group: group)
+        findServerOperation.resultHandler = { (result) in
+            switch result
+            {
+            case .failure(let error): group.error = error
+            case .success(let server): group.server = server
+            }
+        }
+        findServerOperation.addDependency(authenticationOperation)
+        operations.append(findServerOperation)
+        
         
         for app in apps
         {
@@ -213,7 +214,7 @@ private extension AppManager
                 guard let resignedApp = self.process(result, context: context) else { return }
                 context.resignedApp = resignedApp
             }
-            resignAppOperation.addDependency(authenticationOperation)
+            resignAppOperation.addDependency(findServerOperation)
             progress.addChild(resignAppOperation.progress, withPendingUnitCount: 20)
             operations.append(resignAppOperation)
             
@@ -246,12 +247,13 @@ private extension AppManager
             {
                 // App is not yet installed (or we're forcing it to download a new version), so download it before resigning it.
                 
-                let downloadOperation = DownloadAppOperation(app: app)
+                let downloadOperation = DownloadAppOperation(app: app, context: context)
                 downloadOperation.resultHandler = { (result) in
                     guard let app = self.process(result, context: context) else { return }
                     context.app = app
                 }
                 progress.addChild(downloadOperation.progress, withPendingUnitCount: 40)
+                downloadOperation.addDependency(findServerOperation)
                 resignAppOperation.addDependency(downloadOperation)
                 operations.append(downloadOperation)
             }

AltStore/Operations/DownloadAppOperation.swift

@@ -15,6 +15,7 @@ import AltSign
 class DownloadAppOperation: ResultOperation<ALTApplication>
 {
     let app: AppProtocol
+    let context: AppOperationContext
     
     private let bundleIdentifier: String
     private let sourceURL: URL
@@ -22,9 +23,11 @@ class DownloadAppOperation: ResultOperation<ALTApplication>
     
     private let session = URLSession(configuration: .default)
     
-    init(app: AppProtocol)
+    init(app: AppProtocol, context: AppOperationContext)
     {
         self.app = app
+        self.context = context
+        
         self.bundleIdentifier = app.bundleIdentifier
         self.sourceURL = app.url
         self.destinationURL = InstalledApp.fileURL(for: app)
@@ -38,6 +41,12 @@ class DownloadAppOperation: ResultOperation<ALTApplication>
     {
         super.main()
         
+        if let error = self.context.error
+        {
+            self.finish(.failure(error))
+            return
+        }
+        
         print("Downloading App:", self.bundleIdentifier)
         
         func finishOperation(_ result: Result<URL, Error>)

AltStore/Operations/FindServerOperation.swift

@@ -0,0 +1,51 @@
+//
+//  FindServerOperation.swift
+//  AltStore
+//
+//  Created by Riley Testut on 9/8/19.
+//  Copyright © 2019 Riley Testut. All rights reserved.
+//
+
+import Foundation
+import Roxas
+
+@objc(FindServerOperation)
+class FindServerOperation: ResultOperation<Server>
+{
+    let group: OperationGroup
+    
+    init(group: OperationGroup)
+    {
+        self.group = group
+        
+        super.init()
+    }
+    
+    override func main()
+    {
+        super.main()
+        
+        if let error = self.group.error
+        {
+            self.finish(.failure(error))
+            return
+        }
+        
+        if let server = ServerManager.shared.discoveredServers.first(where: { $0.isPreferred })
+        {
+            // Preferred server.
+            self.finish(.success(server))
+        }
+        else if let server = ServerManager.shared.discoveredServers.first
+        {
+            // Any available server.
+            self.finish(.success(server))
+        }
+        else
+        {
+            // No servers.
+            self.finish(.failure(ConnectionError.serverNotFound))
+        }
+    }
+}
+