Merge branch 'module_refactoring' into develop

AltStore/Operations/AuthenticationOperation.swift

@@ -10,7 +10,7 @@ import Foundation
 import Roxas
 import Network
 
-import AltKit
+import AltStoreCore
 import AltSign
 
 enum AuthenticationError: LocalizedError

AltStore/Operations/BackgroundRefreshAppsOperation.swift

@@ -0,0 +1,272 @@
+//
+//  BackgroundRefreshAppsOperation.swift
+//  AltStore
+//
+//  Created by Riley Testut on 7/6/20.
+//  Copyright © 2020 Riley Testut. All rights reserved.
+//
+
+import UIKit
+import CoreData
+
+import AltStoreCore
+
+enum RefreshError: LocalizedError
+{
+    case noInstalledApps
+    
+    var errorDescription: String? {
+        switch self
+        {
+        case .noInstalledApps: return NSLocalizedString("No active apps require refreshing.", comment: "")
+        }
+    }
+}
+
+private extension CFNotificationName
+{
+    static let requestAppState = CFNotificationName("com.altstore.RequestAppState" as CFString)
+    static let appIsRunning = CFNotificationName("com.altstore.AppState.Running" as CFString)
+    
+    static func requestAppState(for appID: String) -> CFNotificationName
+    {
+        let name = String(CFNotificationName.requestAppState.rawValue) + "." + appID
+        return CFNotificationName(name as CFString)
+    }
+    
+    static func appIsRunning(for appID: String) -> CFNotificationName
+    {
+        let name = String(CFNotificationName.appIsRunning.rawValue) + "." + appID
+        return CFNotificationName(name as CFString)
+    }
+}
+
+private let ReceivedApplicationState: @convention(c) (CFNotificationCenter?, UnsafeMutableRawPointer?, CFNotificationName?, UnsafeRawPointer?, CFDictionary?) -> Void =
+{ (center, observer, name, object, userInfo) in
+    guard let name = name, let observer = observer else { return }
+    
+    let operation = unsafeBitCast(observer, to: BackgroundRefreshAppsOperation.self)
+    operation.receivedApplicationState(notification: name)
+}
+
+@objc(BackgroundRefreshAppsOperation)
+class BackgroundRefreshAppsOperation: ResultOperation<[String: Result<InstalledApp, Error>]>
+{
+    let installedApps: [InstalledApp]
+    private let managedObjectContext: NSManagedObjectContext
+    
+    var presentsFinishedNotification: Bool = true
+    
+    private let refreshIdentifier: String = UUID().uuidString
+    private var runningApplications: Set<String> = []
+    
+    init(installedApps: [InstalledApp])
+    {
+        self.installedApps = installedApps
+        self.managedObjectContext = installedApps.compactMap({ $0.managedObjectContext }).first ?? DatabaseManager.shared.persistentContainer.newBackgroundContext()
+        
+        super.init()
+    }
+    
+    override func finish(_ result: Result<[String: Result<InstalledApp, Error>], Error>)
+    {
+        super.finish(result)
+        
+        self.scheduleFinishedRefreshingNotification(for: result, delay: 0)
+        
+        self.managedObjectContext.perform {
+            self.stopListeningForRunningApps()
+        }
+        
+        DispatchQueue.main.async {
+            if UIApplication.shared.applicationState == .background
+            {
+                ServerManager.shared.stopDiscovering()
+            }
+        }        
+    }
+    
+    override func main()
+    {
+        super.main()
+        
+        guard !self.installedApps.isEmpty else {
+            self.finish(.failure(RefreshError.noInstalledApps))
+            return
+        }
+        
+        if !ServerManager.shared.isDiscovering
+        {
+            ServerManager.shared.startDiscovering()
+        }
+        
+        self.managedObjectContext.perform {
+            print("Apps to refresh:", self.installedApps.map(\.bundleIdentifier))
+            
+            self.startListeningForRunningApps()
+            
+            // Wait for three seconds to:
+            // a) give us time to discover AltServers
+            // b) give other processes a chance to respond to requestAppState notification
+            DispatchQueue.main.asyncAfter(deadline: .now() + 2.0) {
+                self.managedObjectContext.perform {
+                    guard !ServerManager.shared.discoveredServers.isEmpty else { return self.finish(.failure(ConnectionError.serverNotFound)) }
+                    
+                    let filteredApps = self.installedApps.filter { !self.runningApplications.contains($0.bundleIdentifier) }
+                    print("Filtered Apps to Refresh:", filteredApps.map { $0.bundleIdentifier })
+                    
+                    let group = AppManager.shared.refresh(filteredApps, presentingViewController: nil)
+                    group.beginInstallationHandler = { (installedApp) in
+                        guard installedApp.bundleIdentifier == StoreApp.altstoreAppID else { return }
+                        
+                        // We're starting to install AltStore, which means the app is about to quit.
+                        // So, we schedule a "refresh successful" local notification to be displayed after a delay,
+                        // but if the app is still running, we cancel the notification.
+                        // Then, we schedule another notification and repeat the process.
+                        
+                        // Also since AltServer has already received the app, it can finish installing even if we're no longer running in background.
+                        
+                        if let error = group.context.error
+                        {
+                            self.scheduleFinishedRefreshingNotification(for: .failure(error))
+                        }
+                        else
+                        {
+                            var results = group.results
+                            results[installedApp.bundleIdentifier] = .success(installedApp)
+                            
+                            self.scheduleFinishedRefreshingNotification(for: .success(results))
+                        }
+                    }
+                    group.completionHandler = { (results) in
+                        self.finish(.success(results))
+                    }
+                }
+            }
+        }
+    }
+}
+
+private extension BackgroundRefreshAppsOperation
+{
+    func startListeningForRunningApps()
+    {
+        let notificationCenter = CFNotificationCenterGetDarwinNotifyCenter()
+        let observer = Unmanaged.passUnretained(self).toOpaque()
+        
+        for installedApp in self.installedApps
+        {
+            let appIsRunningNotification = CFNotificationName.appIsRunning(for: installedApp.bundleIdentifier)
+            CFNotificationCenterAddObserver(notificationCenter, observer, ReceivedApplicationState, appIsRunningNotification.rawValue, nil, .deliverImmediately)
+            
+            let requestAppStateNotification = CFNotificationName.requestAppState(for: installedApp.bundleIdentifier)
+            CFNotificationCenterPostNotification(notificationCenter, requestAppStateNotification, nil, nil, true)
+        }
+    }
+    
+    func stopListeningForRunningApps()
+    {
+        let notificationCenter = CFNotificationCenterGetDarwinNotifyCenter()
+        let observer = Unmanaged.passUnretained(self).toOpaque()
+        
+        for installedApp in self.installedApps
+        {
+            let appIsRunningNotification = CFNotificationName.appIsRunning(for: installedApp.bundleIdentifier)
+            CFNotificationCenterRemoveObserver(notificationCenter, observer, appIsRunningNotification, nil)
+        }
+    }
+    
+    func receivedApplicationState(notification: CFNotificationName)
+    {
+        let baseName = String(CFNotificationName.appIsRunning.rawValue)
+        
+        let appID = String(notification.rawValue).replacingOccurrences(of: baseName + ".", with: "")
+        self.runningApplications.insert(appID)
+    }
+    
+    func scheduleFinishedRefreshingNotification(for result: Result<[String: Result<InstalledApp, Error>], Error>, delay: TimeInterval = 5)
+    {
+        func scheduleFinishedRefreshingNotification()
+        {
+            self.cancelFinishedRefreshingNotification()
+            
+            let content = UNMutableNotificationContent()
+            
+            var shouldPresentAlert = true
+            
+            do
+            {
+                let results = try result.get()
+                shouldPresentAlert = !results.isEmpty
+                
+                for (_, result) in results
+                {
+                    guard case let .failure(error) = result else { continue }
+                    throw error
+                }
+                
+                content.title = NSLocalizedString("Refreshed Apps", comment: "")
+                content.body = NSLocalizedString("All apps have been refreshed.", comment: "")
+            }
+            catch ConnectionError.serverNotFound
+            {
+                shouldPresentAlert = false
+            }
+            catch RefreshError.noInstalledApps
+            {
+                shouldPresentAlert = false
+            }
+            catch
+            {
+                print("Failed to refresh apps in background.", error)
+                
+                content.title = NSLocalizedString("Failed to Refresh Apps", comment: "")
+                content.body = error.localizedDescription
+                
+                shouldPresentAlert = true
+            }
+            
+            if shouldPresentAlert
+            {
+                let trigger = UNTimeIntervalNotificationTrigger(timeInterval: delay + 1, repeats: false)
+                
+                let request = UNNotificationRequest(identifier: self.refreshIdentifier, content: content, trigger: trigger)
+                UNUserNotificationCenter.current().add(request)
+                
+                if delay > 0
+                {
+                    DispatchQueue.global().asyncAfter(deadline: .now() + delay) {
+                        UNUserNotificationCenter.current().getPendingNotificationRequests() { (requests) in
+                            // If app is still running at this point, we schedule another notification with same identifier.
+                            // This prevents the currently scheduled notification from displaying, and starts another countdown timer.
+                            // First though, make sure there _is_ still a pending request, otherwise it's been cancelled
+                            // and we should stop polling.
+                            guard requests.contains(where: { $0.identifier == self.refreshIdentifier }) else { return }
+                            
+                            scheduleFinishedRefreshingNotification()
+                        }
+                    }
+                }
+            }
+        }
+        
+        if self.presentsFinishedNotification
+        {
+            scheduleFinishedRefreshingNotification()
+        }        
+        
+        // Perform synchronously to ensure app doesn't quit before we've finishing saving to disk.
+        let context = DatabaseManager.shared.persistentContainer.newBackgroundContext()
+        context.performAndWait {
+            _ = RefreshAttempt(identifier: self.refreshIdentifier, result: result, context: context)
+            
+            do { try context.save() }
+            catch { print("Failed to save refresh attempt.", error) }
+        }
+    }
+    
+    func cancelFinishedRefreshingNotification()
+    {
+        UNUserNotificationCenter.current().removePendingNotificationRequests(withIdentifiers: [self.refreshIdentifier])
+    }
+}

AltStore/Operations/BackupAppOperation.swift

@@ -8,7 +8,7 @@
 
 import Foundation
 
-import AltKit
+import AltStoreCore
 import AltSign
 
 extension BackupAppOperation

AltStore/Operations/DeactivateAppOperation.swift

@@ -8,9 +8,8 @@
 
 import Foundation
 
+import AltStoreCore
 import AltSign
-import AltKit
-
 import Roxas
 
 @objc(DeactivateAppOperation)

AltStore/Operations/DownloadAppOperation.swift

@@ -9,6 +9,7 @@
 import Foundation
 import Roxas
 
+import AltStoreCore
 import AltSign
 
 @objc(DownloadAppOperation)

AltStore/Operations/FetchAnisetteDataOperation.swift

@@ -8,9 +8,8 @@
 
 import Foundation
 
+import AltStoreCore
 import AltSign
-import AltKit
-
 import Roxas
 
 @objc(FetchAnisetteDataOperation)

AltStore/Operations/FetchAppIDsOperation.swift

@@ -8,9 +8,8 @@
 
 import Foundation
 
+import AltStoreCore
 import AltSign
-import AltKit
-
 import Roxas
 
 @objc(FetchAppIDsOperation)

AltStore/Operations/FetchProvisioningProfilesOperation.swift

@@ -7,9 +7,10 @@
 //
 
 import Foundation
-import Roxas
 
+import AltStoreCore
 import AltSign
+import Roxas
 
 @objc(FetchProvisioningProfilesOperation)
 class FetchProvisioningProfilesOperation: ResultOperation<[String: ALTProvisioningProfile]>

AltStore/Operations/FetchSourceOperation.swift

@@ -9,6 +9,7 @@
 import Foundation
 import CoreData
 
+import AltStoreCore
 import Roxas
 
 @objc(FetchSourceOperation)
@@ -49,7 +50,7 @@ class FetchSourceOperation: ResultOperation<Source>
                 {
                     let (data, _) = try Result((data, response), error).get()
                     
-                    let decoder = JSONDecoder()
+                    let decoder = AltStoreCore.JSONDecoder()
                     decoder.dateDecodingStrategy = .custom({ (decoder) -> Date in
                         let container = try decoder.singleValueContainer()
                         let text = try container.decode(String.self)

AltStore/Operations/FindServerOperation.swift

@@ -7,7 +7,7 @@
 //
 
 import Foundation
-import AltKit
+
 import Roxas
 
 private let ReceivedServerConnectionResponse: @convention(c) (CFNotificationCenter?, UnsafeMutableRawPointer?, CFNotificationName?, UnsafeRawPointer?, CFDictionary?) -> Void =

AltStore/Operations/InstallAppOperation.swift

@@ -9,7 +9,7 @@
 import Foundation
 import Network
 
-import AltKit
+import AltStoreCore
 import AltSign
 import Roxas
 

AltStore/Operations/OperationContexts.swift

@@ -10,6 +10,7 @@ import Foundation
 import CoreData
 import Network
 
+import AltStoreCore
 import AltSign
 
 class OperationContext

AltStore/Operations/RefreshAppOperation.swift

@@ -8,9 +8,8 @@
 
 import Foundation
 
+import AltStoreCore
 import AltSign
-import AltKit
-
 import Roxas
 
 @objc(RefreshAppOperation)

AltStore/Operations/RefreshGroup.swift

@@ -9,6 +9,7 @@
 import Foundation
 import CoreData
 
+import AltStoreCore
 import AltSign
 
 class RefreshGroup: NSObject

AltStore/Operations/RemoveAppBackupOperation.swift

@@ -8,8 +8,6 @@
 
 import Foundation
 
-import AltKit
-
 @objc(RemoveAppBackupOperation)
 class RemoveAppBackupOperation: ResultOperation<Void>
 {

AltStore/Operations/RemoveAppOperation.swift

@@ -8,7 +8,7 @@
 
 import Foundation
 
-import AltKit
+import AltStoreCore
 
 @objc(RemoveAppOperation)
 class RemoveAppOperation: ResultOperation<InstalledApp>

AltStore/Operations/ResignAppOperation.swift

@@ -9,6 +9,7 @@
 import Foundation
 import Roxas
 
+import AltStoreCore
 import AltSign
 
 @objc(ResignAppOperation)

AltStore/Operations/SendAppOperation.swift

@@ -9,7 +9,7 @@
 import Foundation
 import Network
 
-import AltKit
+import AltStoreCore
 
 @objc(SendAppOperation)
 class SendAppOperation: ResultOperation<ServerConnection>

AltStore/Operations/VerifyAppOperation.swift

@@ -9,8 +9,6 @@
 import Foundation
 
 import AltSign
-import AltKit
-
 import Roxas
 
 enum VerificationError: ALTLocalizedError