neoarz/SideStore
1
0
Fork 0
mirror of https://github.com/SideStore/SideStore.git synced 2026-02-11 15:53:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactors app version comparison logic to always include buildVersion

Browse Source 
Before, whether or not the source included the buildVersion affected the comparison. If present, the buildVersion was used in comparison, if not, only the version itself was used for comparsion.

This meant it was impossible to update from a version with a buildVersion to the same version without one (e.g. going from betas to final releases). Now we _always_ consider the buildVersion in the comparsion, so an earlier entry in versions array without buildVersion can be considered “newer” even if versions match.
This commit is contained in:
Riley Testut
2023-05-26 19:12:13 -05:00
committed by Magesh K
parent 641e7d5f2e
commit 7f9ee81150
4 changed files with 35 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
AltStoreCore/Model/DatabaseManager.swift
View File

@@ -229,7 +229,7 @@ private extension DatabaseManager
}
else
{
storeApp = StoreApp.makeAltStoreApp(version: localApp.version, buildVersion: localApp.buildVersion, in: context)
storeApp = StoreApp.makeAltStoreApp(version: localApp.version, buildVersion: nil, in: context)
storeApp.source = altStoreSource
}
@@ -242,7 +242,10 @@ private extension DatabaseManager
}
else
{
installedApp = InstalledApp(resignedApp: localApp, originalBundleIdentifier: StoreApp.altstoreAppID, certificateSerialNumber: serialNumber, context: context)
//TODO: Support build versions.
// For backwards compatibility reasons, we cannot use localApp's buildVersion as storeBuildVersion,
// or else the latest update will _always_ be considered new because we don't use buildVersions in our source (yet).
installedApp = InstalledApp(resignedApp: localApp, originalBundleIdentifier: StoreApp.altstoreAppID, certificateSerialNumber: serialNumber, storeBuildVersion: nil, context: context)
installedApp.storeApp = storeApp
}
@@ -322,7 +325,7 @@ private extension DatabaseManager
let cachedExpirationDate = installedApp.expirationDate
// Must go after comparing versions to see if we need to update our cached AltStore app bundle.
installedApp.update(resignedApp: localApp, certificateSerialNumber: serialNumber)
installedApp.update(resignedApp: localApp, certificateSerialNumber: serialNumber, storeBuildVersion: nil)
if installedApp.refreshedDate < cachedRefreshedDate
{