From 71212130c54d2b378f6a0cb12837e761eac409e6 Mon Sep 17 00:00:00 2001 From: Magesh K <47920326+mahee96@users.noreply.github.com> Date: Fri, 21 Feb 2025 19:08:42 +0530 Subject: [PATCH] - Bug-Fix: Use LinkedHashMap instead of swift standard dict which preserves insertion order --- AltStore/Sources/AddSourceViewController.swift | 4 ++-- SideStore/Tests/SideStoreTests.xctestplan | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/AltStore/Sources/AddSourceViewController.swift b/AltStore/Sources/AddSourceViewController.swift index a13e8be0..69939b81 100644 --- a/AltStore/Sources/AddSourceViewController.swift +++ b/AltStore/Sources/AddSourceViewController.swift @@ -60,7 +60,7 @@ extension AddSourceViewController class AddSourceViewController: UICollectionViewController { - private var stagedForAdd: [Source: Bool] = [:] + private var stagedForAdd: LinkedHashMap = LinkedHashMap() private lazy var dataSource = self.makeDataSource() private lazy var addSourceDataSource = self.makeAddSourceDataSource() @@ -817,7 +817,7 @@ private extension AddSourceViewController } // remove this kv pair - self.stagedForAdd.removeValue(forKey: staged.source) + _ = self.stagedForAdd.removeValue(forKey: staged.source) } catch is CancellationError { isCancelled = true diff --git a/SideStore/Tests/SideStoreTests.xctestplan b/SideStore/Tests/SideStoreTests.xctestplan index 1b37c370..d0177c64 100644 --- a/SideStore/Tests/SideStoreTests.xctestplan +++ b/SideStore/Tests/SideStoreTests.xctestplan @@ -18,8 +18,6 @@ "testTargets" : [ { "skippedTests" : [ - "UITests", - "UITests\/testBulkAddRecommendedSources()", "UITests\/testLaunchPerformance()", "UITestsLaunchTests", "UITestsLaunchTests\/testLaunch()"