From 5e5896f2bd6dc7ae3b6cb77c439e67852439d09d Mon Sep 17 00:00:00 2001
From: Riley Testut <riley@rileytestut.com>
Date: Thu, 6 Jun 2019 15:35:02 -0700
Subject: [PATCH] [AltServer] Improves ALTDeviceManager logging

---
 AltServer/Devices/ALTDeviceManager.mm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/AltServer/Devices/ALTDeviceManager.mm b/AltServer/Devices/ALTDeviceManager.mm
index 6003b52d..49d398ca 100644
--- a/AltServer/Devices/ALTDeviceManager.mm
+++ b/AltServer/Devices/ALTDeviceManager.mm
@@ -101,6 +101,8 @@ NSErrorDomain const ALTDeviceErrorDomain = @"com.rileytestut.ALTDeviceError";
     }
     else if ([fileURL.pathExtension.lowercaseString isEqualToString:@"ipa"])
     {
+        NSLog(@"Unzipping .ipa...");
+        
         temporaryDirectoryURL = [NSFileManager.defaultManager.temporaryDirectory URLByAppendingPathComponent:[[NSUUID UUID] UUIDString] isDirectory:YES];
         
         NSError *error = nil;
@@ -225,6 +227,8 @@ NSErrorDomain const ALTDeviceErrorDomain = @"com.rileytestut.ALTDeviceError";
         free(files);
     }
     
+    NSLog(@"Writing to device...");
+    
     plist_t options = instproxy_client_options_new();
     instproxy_client_options_add(options, "PackageType", "Developer", NULL);
     
@@ -237,6 +241,8 @@ NSErrorDomain const ALTDeviceErrorDomain = @"com.rileytestut.ALTDeviceError";
         return progress;
     }
     
+    NSLog(@"Finished writing to device.");
+    
     NSValue *value = [NSValue valueWithPointer:(const void *)np];
     
     self.installationClients[UUID] = value;
@@ -254,6 +260,8 @@ NSErrorDomain const ALTDeviceErrorDomain = @"com.rileytestut.ALTDeviceError";
         }
     };
     
+    NSLog(@"Installing to device %@...", udid);
+    
     instproxy_install(ipc, destinationURL.relativePath.fileSystemRepresentation, options, ALTDeviceManagerUpdateStatus, uuidString);
     instproxy_client_options_free(options);
         
@@ -387,9 +395,10 @@ NSErrorDomain const ALTDeviceErrorDomain = @"com.rileytestut.ALTDeviceError";
         }
         
         lockdownd_client_t client = NULL;
-        if (lockdownd_client_new(device, &client, "altserver") != LOCKDOWN_E_SUCCESS)
+        int result = lockdownd_client_new(device, &client, "altserver");
+        if (result != LOCKDOWN_E_SUCCESS)
         {
-            fprintf(stderr, "ERROR: Connecting to device failed!\n");
+            fprintf(stderr, "ERROR: Connecting to device %s failed! (%d)\n", udid, result);
             
             idevice_free(device);