Always displays PatreonViewController loading indicator when fetching patrons

Previously, we only showed the loading indicator if user had not yet cached any Friend Zone patrons.
This commit is contained in:
Riley Testut
2022-09-21 17:31:23 -05:00
committed by Joseph Mattello
parent 67a66d2fcd
commit 46b0d1ceac

View File

@@ -238,7 +238,8 @@ private extension PatreonViewController
@objc func didUpdatePatrons(_ notification: Notification) @objc func didUpdatePatrons(_ notification: Notification)
{ {
DispatchQueue.main.async { DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
// Wait short delay before reloading or else footer won't properly update if it's already visible 🤷
self.collectionView.reloadData() self.collectionView.reloadData()
} }
} }
@@ -270,17 +271,27 @@ extension PatreonViewController
footerView.button.isHidden = false footerView.button.isHidden = false
//footerView.button.addTarget(self, action: #selector(PatreonViewController.fetchPatrons), for: .primaryActionTriggered) //footerView.button.addTarget(self, action: #selector(PatreonViewController.fetchPatrons), for: .primaryActionTriggered)
if self.patronsDataSource.itemCount > 0 switch AppManager.shared.updatePatronsResult
{ {
footerView.button.isHidden = true case .none: footerView.button.isIndicatingActivity = true
} case .success?: footerView.button.isHidden = true
else case .failure?:
{ #if DEBUG
switch AppManager.shared.updatePatronsResult let debug = true
#else
let debug = false
#endif
if self.patronsDataSource.itemCount == 0 || debug
{ {
case .none: footerView.button.isIndicatingActivity = true // Only show error message if there aren't any cached Patrons (or if this is a debug build).
case .success?: footerView.button.isHidden = true
case .failure?: footerView.button.setTitle(NSLocalizedString("Error Loading Patrons", comment: ""), for: .normal) footerView.button.isHidden = false
footerView.button.setTitle(NSLocalizedString("Error Loading Patrons", comment: ""), for: .normal)
}
else
{
footerView.button.isHidden = true
} }
} }