restore changes dropped from altstore by 1713fcc

AltStore/Managing Apps/AppManager.swift

@@ -1957,7 +1957,43 @@ private extension AppManager
         UNUserNotificationCenter.current().add(request)
     }
     
-
+    func log(_ error: Error, for operation: AppOperation)
+    {
+        // Sanitize NSError on same thread before performing background task.
+        let sanitizedError = (error as NSError).sanitizedForSerialization()
+        
+        let loggedErrorOperation: LoggedError.Operation = {
+            switch operation
+            {
+            case .install: return .install
+            case .update: return .update
+            case .refresh: return .refresh
+            case .activate: return .activate
+            case .deactivate: return .deactivate
+            case .backup: return .backup
+            case .restore: return .restore
+            }
+        }()
+                    
+        DatabaseManager.shared.persistentContainer.performBackgroundTask { context in
+            var app = operation.app
+            if let managedApp = app as? NSManagedObject, let tempApp = context.object(with: managedApp.objectID) as? AppProtocol
+            {
+                app = tempApp
+            }
+            
+            do
+            {
+                _ = LoggedError(error: sanitizedError, app: app, operation: loggedErrorOperation, context: context)
+                try context.save()
+            }
+            catch let saveError
+            {
+                print("[ALTLog] Failed to log error \(sanitizedError.domain) code \(sanitizedError.code) for \(app.bundleIdentifier):", saveError)
+            }
+        }
+    }
+    
     func run(_ operations: [Foundation.Operation], context: OperationContext?, requiresSerialQueue: Bool = false)
     {
         // Find "Install AltStore" operation if it already exists in `context`

AltStore/Operations/DownloadAppOperation.swift

@@ -20,6 +20,7 @@ final class DownloadAppOperation: ResultOperation<ALTApplication>
 
     private let appName: String
     private let bundleIdentifier: String
+    private var sourceURL: URL?
     private let destinationURL: URL
 
     private let session = URLSession(configuration: .default)
@@ -32,6 +33,7 @@ final class DownloadAppOperation: ResultOperation<ALTApplication>
 
         self.appName = app.name
         self.bundleIdentifier = app.bundleIdentifier
+        self.sourceURL = app.url
         self.destinationURL = destinationURL
 
         super.init()
@@ -111,7 +113,7 @@ private extension DownloadAppOperation {
     }
 
     func download(@Managed _ app: AppProtocol) {
-        guard let sourceURL = $app.url else { return self.finish(.failure(OperationError.appNotFound(name: self.appName))) }
+        guard let sourceURL = self.sourceURL else { return self.finish(.failure(OperationError.appNotFound(name: self.appName))) }
 
         self.downloadIPA(from: sourceURL) { result in
             do

AltStore/Operations/FetchProvisioningProfilesOperation.swift

@@ -263,6 +263,10 @@ extension FetchProvisioningProfilesOperation
                             {
                                 throw OperationError.maximumAppIDLimitReached(appName: application.name, requiredAppIDs: requiredAppIDs, availableAppIDs: availableAppIDs, expirationDate: expirationDate)
                             }
+                            else
+                            {
+                                throw ALTAppleAPIError(.maximumAppIDLimitReached)
+                            }
                         }
                     }
                     //App ID name must be ascii. If the name is not ascii, using bundleID instead

AltStore/Operations/OperationError.swift

@@ -78,6 +78,7 @@ extension OperationError
     static func openAppFailed(name: String?) -> OperationError {
         OperationError(code: .openAppFailed, appName: name)
     }
+    static let domain = OperationError(code: .unknown)._domain
     
     static func SideJITIssue(error: String?) -> OperationError {
         var o = OperationError(code: .SideJITIssue)

AltStore/Operations/VerifyAppOperation.swift

@@ -116,6 +116,8 @@ final class VerifyAppOperation: ResultOperation<Void>
             {
                 throw error
             }
+            let appName = self.context.app?.name ?? NSLocalizedString("The app", comment: "")
+            self.localizedFailure = String(format: NSLocalizedString("%@ could not be installed.", comment: ""), appName)
             
             guard let app = self.context.app else {
                 throw OperationError.invalidParameters("VerifyAppOperation.main: self.context.app is nil")

AltStore/Settings/Error Log/ErrorLogViewController.swift

@@ -105,8 +105,8 @@ private extension ErrorLogViewController
                         self?.searchFAQ(for: loggedError)
                     },
                     UIAction(title: NSLocalizedString("View More Details", comment: ""), image: UIImage(systemName: "ellipsis.circle")) { [weak self] _ in
-
-                    }
+                        self?.viewMoreDetails(for: loggedError)
+                    },
                 ])
 
                 cell.menuButton.menu = menu

AltStore/Settings/PatreonViewController.swift

@@ -348,7 +348,7 @@ extension PatreonViewController: UICollectionViewDelegateFlowLayout
         switch section
         {
         case .about: return .zero
-        case .patrons: return CGSize(width: 0, height: 0)
+        case .patrons: return CGSize(width: 320, height: 44)
         }
     }
 }