From 0ab47360ff9a9e1eb8894fa55a0a0aca2913f750 Mon Sep 17 00:00:00 2001
From: Magesh K <47920326+mahee96@users.noreply.github.com>
Date: Mon, 16 Dec 2024 16:41:41 +0530
Subject: [PATCH] [App-Size-Optimization]: Updated base configurations to use
 our custom xcconfigs over cocoa pods xcconfigs to set the proper inheritance
 precedence

- This makes the ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES use the main app target config instead of the one set in cocoa pods xcconfig properly.
- Not embedding SWIFT libraries reduces size since swift runtime is not baked into the app
- Swift runtime is already part of iOS since 12.0 and our current app min deployment target is 14.0
---
 AltStore.xcconfig                  |  7 +++++++
 AltStore.xcodeproj/project.pbxproj | 10 ++++------
 AltStoreCore.xcconfig              |  7 +++++++
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/AltStore.xcconfig b/AltStore.xcconfig
index 3366003e..8be166a2 100644
--- a/AltStore.xcconfig
+++ b/AltStore.xcconfig
@@ -1,3 +1,10 @@
 #include "Build.xcconfig"
 
 PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_BUNDLE_IDENTIFIER)
+
+# include cocoa pods config
+#if DEBUG
+  #include? "Pods/Target Support Files/Pods-SideStore/Pods-SideStore.debug.xcconfig"
+#else
+  #include? "Pods/Target Support Files/Pods-SideStore/Pods-SideStore.release.xcconfig"
+#endif
\ No newline at end of file
diff --git a/AltStore.xcodeproj/project.pbxproj b/AltStore.xcodeproj/project.pbxproj
index a6b0d19e..b869173d 100755
--- a/AltStore.xcodeproj/project.pbxproj
+++ b/AltStore.xcodeproj/project.pbxproj
@@ -3248,7 +3248,7 @@
 		};
 		BF66EE872501AE50007EE018 /* Debug */ = {
 			isa = XCBuildConfiguration;
-			baseConfigurationReference = 37C39DA99ADEE21E3BDD056F /* Pods-AltStoreCore.debug.xcconfig */;
+			baseConfigurationReference = B3C3960E284F4F9100DA9E2F /* AltStoreCore.xcconfig */;
 			buildSettings = {
 				APPLICATION_EXTENSION_API_ONLY = YES;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -3286,7 +3286,7 @@
 		};
 		BF66EE882501AE50007EE018 /* Release */ = {
 			isa = XCBuildConfiguration;
-			baseConfigurationReference = 7935E4499B2FC11DA8BAB2CC /* Pods-AltStoreCore.release.xcconfig */;
+			baseConfigurationReference = B3C3960E284F4F9100DA9E2F /* AltStoreCore.xcconfig */;
 			buildSettings = {
 				APPLICATION_EXTENSION_API_ONLY = YES;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -3530,9 +3530,8 @@
 		};
 		BFD2477F2284B9A700981D42 /* Debug */ = {
 			isa = XCBuildConfiguration;
-			baseConfigurationReference = 32741831F952989EC7E74FFA /* Pods-SideStore.debug.xcconfig */;
+			baseConfigurationReference = B3C3960B284F4C9800DA9E2F /* AltStore.xcconfig */;
 			buildSettings = {
-				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = "$(inherited)";
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = YES;
 				CLANG_ENABLE_MODULES = YES;
@@ -3573,9 +3572,8 @@
 		};
 		BFD247802284B9A700981D42 /* Release */ = {
 			isa = XCBuildConfiguration;
-			baseConfigurationReference = C0ED2BA78F87A9001A13E715 /* Pods-SideStore.release.xcconfig */;
+			baseConfigurationReference = B3C3960B284F4C9800DA9E2F /* AltStore.xcconfig */;
 			buildSettings = {
-				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = "$(inherited)";
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = YES;
 				CLANG_ENABLE_MODULES = YES;
diff --git a/AltStoreCore.xcconfig b/AltStoreCore.xcconfig
index c5c159b0..b42c6814 100644
--- a/AltStoreCore.xcconfig
+++ b/AltStoreCore.xcconfig
@@ -1,3 +1,10 @@
 #include "Build.xcconfig"
 
 PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_BUNDLE_IDENTIFIER).AltStoreCore
+
+# include cocoa pods config
+#if DEBUG
+  #include? "Pods/Target Support Files/Pods-AltStoreCore/Pods-AltStoreCore.debug.xcconfig"
+#else
+  #include? "Pods/Target Support Files/Pods-AltStoreCore/Pods-AltStoreCore.release.xcconfig"
+#endif
\ No newline at end of file